Skip to content

chore(e2e): skip and fix tests that fail on K8s and Operator #2878

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

zdrapela
Copy link
Member

@zdrapela zdrapela commented May 16, 2025

Description

Fix Test Kubernetes RBAC Plugin.

Skip tests that are failing on K8s clusters and one on Operator.

Use test.fixme, as it is preferred over test.skip for tests that need to be skipped because they are failing under some circumstances. See https://playwright.dev/docs/api/class-test#test-fixme

Which issue(s) does this PR fix

PR acceptance criteria

Please make sure that the following steps are complete:

  • GitHub Actions are completed and successful
  • Unit Tests are updated and passing
  • E2E Tests are updated and passing
  • Documentation is updated if necessary (requirement for new features)
  • Add a screenshot if the change is UX/UI related

How to test changes / Special notes to the reviewer

Copy link

openshift-ci bot commented May 16, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@zdrapela
Copy link
Member Author

/test

Copy link

openshift-ci bot commented May 16, 2025

@zdrapela: The /test command needs one or more targets.
The following commands are available to trigger required jobs:

/test e2e-tests

The following commands are available to trigger optional jobs:

/test cleanup-mapt-destroy-orphaned-aks-clusters
/test e2e-tests-aks-helm-nightly
/test e2e-tests-aks-operator-nightly
/test e2e-tests-gke-helm-nightly
/test e2e-tests-gke-operator-nightly
/test e2e-tests-nightly
/test e2e-tests-operator-nightly
/test e2e-tests-osd-gcp-helm-nightly
/test e2e-tests-osd-gcp-operator-nightly
/test e2e-tests-upgrade-nightly

Use /test all to run the following jobs that were automatically triggered:

pull-ci-redhat-developer-rhdh-main-e2e-tests

In response to this:

/test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@zdrapela
Copy link
Member Author

/test e2e-tests-aks-operator-nightly

@zdrapela
Copy link
Member Author

@zdrapela
Copy link
Member Author

/test e2e-tests-aks-operator-nightly

@zdrapela zdrapela marked this pull request as ready for review May 16, 2025 09:56
@openshift-ci openshift-ci bot requested review from josephca and subhashkhileri May 16, 2025 09:56
Copy link
Contributor

@zdrapela
Copy link
Member Author

/test e2e-tests-gke-operator-nightly

@zdrapela zdrapela force-pushed the skip-k8s-failing-tests-2025-05-16 branch from d125ace to da9c3e0 Compare May 19, 2025 06:48
@zdrapela
Copy link
Member Author

/test e2e-tests-aks-operator-nightly

Copy link
Contributor

@zdrapela
Copy link
Member Author

/test e2e-tests-aks-operator-nightly

@zdrapela
Copy link
Member Author

/test e2e-tests-gke-operator-nightly

@zdrapela zdrapela force-pushed the skip-k8s-failing-tests-2025-05-16 branch from da9c3e0 to fbcaf56 Compare May 21, 2025 07:53
Copy link
Contributor

@zdrapela
Copy link
Member Author

/test e2e-tests-aks-operator-nightly
/test e2e-tests-gke-operator-nightly

@zdrapela
Copy link
Member Author

/test e2e-tests-aks-helm-nightly
/test e2e-tests-aks-operator-nightly

@zdrapela zdrapela force-pushed the skip-k8s-failing-tests-2025-05-16 branch from 075de0a to babbdeb Compare May 22, 2025 09:18
@zdrapela
Copy link
Member Author

/test e2e-tests-aks-helm-nightly
/test e2e-tests-aks-operator-nightly

@zdrapela
Copy link
Member Author

/test e2e-tests-aks-operator-nightly

Copy link
Contributor

Copy link
Contributor

@zdrapela
Copy link
Member Author

/test e2e-tests-aks-helm-nightly
/test e2e-tests-aks-operator-nightly

@zdrapela zdrapela force-pushed the skip-k8s-failing-tests-2025-05-16 branch from 1d7ad9f to 3823682 Compare May 26, 2025 06:18
@zdrapela
Copy link
Member Author

/test e2e-tests-aks-helm-nightly
/test e2e-tests-aks-operator-nightly

@zdrapela zdrapela force-pushed the skip-k8s-failing-tests-2025-05-16 branch from 7e2b206 to b1dff85 Compare May 30, 2025 09:17
Copy link
Contributor

@zdrapela
Copy link
Member Author

/test e2e-tests-aks-helm-nightly

@zdrapela
Copy link
Member Author

/test e2e-tests-aks-operator-nightly

@gustavolira
Copy link
Member

/lgtm

Copy link

openshift-ci bot commented May 30, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gustavolira

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 349bbe8 into redhat-developer:main May 30, 2025
13 checks passed
albarbaro pushed a commit to albarbaro/rhdh that referenced this pull request Jun 3, 2025
…developer#2878)

* chore(e2e): skip and fix tests that fail on K8s and Operator

* Try to fix RBAC deployment

* Add configuration for K8s plugin on K8s

* Update aks-operator-deployment.sh

* Update kubernetes-rbac.spec.ts

* Revert "Add configuration for K8s plugin on K8s"

This reverts commit babbdeb.

* Align extraEnvVars with OCP

* Revert "Update kubernetes-rbac.spec.ts"

This reverts commit 26a07d6.

* Add Envs for operator tests

* Replace flaky count toBe(1)

* Refactor global floating button for resilience

* Fix

* Attempts to install Operator on AKS

* Update operator.sh

* Update operator.sh

* Add sleep between retires

* Update auditor-rbac.spec.ts

* Revert "Update auditor-rbac.spec.ts"

This reverts commit 246ed59.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants