Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tekton Task images 🏄‍♀️ #458

Merged
merged 18 commits into from
Mar 22, 2021
Merged

Tekton Task images 🏄‍♀️ #458

merged 18 commits into from
Mar 22, 2021

Conversation

ckavili
Copy link
Contributor

@ckavili ckavili commented Mar 12, 2021

What is this PR About?

Many moons ago during a CoP meeting, we have talked about having some base images to use for Tekton jobs (like UBI-based image which has helm cli inside..)

cc: @springdo @pabrahamsson

How do we test this?

github actions are defined for testing.

cc: @redhat-cop/day-in-the-life

@garethahealy
Copy link
Contributor

there is already a conftest task in the hub:

is this providing anything above and beyond that? or just on a RH image?

@ckavili
Copy link
Contributor Author

ckavili commented Mar 12, 2021

yeah, it's pretty much about that..using these instead of pulling a random image from docker.io or dealing with rate limiting etc

@garethahealy
Copy link
Contributor

could we work with the upstream repo and get our image in there? i.e.: we build the image here but don't provide a task and we take "ownership" of it?

there are a few use cases which I think the task could be extended for as well:

@ckavili
Copy link
Contributor Author

ckavili commented Mar 12, 2021

sure, sounds good to me! the task in README was just to say 'hey, here is an example' but I can remove it😅

Copy link
Contributor

@pabrahamsson pabrahamsson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good stuff @ckavili
I added a few inline comments regarding the ubi images

tekton-task-images/conftest/Dockerfile Outdated Show resolved Hide resolved
tekton-task-images/helm/Dockerfile Outdated Show resolved Hide resolved
tekton-task-images/helm/Dockerfile Outdated Show resolved Hide resolved
tekton-task-images/helm/ubi.repo Outdated Show resolved Hide resolved
@garethahealy
Copy link
Contributor

/approve

LGTM, will let @pabrahamsson merge in case there's anything outstanding from his side.

Copy link
Contributor

@pabrahamsson pabrahamsson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@redhat-cop-ci-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: garethahealy, pabrahamsson

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [garethahealy,pabrahamsson]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@redhat-cop-ci-bot redhat-cop-ci-bot merged commit 46b8cae into redhat-cop:master Mar 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants