-
Notifications
You must be signed in to change notification settings - Fork 270
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tekton Task images 🏄♀️ #458
Conversation
🙈 TEST - tekton pr workflow
there is already a conftest task in the hub: is this providing anything above and beyond that? or just on a RH image? |
yeah, it's pretty much about that..using these instead of pulling a random image from docker.io or dealing with rate limiting etc |
could we work with the upstream repo and get our image in there? i.e.: we build the image here but don't provide a task and we take "ownership" of it? there are a few use cases which I think the task could be extended for as well: |
sure, sounds good to me! the task in README was just to say 'hey, here is an example' but I can remove it😅 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good stuff @ckavili
I added a few inline comments regarding the ubi images
/approve LGTM, will let @pabrahamsson merge in case there's anything outstanding from his side. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: garethahealy, pabrahamsson The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What is this PR About?
Many moons ago during a CoP meeting, we have talked about having some base images to use for Tekton jobs (like UBI-based image which has helm cli inside..)
cc: @springdo @pabrahamsson
How do we test this?
github actions are defined for testing.
cc: @redhat-cop/day-in-the-life