StoragePool creation changes for new 2 Nodes + 1 Arbiter cluster

[aruniiird]

When we detect a 2 Nodes + 1 Arbiter cluster, we should only show, '2-way Replication' in 'Data protection policy' list

How is '2 Nodes + 1 Arbiter' cluster detected?
There is an entry in 'Infrastructure' CR's controlPlaneTopology status, value should be HighlyAvailableArbiter.

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: aruniiird
Once this PR has been reviewed and has the lgtm label, please assign alfonsomthd for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[aruniiird]

Currently I have TWO issues,
a. The green arbiter label does not have the expected color and not aligned according to the UX design

UX design

Actual UI

b. Second issue is when you click on the Sortable arrow alonge the Name label (see the above actual UI screenshot), it is going in to a rotating state with a message PersistentVolumes are being provisioned on the selected nodes.

[agarwal-mudit]

/hold
Pls finish the reviews and keep it ready to merge but don't merge till next update

[aruniiird]

One of the TWO issues I was facing is resolved now (the first issue, where Arbiter label was not alligned properly).
Thanks to @bipuladh
Additionally, the table footer text is also fixed. Please see the below screen shot

[aruniiird]

@SanjalKatiyar , @bipuladh , please take a look at the e2e-aws test failure.
Error message:
{ error occurred handling build odf-console-amd64: the build odf-console-amd64 failed after 2m49s with reason DockerBuildFailed: Dockerfile build strategy has failed.}

Don't think this is relevant to this PR

EDIT: above was a different error. now I could see that we have test failures related to getDeviceSetReplica() function
fixing them

[openshift-ci]

@aruniiird: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/odf-console-e2e-aws	1673ffb	link	true	/test odf-console-e2e-aws

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[openshift-merge-robot]

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.