Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RHSTOR-6905: Enhance storage system creation flow #1850

Merged
merged 1 commit into from
Feb 17, 2025
Merged

RHSTOR-6905: Enhance storage system creation flow #1850

merged 1 commit into from
Feb 17, 2025

Conversation

bipuladh
Copy link
Contributor

@bipuladh bipuladh commented Feb 4, 2025 •
edited
Loading

The following changes are introduced:

  1. Removes Provider mode from Deployment type dropdown.
  2. Change the network configuration option.

Unrelated Changes:

  1. Refactor Multus component to its own file.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 4, 2025 •
edited by openshift-ci bot
Loading

@bipuladh: This pull request references RHSTOR-6905 which is a valid jira issue.

In response to this:

The following changes are introduced:

  1. Removes Provider mode from Deployment type dropdown.
  2. Change the network configuration option.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid jira ticket of any type label Feb 4, 2025
@openshift-ci openshift-ci bot added the approved label Feb 4, 2025
@bipuladh bipuladh marked this pull request as draft February 4, 2025 06:08
@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 4, 2025 •
edited by openshift-ci bot
Loading

@bipuladh: This pull request references RHSTOR-6905 which is a valid jira issue.

In response to this:

The following changes are introduced:

  1. Removes Provider mode from Deployment type dropdown.
  2. Change the network configuration option.

Unrelated Changes:

  1. Refactor Multus component to its own file.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@bipuladh bipuladh force-pushed the converged branch 2 times, most recently from ea34b3b to 7df7f16 Compare February 6, 2025 12:08
@bipuladh bipuladh marked this pull request as ready for review February 6, 2025 12:08
@bipuladh bipuladh force-pushed the converged branch 2 times, most recently from 1102e25 to 0f8ef77 Compare February 6, 2025 12:27
@SanjalKatiyar
Copy link
Collaborator

@bipuladh can you plz add screenshots.

@leelavg
Copy link

leelavg commented Feb 10, 2025

just checking, this will also go away isn't it?
image

@bipuladh
Copy link
Contributor Author

just checking, this will also go away isn't it? image

Hey that would be a different PR this involves only the storage cluster creation page.

@bipuladh
Makes changes to converge provider mode with standard deployments
29a0b34 
Add support for NIC in network configuration

Signed-off-by: Bipul Adhikari <[email protected]>
@bipuladh bipuladh requested a review from alfonsomthd February 17, 2025 08:41
@alfonsomthd
Copy link
Collaborator

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Feb 17, 2025
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Feb 17, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alfonsomthd, bipuladh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [alfonsomthd,bipuladh]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit e143482 into red-hat-storage:master Feb 17, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alfonsomthd alfonsomthd Awaiting requested review from alfonsomthd

Assignees

@alfonsomthd alfonsomthd

Labels
approved jira/valid-reference Indicates that this PR references a valid jira ticket of any type lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@bipuladh @openshift-ci-robot @SanjalKatiyar @leelavg @alfonsomthd