Block RDR policy creation for non-DR optimized cluster #1116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GowthamShanmugam
force-pushed
the
RHSTOR-5121
branch
from
9418422 to
7a88480
Compare
GowthamShanmugam
changed the title
GowthamShanmugam
changed the title
GowthamShanmugam
force-pushed
the
RHSTOR-5121
branch
from
7a88480 to
49be885
Compare
| {errorMessage?.description} | ||
| </Alert> | ||
| (!!errorMessage.scope | ||
| ? errorMessage?.scope === replicationType |
There was a problem hiding this comment.
Suggested change
| ? errorMessage?.scope === replicationType | |
| ? errorMessage.scope === replicationType |
locales/en/plugin__odf-console.json
Outdated
| "1 or more managed clusters are offline": "1 or more managed clusters are offline", | ||
| "The status for both the managed clusters must be available for creating a DR policy. To restore a cluster to an available state, refer to the instructions in the ACM documentation.": "The status for both the managed clusters must be available for creating a DR policy. To restore a cluster to an available state, refer to the instructions in the ACM documentation.", | ||
| "Cannot proceed with one or more selected clusters": "Cannot proceed with one or more selected clusters", | ||
| "We could not retrieve any information about the managed cluster {{names}}. Check the documentation for potential causes and follow the steps mentioned and try again.": "We could not retrieve any information about the managed cluster {{names}}. Check the documentation for potential causes and follow the steps mentioned and try again.", | ||
| "{{ names }} has either an unsupported ODF version or the ODF operator is missing, install or update to ODF {{ version }} or the latest version to enable DR protection.": "{{ names }} has either an unsupported ODF version or the ODF operator is missing, install or update to ODF {{ version }} or the latest version to enable DR protection.", | ||
| "{{ names }} is not connected to RHCS": "{{ names }} is not connected to RHCS", | ||
| "Cluster not pre-configured for Regional-DR": "Cluster not pre-configured for Regional-DR", | ||
| "The selected cluster(s)[{{clusters}}] is not pre-configured for a Regional-DR setup. Migrated the cluster's OSD to optimise it for Disaster recovery services. To learn more about OSDs migration best practices and its consequences refer to the documentation.": "The selected cluster(s)[{{clusters}}] is not pre-configured for a Regional-DR setup. Migrated the cluster's OSD to optimise it for Disaster recovery services. To learn more about OSDs migration best practices and its consequences refer to the documentation.", |
There was a problem hiding this comment.
Suggested change
| "The selected cluster(s)[{{clusters}}] is not pre-configured for a Regional-DR setup. Migrated the cluster's OSD to optimise it for Disaster recovery services. To learn more about OSDs migration best practices and its consequences refer to the documentation.": "The selected cluster(s)[{{clusters}}] is not pre-configured for a Regional-DR setup. Migrated the cluster's OSD to optimise it for Disaster recovery services. To learn more about OSDs migration best practices and its consequences refer to the documentation.", | |
| "The selected cluster(s)[{{clusters}}] is not pre-configured for a Regional-DR setup. Migrated the cluster's OSD to optimise it for Disaster recovery services. To learn more about OSDs migration best practices and its consequences refer to the documentation.": "The selected cluster(s)[{{clusters}}] is not pre-configured for a Regional-DR setup. Migrate the cluster's OSD to optimise it for Disaster recovery services. To learn more about OSDs migration best practices and its consequences refer to the documentation.", |
There was a problem hiding this comment.
is this text verified by doc team ??
There was a problem hiding this comment.
should also be OSDs (plural) IMO
There was a problem hiding this comment.
not, yet, this description is suggested by UX, but still microscopy is under review. We can't wait for them to come back, because we are near FF
| @@ -173,15 +186,19 @@ export const DRReplicationType: React.FC<DRReplicationTypeProps> = ({ | |||
| return ( | |||
| <> | |||
| {!!errorMessage ? ( | |||
There was a problem hiding this comment.
what about just:
!!errorMessage && errorMessage?.scope !== replicationType ? {replicationType && (... : <Alert...
|
|
GowthamShanmugam
force-pushed
the
RHSTOR-5121
branch
2 times, most recently
from
a6e340a to
5198ce0
Compare
|
CI un-blocked by: #1125 (PR#1125 is needed because of OCP react-router-dom updates, else components using imports will break). |
GowthamShanmugam
force-pushed
the
RHSTOR-5121
branch
4 times, most recently
from
ad7c1f1 to
1942efd
Compare
|
/approve |
|
/lgtm |
|
/test odf-console-e2e-aws |
Signed-off-by: Gowtham Shanmugasundaram <[email protected]>
GowthamShanmugam
force-pushed
the
RHSTOR-5121
branch
from
f43c16f to
5bb9977
Compare
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bipuladh, GowthamShanmugam, SanjalKatiyar The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On top of: #1111
Issue: https://issues.redhat.com/browse/RHSTOR-5121