Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RHSTOR-5133] Adds Provider Mode support #1115

Merged
merged 1 commit into from
Dec 12, 2023
Merged

[RHSTOR-5133] Adds Provider Mode support #1115

merged 1 commit into from
Dec 12, 2023

Conversation

bipuladh
Copy link
Contributor

@bipuladh bipuladh commented Dec 5, 2023 •
edited
Loading

  • Adds list page for Clients
  • Adds Modal for generating onboarding token for clients
  • Updates ODF dashboard to add Client Status
  • Adds flags for Provider Mode

Screenshots:

  1. List Page

list-page

  1. Onboarding token modal
    modal

  2. Client mismatch popover
    client-version-popover

  3. Status Card
    status-card

Signed-off-by: Bipul Adhikari [email protected]

@bipuladh bipuladh force-pushed the feature-phase2 branch 2 times, most recently from 769cfd5 to 112ecb1 Compare December 7, 2023 10:01
@bipuladh bipuladh changed the title [WIP] Adds Provider Mode support RHSTOR-5133 Adds Provider Mode support Dec 7, 2023
@bipuladh bipuladh changed the title RHSTOR-5133 Adds Provider Mode support [RHSTOR-5133] Adds Provider Mode support Dec 7, 2023
@bipuladh
Copy link
Contributor Author

bipuladh commented Dec 7, 2023

Mock links: https://www.figma.com/proto/Afl7ntvufZTshGyuX701u7/Provider-mode?page-id=0%3A1&type=design&node-id=1-330&viewport=60%2C485%2C0.38&t=ngq3FBzQrHNQyEh6-1&scaling=min-zoom&starting-point-node-id=1%3A330

SanjalKatiyar
SanjalKatiyar requested changes Dec 7, 2023
View reviewed changes
packages/odf/components/odf-dashboard/status-card/utils.ts Outdated Show resolved Hide resolved
packages/odf/components/odf-dashboard/status-card/status-card.tsx Show resolved Hide resolved
packages/odf/components/odf-dashboard/status-card/utils.ts Outdated Show resolved Hide resolved
packages/odf/components/odf-dashboard/status-card/utils.ts Outdated Show resolved Hide resolved
packages/odf/components/storage-consumers/client-list.tsx Outdated Show resolved Hide resolved
packages/odf/components/storage-consumers/client-list.tsx Show resolved Hide resolved
packages/odf/components/storage-consumers/client-list.tsx Outdated Show resolved Hide resolved
packages/odf/components/storage-consumers/onboarding-modal.tsx
const MODAL_TITLE = t('Client onboarding token');

// eslint-disable-next-line @typescript-eslint/no-unused-vars
const [ticket, _setTicket] = React.useState('dummy--text');
Copy link
Collaborator

@SanjalKatiyar SanjalKatiyar Dec 7, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am assuming that u r setting initial state to dummy--text and have eslint-disable-next-line comment as this modal is still WIP... and u did not forget to remove this :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

_setTicket iis not being used so need this

packages/odf/features.ts
@@ -81,6 +85,7 @@ export const setOCSFlags = async (setFlag: SetFeatureFlag) => {
'standalone'
);
setFlag(OCS_NFS_ENABLED, storageCluster?.spec?.nfs?.enable === true);
setFlag(PROVIDER_MODE, isProviderMode(storageCluster));
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just FYI, we will need to move this to redux later... useODFSystemFlags is already taking care of this, u just need to add a new field for isProviderMode in the object (exactly same as other flags)...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need it is a flag to disable extensions for Provider mode.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

aahhh !!
so how will u set this in case of multiple storage cluster CR then ?? right now we are just taking first cluster and checking for the flag, this will not work for multiple clusters...

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe we need to loop over all the CRs...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are we supporting multiple clusters as part of 4.15?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah 1 internal + 1 external... so multiple StorageCluster CRs can be present at a time...

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can filter internal one though... that will always be single

plugins/odf/console-extensions.json Show resolved Hide resolved
@bipuladh bipuladh force-pushed the feature-phase2 branch 4 times, most recently from b7e2a9f to b8db10b Compare December 8, 2023 07:21
@SanjalKatiyar
Copy link
Collaborator

LGTM cc @GowthamShanmugam

@bipuladh
Copy link
Contributor Author

/test odf-console-e2e-aws

@bipuladh
Adds support for HCI Phase 2<RHSTOR-4885>
7b8040b 
Adds list page for Clients
Adds Modal for generating onboarding token for clients
Updates ODF dashboard to add Client Status
Adds flags for Provider Mode
Disables StorageClass and BlockPool creation in Provider mode

Signed-off-by: Bipul Adhikari <[email protected]>
@SanjalKatiyar
Copy link
Collaborator

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Dec 12, 2023
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Dec 12, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bipuladh, SanjalKatiyar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [SanjalKatiyar,bipuladh]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@SanjalKatiyar
Copy link
Collaborator

/test odf-console-e2e-aws

@openshift-merge-bot openshift-merge-bot bot merged commit e70f38c into red-hat-storage:master Dec 12, 2023
3 checks passed
@nehaberry
Copy link

Mock links: https://www.figma.com/proto/Afl7ntvufZTshGyuX701u7/Provider-mode?page-id=0%3A1&type=design&node-id=1-330&viewport=60%2C485%2C0.38&t=ngq3FBzQrHNQyEh6-1&scaling=min-zoom&starting-point-node-id=1%3A330

Do I need special login /password to access this?

Also, are these UI changes available in the provider base cluster dashboard?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SanjalKatiyar SanjalKatiyar SanjalKatiyar requested changes

@GowthamShanmugam GowthamShanmugam Awaiting requested review from GowthamShanmugam

Assignees

@SanjalKatiyar SanjalKatiyar

Labels
approved lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bipuladh @SanjalKatiyar @nehaberry