Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blocking DRPolicy creation for multiple ODF cluster #1110

Closed

Conversation

GowthamShanmugam
Copy link
Contributor

@GowthamShanmugam GowthamShanmugam commented Nov 28, 2023

  1. Replaced most of the custom component implementation with Shared components.
  2. Replaced clusterClaim logic by watching MulticCusterView of ODF config map type.
  3. Blocking DRPolicy creation when more than one configMap is found under OCP.
  4. Unittesting.

JIRA: https://issues.redhat.com/browse/RHSTOR-4943

Copy link
Contributor

openshift-ci bot commented Nov 28, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: GowthamShanmugam
Once this PR has been reviewed and has the lgtm label, please assign sanjalkatiyar for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@GowthamShanmugam
Copy link
Contributor Author

Screenshot from 2023-11-28 19-42-33

@GowthamShanmugam GowthamShanmugam force-pushed the RHSTOR-4943 branch 3 times, most recently from c52c631 to 1302ab5 Compare November 29, 2023 18:39
Copy link
Contributor

openshift-ci bot commented Nov 30, 2023

@GowthamShanmugam: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/odf-console-e2e-aws 2a11543 link true /test odf-console-e2e-aws

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants