-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove unnecessary tool-tips and appset specific details #1105
Remove unnecessary tool-tips and appset specific details #1105
Conversation
<FieldLevelHelp> | ||
<Trans t={t}> | ||
The applications count displays the total number of{' '} | ||
<b>ApplicationSet</b> type applications in all disaster | ||
recovery configured clusters. | ||
</Trans> | ||
</FieldLevelHelp> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should not remove this toolTip completely. Instead, It should clearly mention like:
The applications count displays the total number of applications in all disaster recovery configured clusters.
(or)
The applications count displays the total number of ApplicationSet and Subscription type applications in all disaster recovery configured clusters.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Check with UX about these two options
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Better to go with option 2 for now to be consistent with alert popover text
…dashboard Signed-off-by: Timothy Asir Jeyasingh <[email protected]>
15f4d1c
to
dea6396
Compare
/retest |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bipuladh, GowthamShanmugam, TimothyAsirJeyasing The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/test odf-console-e2e-aws |
3 similar comments
/test odf-console-e2e-aws |
/test odf-console-e2e-aws |
/test odf-console-e2e-aws |
ec0318d
into
red-hat-storage:master
/cherry-pick release-4.15 |
@TimothyAsirJeyasing: new pull request created: #1133 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@TimothyAsirJeyasing: new pull request created: #1134 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/cherry-pick release-4.15-compatibility |
@TimothyAsirJeyasing: cannot checkout In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
No description provided.