Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary tool-tips and appset specific details #1105

Conversation

TimothyAsirJeyasing
Copy link
Contributor

No description provided.

@TimothyAsirJeyasing TimothyAsirJeyasing changed the title WIP: Remove unnecessary tool-tips and appset specific details Remove unnecessary tool-tips and appset specific details Dec 5, 2023
Comment on lines 110 to 116
<FieldLevelHelp>
<Trans t={t}>
The applications count displays the total number of{' '}
<b>ApplicationSet</b> type applications in all disaster
recovery configured clusters.
</Trans>
</FieldLevelHelp>
Copy link
Contributor

@GowthamShanmugam GowthamShanmugam Dec 8, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should not remove this toolTip completely. Instead, It should clearly mention like:

The applications count displays the total number of applications in all disaster recovery configured clusters.

(or)

The applications count displays the total number of ApplicationSet and Subscription type applications in all disaster recovery configured clusters.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check with UX about these two options

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Better to go with option 2 for now to be consistent with alert popover text

@TimothyAsirJeyasing TimothyAsirJeyasing force-pushed the RHSTOR-4989-Remove-tooltips-display-changes branch from 15f4d1c to dea6396 Compare December 8, 2023 13:16
@openshift-ci openshift-ci bot removed the lgtm label Dec 8, 2023
@TimothyAsirJeyasing
Copy link
Contributor Author

image

@TimothyAsirJeyasing
Copy link
Contributor Author

/retest

@openshift-ci openshift-ci bot added the lgtm label Dec 15, 2023
@bipuladh
Copy link
Contributor

/approve

Copy link
Contributor

openshift-ci bot commented Dec 15, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bipuladh, GowthamShanmugam, TimothyAsirJeyasing

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@TimothyAsirJeyasing
Copy link
Contributor Author

/test odf-console-e2e-aws

3 similar comments
@GowthamShanmugam
Copy link
Contributor

/test odf-console-e2e-aws

@TimothyAsirJeyasing
Copy link
Contributor Author

/test odf-console-e2e-aws

@TimothyAsirJeyasing
Copy link
Contributor Author

/test odf-console-e2e-aws

@openshift-merge-bot openshift-merge-bot bot merged commit ec0318d into red-hat-storage:master Dec 18, 2023
3 checks passed
@TimothyAsirJeyasing
Copy link
Contributor Author

/cherry-pick release-4.15

@openshift-cherrypick-robot

@TimothyAsirJeyasing: new pull request created: #1133

In response to this:

/cherry-pick release-4.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot

@TimothyAsirJeyasing: new pull request created: #1134

In response to this:

/cherry-pick release-4.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@TimothyAsirJeyasing
Copy link
Contributor Author

/cherry-pick release-4.15-compatibility

@openshift-cherrypick-robot

@TimothyAsirJeyasing: cannot checkout release-4.15-compatibility: error checking out "release-4.15-compatibility": exit status 1 error: pathspec 'release-4.15-compatibility' did not match any file(s) known to git

In response to this:

/cherry-pick release-4.15-compatibility

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants