Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create StorageSystem: add perfomance mode selector #1102

Merged
merged 1 commit into from
Dec 2, 2023
Merged

Create StorageSystem: add perfomance mode selector #1102

merged 1 commit into from
Dec 2, 2023

Conversation

alfonsomthd
Copy link
Collaborator

@alfonsomthd alfonsomthd commented Nov 14, 2023 •
edited
Loading

Backend counterpart:

perf-mode-tooltip

lean-mode-warning

requirements-not-met

  • Allow only Lean when all selectable nodes do not meet higher profiles:
    disable-others-when-tiny-cluster

  • Review & Create step:
    review-create-step

  • Day-2:
    storagesystems-menu-entry

installed-op-ss-menu-entry

modal-reqs-not-met

modal-ok

@alfonsomthd alfonsomthd marked this pull request as draft November 14, 2023 11:21
@alfonsomthd alfonsomthd marked this pull request as ready for review November 14, 2023 11:22
@alfonsomthd
Copy link
Collaborator Author

/retest

@alfonsomthd alfonsomthd force-pushed the perf-mode branch 3 times, most recently from 7ecf5df to f0c7ca1 Compare November 16, 2023 12:18
@alfonsomthd alfonsomthd marked this pull request as draft November 16, 2023 15:54
SanjalKatiyar
SanjalKatiyar requested changes Nov 17, 2023
View reviewed changes
locales/en/plugin__odf-console.json Outdated Show resolved Hide resolved
locales/en/plugin__odf-console.json Outdated Show resolved Hide resolved
packages/odf/components/create-storage-system/reducer.ts Outdated Show resolved Hide resolved
packages/odf/components/create-storage-system/create-steps.tsx Outdated Show resolved Hide resolved
...storage-system/create-storage-system-steps/capacity-and-nodes-step/configure-performance.tsx Outdated Show resolved Hide resolved
packages/odf/components/system-list/odf-system-list.tsx Show resolved Hide resolved
packages/odf/components/utils/common-odf-install-el.tsx Show resolved Hide resolved
packages/odf/components/utils/common.ts Outdated Show resolved Hide resolved
packages/odf/constants/common.ts Outdated Show resolved Hide resolved
packages/odf/utils/ocs.ts Outdated Show resolved Hide resolved
@alfonsomthd alfonsomthd force-pushed the perf-mode branch 3 times, most recently from b15760e to 4f2ff20 Compare November 21, 2023 15:20
@alfonsomthd
Copy link
Collaborator Author

/assign @bipuladh

@alfonsomthd alfonsomthd marked this pull request as ready for review November 23, 2023 13:03
@GowthamShanmugam
Copy link
Contributor

LGTM

SanjalKatiyar
SanjalKatiyar reviewed Nov 27, 2023
View reviewed changes
Copy link
Collaborator

@SanjalKatiyar SanjalKatiyar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (from my side)... cc Bipul for final tag...

@bipuladh
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot removed the lgtm label Nov 27, 2023
@bipuladh
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Nov 28, 2023
@openshift-ci openshift-ci bot removed the lgtm label Nov 28, 2023
@alfonsomthd
Copy link
Collaborator Author

/retest

@alfonsomthd
Copy link
Collaborator Author

/retest

@alfonsomthd alfonsomthd force-pushed the perf-mode branch 2 times, most recently from 8c6fa9a to 7d3513e Compare December 1, 2023 12:18
@SanjalKatiyar
Copy link
Collaborator

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Dec 2, 2023
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Dec 2, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alfonsomthd, bipuladh, SanjalKatiyar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [SanjalKatiyar,bipuladh]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 0c5b4b3 into red-hat-storage:master Dec 2, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SanjalKatiyar SanjalKatiyar SanjalKatiyar requested changes

@bipuladh bipuladh bipuladh left review comments

@Chandan141996 Chandan141996 Chandan141996 left review comments

@malayparida2000 malayparida2000 malayparida2000 requested changes

Assignees

@SanjalKatiyar SanjalKatiyar

@malayparida2000 malayparida2000

@bipuladh bipuladh

Labels
approved lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@alfonsomthd @GowthamShanmugam @bipuladh @SanjalKatiyar @malayparida2000 @Chandan141996 @openshift-merge-robot