Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Part 3] Imperative app manage data policy changes - WIP (Blocked by ACM console change) #1101

Closed
wants to merge 3 commits into from
Closed

[Part 3] Imperative app manage data policy changes - WIP (Blocked by ACM console change) #1101

wants to merge 3 commits into from

Conversation

GowthamShanmugam
Copy link
Contributor

On top of: #1096, #1100

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Nov 13, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: GowthamShanmugam
Once this PR has been reviewed and has the lgtm label, please assign bipuladh for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@GowthamShanmugam GowthamShanmugam changed the title [Part 1] Imperative apps generic helper compoents on shared - WIP [Part 3] Imperative apps generic helper compoents on shared - WIP Nov 13, 2023
@GowthamShanmugam GowthamShanmugam force-pushed the RHSTOR-4922-part-3 branch 3 times, most recently from 383073b to 7266241 Compare November 14, 2023 09:29
@GowthamShanmugam GowthamShanmugam changed the title [Part 3] Imperative apps generic helper compoents on shared - WIP [Part 3] Imperative app manage data policy changes Nov 14, 2023
@GowthamShanmugam GowthamShanmugam changed the title [Part 3] Imperative app manage data policy changes [Part 3] Imperative app manage data policy changes - WIP Nov 14, 2023
@GowthamShanmugam
Copy link
Contributor Author

/hold

@GowthamShanmugam GowthamShanmugam force-pushed the RHSTOR-4922-part-3 branch 3 times, most recently from 396d16a to 8b1843f Compare November 14, 2023 19:38
@GowthamShanmugam
Copy link
Contributor Author

image

@GowthamShanmugam
Copy link
Contributor Author

image

@GowthamShanmugam
Copy link
Contributor Author

image

@GowthamShanmugam
Copy link
Contributor Author

image

@GowthamShanmugam
Copy link
Contributor Author

image

@GowthamShanmugam GowthamShanmugam changed the title [Part 3] Imperative app manage data policy changes - WIP [Part 3] Imperative app manage data policy changes Nov 14, 2023
@GowthamShanmugam
Copy link
Contributor Author

/test odf-console-e2e-aws

@GowthamShanmugam GowthamShanmugam changed the title [Part 3] Imperative app manage data policy changes [Part 3] Imperative app manage data policy changes - WIP Nov 15, 2023
@GowthamShanmugam GowthamShanmugam changed the title [Part 3] Imperative app manage data policy changes - WIP [Part 3] Imperative app manage data policy changes - WIP (Blocked by ACM console change) Nov 15, 2023
@SanjalKatiyar
Copy link
Collaborator

since it is blocked, are we keeping this for 4.16 @GowthamShanmugam ??

@openshift-merge-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@GowthamShanmugam
Copy link
Contributor Author

This is out of 4.15

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
do-not-merge/hold needs-rebase
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@GowthamShanmugam @SanjalKatiyar @openshift-merge-robot