Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds support for external PG for Noobaa #1098

Merged
merged 1 commit into from
Dec 1, 2023
Merged

Adds support for external PG for Noobaa #1098

merged 1 commit into from
Dec 1, 2023

Conversation

vbnrh
Copy link
Member

@vbnrh vbnrh commented Nov 13, 2023 •
edited
Loading

@vbnrh vbnrh force-pushed the noobaa-external-pg branch from ed175ac to ebc2e7b Compare November 13, 2023 13:12
@vbnrh vbnrh force-pushed the noobaa-external-pg branch from ebc2e7b to 904b023 Compare November 14, 2023 10:48
@vbnrh
Copy link
Member Author

vbnrh commented Nov 14, 2023

/test odf-console-e2e-aws

@SanjalKatiyar
Copy link
Collaborator

image

  1. Password input show have show/hide button (u can check KMS form for this).
  2. Also, Port input's width should be aligned with above input box (again u can check KMS form for this).

SanjalKatiyar
SanjalKatiyar requested changes Nov 17, 2023
View reviewed changes
...te-storage-system/create-storage-system-steps/backing-storage-step/backing-storage-step.scss Outdated Show resolved Hide resolved
packages/odf/components/create-storage-system/reducer.ts Outdated Show resolved Hide resolved
...ge-system-steps/backing-storage-step/noobaa-external-postgres/enable-noobaa-postgres-tls.tsx Outdated Show resolved Hide resolved
...tem/create-storage-system-steps/backing-storage-step/noobaa-external-postgres/key-upload.tsx Outdated Show resolved Hide resolved
...tem/create-storage-system-steps/backing-storage-step/noobaa-external-postgres/key-upload.tsx Outdated Show resolved Hide resolved
...tem/create-storage-system-steps/backing-storage-step/noobaa-external-postgres/key-upload.tsx Outdated Show resolved Hide resolved
...tem/create-storage-system-steps/backing-storage-step/noobaa-external-postgres/key-upload.tsx Outdated Show resolved Hide resolved
...tem/create-storage-system-steps/backing-storage-step/noobaa-external-postgres/key-upload.tsx Outdated Show resolved Hide resolved
packages/odf/components/create-storage-system/payloads.ts Outdated Show resolved Hide resolved
packages/odf/components/utils/common.ts Outdated Show resolved Hide resolved
@vbnrh vbnrh force-pushed the noobaa-external-pg branch from 904b023 to feb7d23 Compare November 28, 2023 11:43
@vbnrh vbnrh force-pushed the noobaa-external-pg branch from feb7d23 to 7ab4576 Compare November 28, 2023 11:45
@vbnrh
Copy link
Member Author

vbnrh commented Nov 28, 2023

image

1. `Password` input show have show/hide button (u can check KMS form for this).

2. Also, `Port` input's width should be aligned with above input box (again u can check KMS form for this).

css fixes are still remaining. Will do it by today or tomorrow but comments are all addressed

@vbnrh vbnrh requested a review from SanjalKatiyar November 28, 2023 11:49
@vbnrh vbnrh force-pushed the noobaa-external-pg branch 2 times, most recently from 81a7598 to 9f1aa7f Compare November 28, 2023 13:28
SanjalKatiyar
SanjalKatiyar reviewed Nov 28, 2023
View reviewed changes
packages/odf/components/create-storage-system/footer.tsx Outdated Show resolved Hide resolved
...te-storage-system/create-storage-system-steps/backing-storage-step/backing-storage-step.scss Outdated Show resolved Hide resolved
...e-system-steps/backing-storage-step/noobaa-external-postgres/postgres-connection-details.tsx Outdated Show resolved Hide resolved
...e-system-steps/backing-storage-step/noobaa-external-postgres/postgres-connection-details.tsx Outdated Show resolved Hide resolved
...e-system-steps/backing-storage-step/noobaa-external-postgres/postgres-connection-details.tsx Outdated Show resolved Hide resolved
packages/odf/components/create-storage-system/footer.tsx Outdated Show resolved Hide resolved
packages/odf/components/create-storage-system/footer.tsx Outdated Show resolved Hide resolved
packages/odf/components/create-storage-system/footer.tsx Show resolved Hide resolved
packages/odf/components/utils/common.ts Outdated Show resolved Hide resolved
@vbnrh vbnrh force-pushed the noobaa-external-pg branch from 9f1aa7f to 0e6600b Compare November 29, 2023 07:28
@vbnrh
Copy link
Member Author

vbnrh commented Nov 29, 2023

Screenshot 2023-11-29 at 12 41 00 PM

CSS Issues fixed !!!

@vbnrh vbnrh force-pushed the noobaa-external-pg branch from 0e6600b to 42efd6b Compare November 29, 2023 07:54
SanjalKatiyar
SanjalKatiyar reviewed Nov 29, 2023
View reviewed changes
Copy link
Collaborator

@SanjalKatiyar SanjalKatiyar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SanjalKatiyar
Copy link
Collaborator

u need to run yarn i18n, build tests are failing...

@TimothyAsirJeyasing
Copy link
Contributor

As per UX it should be "Server name" right ?

@vbnrh vbnrh force-pushed the noobaa-external-pg branch 2 times, most recently from b6c2094 to 8d18da9 Compare November 29, 2023 11:34
@vbnrh
Copy link
Member Author

vbnrh commented Nov 29, 2023

As per UX it should be "Server name" right ?

Fixed it. Thanks

@vbnrh vbnrh requested a review from SanjalKatiyar November 29, 2023 11:35
@vbnrh vbnrh force-pushed the noobaa-external-pg branch from 8d18da9 to 3f68ebe Compare November 29, 2023 11:48
@vbnrh vbnrh force-pushed the noobaa-external-pg branch 2 times, most recently from ea4c59a to 513fe72 Compare November 29, 2023 13:44
@vbnrh vbnrh force-pushed the noobaa-external-pg branch from 513fe72 to 55c29ae Compare November 29, 2023 14:00
@SanjalKatiyar
Copy link
Collaborator

/lgtm

@SanjalKatiyar
Copy link
Collaborator

/approve cancel (cc @bipuladh for approval, in case u have any comment)

@openshift-ci openshift-ci bot removed the approved label Nov 29, 2023
@vbnrh vbnrh force-pushed the noobaa-external-pg branch from 55c29ae to b6ac1d3 Compare November 30, 2023 10:12
@openshift-ci openshift-ci bot removed the lgtm label Nov 30, 2023
@SanjalKatiyar
Copy link
Collaborator

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Nov 30, 2023
@SanjalKatiyar
Copy link
Collaborator

/approve cancel

@openshift-ci openshift-ci bot added approved and removed approved labels Nov 30, 2023
@bipuladh
Copy link
Contributor

/lgtm

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Nov 30, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bipuladh, vbnrh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@TimothyAsirJeyasing
Copy link
Contributor

LGTM

@SanjalKatiyar
Copy link
Collaborator

/test odf-console-e2e-aws

1 similar comment
@vbnrh
Copy link
Member Author

vbnrh commented Dec 1, 2023

/test odf-console-e2e-aws

@openshift-merge-bot openshift-merge-bot bot merged commit b208f71 into red-hat-storage:master Dec 1, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SanjalKatiyar SanjalKatiyar SanjalKatiyar requested changes

@bipuladh bipuladh Awaiting requested review from bipuladh

Assignees

@SanjalKatiyar SanjalKatiyar

@bipuladh bipuladh

Labels
approved lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@vbnrh @SanjalKatiyar @TimothyAsirJeyasing @bipuladh @openshift-merge-robot