Provide option to optimise cluster for Regional-DR #1095

TimothyAsirJeyasing · 2023-11-07T08:21:26Z

No description provided.

TimothyAsirJeyasing · 2023-11-07T08:21:54Z

@GowthamShanmugam Please review

bipuladh · 2023-11-07T08:50:40Z

Please add screenshots

TimothyAsirJeyasing · 2023-11-07T09:04:17Z

GowthamShanmugam · 2023-11-07T09:37:41Z

packages/ocs/constants/common.ts

+export const DISASTER_RECOVERY_TARGET_ANNOTATION =
+  'ocs.openshift.io/clusterIsDisasterRecoveryTarget';


import this constant from odf core

GowthamShanmugam · 2023-11-07T09:38:33Z

packages/ocs/constants/common.ts

+export enum DRSetupStatus {
+  InProgress = 'In Progress',
+  Pending = 'Pending',
+  Completed = 'Completed',
+}


this is not belongs to common, move to new file

GowthamShanmugam · 2023-11-07T09:41:42Z

packages/ocs/constants/common.ts

+export const DISASTER_RECOVERY_TARGET_ANNOTATION =
+  'ocs.openshift.io/clusterIsDisasterRecoveryTarget';
+
+export enum DRSetupStatus {


It is not DR status, it is migration status, please check with Santhos once

GowthamShanmugam · 2023-11-07T09:42:49Z

packages/ocs/dashboards/persistent-external/details-card.tsx

@@ -60,6 +60,7 @@ export const DetailsCard: React.FC = () => {
    : t('Disabled');

  const ocsName = getName(resourcesObj['ocs'].data?.[0]);
+  //const disasterRecoveryStatus = getDRsetupStatus();


Suggested change

//const disasterRecoveryStatus = getDRsetupStatus();

delete this line

GowthamShanmugam · 2023-11-07T09:50:49Z

packages/ocs/dashboards/persistent-internal/details-card.tsx

+  const [data, loaded, loadError] = useK8sList<CephClusterKind>(
+    CephClusterModel,
+    CEPH_NS
+  );


Suggested change

const [data, loaded, loadError] = useK8sList<CephClusterKind>(

CephClusterModel,

CEPH_NS

);

const [cephData, cephLoaded, cephLoadError] = useK8sList<CephClusterKind>(

CephClusterModel,

CEPH_NS

);

GowthamShanmugam · 2023-11-07T10:28:15Z

packages/ocs/dashboards/persistent-internal/details-card.tsx

+                <div
+                  style={{ display: 'flex', justifyContent: 'space-between' }}
+                >
+                  <p>{dRSetupStatus}</p>


dRSetupStatus is not translated

GowthamShanmugam · 2023-11-07T10:28:55Z

packages/ocs/dashboards/persistent-internal/details-card.tsx

+            {loaded && !loadError ? (
+              <div>
+                <div
+                  style={{ display: 'flex', justifyContent: 'space-between' }}


We dont need flux here

GowthamShanmugam · 2023-11-07T10:29:24Z

packages/ocs/dashboards/persistent-internal/details-card.tsx

+                <Modal
+                  variant={ModalVariant.medium}
+                  title={t('Configure cluster for Regional-DR?')}
+                  isOpen={isOpen}
+                  onClose={closeModal}
+                  actions={[
+                    <Button
+                      key="close"
+                      variant="secondary"
+                      onClick={closeModal}
+                    >
+                      Close
+                    </Button>,
+                    <Button
+                      key="optimize"
+                      variant="primary"
+                      onClick={handleOptimize}
+                    >
+                      Optimize
+                    </Button>,
+                  ]}
+                >
+                  <Trans t={t}>
+                    <p>
+                      Optimise the cluster for a Regional-DR setup by migrating
+                      OSDs. Migration may take sometime depending on several
+                      factors. To learn more about OSDs migration best practices
+                      and its consequences refer to the documentation
+                    </p>
+                  </Trans>
+                </Modal>
+              </div>


move this as separate component

GowthamShanmugam · 2023-11-07T10:30:58Z

packages/ocs/dashboards/persistent-internal/details-card.tsx

+                    </Button>,
+                  ]}
+                >
+                  <Trans t={t}>


simply use t('') here

GowthamShanmugam · 2023-11-07T10:31:46Z

packages/ocs/dashboards/persistent-internal/details-card.tsx

+            {updateError && (
+              <Alert isInline variant="danger" title={t('An error occurred')}>
+                {updateError}
+              </Alert>
+            )}


displaying alert on details card is not correct

SanjalKatiyar · 2023-11-17T13:11:04Z

are these brownfield changes only for internal mode dashboard or external mode as well ??

SanjalKatiyar · 2023-11-17T13:13:47Z

packages/ocs/dashboards/persistent-internal/details-card.tsx

+                  {dRSetupStatus === DRSetupStatus.Pending && (
+                    <a onClick={openModal}>Optimize</a>
+                  )}
+                </div>
+                <Modal
+                  variant={ModalVariant.medium}
+                  title={t('Configure cluster for Regional-DR?')}
+                  isOpen={isOpen}
+                  onClose={closeModal}
+                  actions={[
+                    <Button
+                      key="close"
+                      variant="secondary"
+                      onClick={closeModal}
+                    >
+                      Close
+                    </Button>,
+                    <Button
+                      key="optimize"
+                      variant="primary"
+                      onClick={handleOptimize}
+                    >
+                      Optimize


move all this to separate component... instead of polluting existing one (these changes are temporary as well)...

SanjalKatiyar · 2023-11-17T13:14:20Z

packages/ocs/dashboards/persistent-internal/details-card.tsx

+
+    updatedResource.metadata.annotations = {
+      ...getAnnotations(updatedResource, {}),
+      [DISASTER_RECOVERY_TARGET_ANNOTATION]: 'true',
+    };
+
+    const updateData = {
+      model: CephClusterModel,
+      data: updatedResource,
+    };
+
+    k8sUpdate(updateData)
+      .then(() => {
+        closeModal();
+      })
+      .catch((err) => {
+        setUpdateError(err.message);
+      });


move all this to separate entity... instead of polluting existing component (these changes are temporary as well)...

TimothyAsirJeyasing · 2023-11-17T15:41:05Z

GowthamShanmugam · 2023-11-20T05:32:41Z

packages/ocs/dashboards/persistent-internal/OptimizeModal.tsx

@@ -0,0 +1,109 @@
+import * as React from 'react';


Rename this file as osdMigrationModal.tsx and move this inside the modals folder with some subfolder.

GowthamShanmugam · 2023-11-20T05:33:04Z

packages/ocs/dashboards/persistent-internal/OptimizeModal.tsx

+} from '@patternfly/react-core';
+import { MigrationStatus, getMigrationStatus } from './constants/osd-migration';
+
+const OptimizeModal: React.FC<OptimizeModalProps> = ({ cephData }) => {


Suggested change

const OptimizeModal: React.FC<OptimizeModalProps> = ({ cephData }) => {

const OSDMigrationModal: React.FC<OSDMigrationModalProps> = ({ cephData }) => {

GowthamShanmugam · 2023-11-20T05:35:10Z

packages/ocs/dashboards/persistent-internal/constants/osd-migration.tsx

+  Unknown = '',
+}
+
+export const getMigrationStatus = (cephData) => {


move this inside utils folder under ocs.ts, And rename this function as getOSDMigrationStatus

GowthamShanmugam · 2023-11-20T05:37:50Z

packages/ocs/dashboards/persistent-internal/constants/osd-migration.tsx

+  InProgress = 'In Progress',
+  Pending = 'Pending',
+  Completed = 'Completed',
+  Unknown = '',


Suggested change

InProgress = 'In Progress',

Pending = 'Pending',

Completed = 'Completed',

Unknown = '',

IN_PROGRESS = 'In Progress',

PENDING = 'Pending',

COMPLETED = 'Completed',

UNKNOWN = '',

GowthamShanmugam · 2023-11-20T05:40:25Z

packages/ocs/dashboards/persistent-internal/constants/osd-migration.tsx

+  Unknown = '',
+}
+
+export const getMigrationStatus = (cephData) => {


Suggested change

export const getMigrationStatus = (cephData) => {

export const getMigrationStatus = (ceph: CephClusterKind) => {

pass ceph object directly , dont pass list

GowthamShanmugam · 2023-11-20T05:40:52Z

packages/ocs/dashboards/persistent-internal/constants/osd-migration.tsx

+}
+
+export const getMigrationStatus = (cephData) => {
+  if (cephData && cephData.length > 0) {


Suggested change

if (cephData && cephData.length > 0) {

if (!!ceph) {

GowthamShanmugam · 2023-11-20T05:43:24Z

packages/ocs/dashboards/persistent-internal/constants/osd-migration.tsx

+
+export const getMigrationStatus = (cephData) => {
+  if (cephData && cephData.length > 0) {
+    const ceph = cephData[0];


Suggested change

const ceph = cephData[0];

GowthamShanmugam · 2023-11-20T05:46:06Z

packages/ocs/dashboards/persistent-internal/constants/osd-migration.tsx

+      return MigrationStatus.Completed;
+    }
+
+    return MigrationStatus.Unknown;


Suggested change

return MigrationStatus.Unknown;

GowthamShanmugam · 2023-11-20T05:46:57Z

packages/ocs/dashboards/persistent-internal/constants/osd-migration.tsx

+export const getMigrationStatus = (cephData) => {
+  if (cephData && cephData.length > 0) {
+    const ceph = cephData[0];
+    const bluestoreCount = ceph?.status?.storage?.osd?.storeType?.['bluestore'];


Suggested change

const bluestoreCount = ceph?.status?.storage?.osd?.storeType?.['bluestore'];

const bluestoreCount = ceph?.status?.storage?.osd?.storeType?.[BLUESTORE];

use constant

GowthamShanmugam · 2023-11-20T05:47:26Z

packages/ocs/dashboards/persistent-internal/constants/osd-migration.tsx

+    const ceph = cephData[0];
+    const bluestoreCount = ceph?.status?.storage?.osd?.storeType?.['bluestore'];
+    const bluestoreRdrCount =
+      ceph?.status?.storage?.osd?.storeType?.['bluestore-rdr'];


Suggested change

ceph?.status?.storage?.osd?.storeType?.['bluestore-rdr'];

ceph?.status?.storage?.osd?.storeType?.[BLUESTORE_RDR];

use constant

GowthamShanmugam · 2023-11-20T05:51:03Z

packages/ocs/dashboards/persistent-internal/details-card.tsx


 const DetailsCard: React.FC = () => {
  const { t } = useCustomTranslation();
+  const [cephData, cephLoaded, cephLoadError] = useK8sList<CephClusterKind>(
+    CephClusterModel,
+    CEPH_NS


what is the plan for multi storage cluster, here CEPH_NS is called a constant?

GowthamShanmugam · 2023-11-20T05:51:29Z

packages/ocs/dashboards/persistent-internal/details-card.tsx

@@ -100,6 +112,14 @@ const DetailsCard: React.FC = () => {
          >
            {inTransitEncryptionStatus}
          </DetailItem>
+          <DetailItem
+            key="dr_setup_state"


Suggested change

key="dr_setup_state"

key="osd_migration"

GowthamShanmugam · 2023-11-20T05:51:58Z

packages/ocs/dashboards/persistent-internal/details-card.tsx

+            isLoading={!cephLoaded}
+            error={cephLoadError}
+          >
+            <OptimizeModal cephData={cephData} />


Suggested change

<OptimizeModal cephData={cephData} />

<OptimizeModal cephData={cephData?.[0]} />

GowthamShanmugam · 2023-11-21T11:42:21Z

packages/ocs/dashboards/persistent-internal/details-card.tsx

+
+  const [cephData, cephLoaded, cephLoadError] = useK8sList<CephClusterKind>(
+    CephClusterModel,
+    ocsData?.[0].metadata?.namespace


Suggested change

ocsData?.[0].metadata?.namespace

getNamespace(ocsData?.[0])

GowthamShanmugam · 2023-11-21T11:50:21Z

packages/ocs/modals/osd-migration/osdMigrationModal.tsx

+  const { t } = useCustomTranslation();
+  const dRSetupStatus: string = getOSDMigrationStatus(cephData);
+  const [isOpen, setOpen] = React.useState(false);
+  const [errorMessage, setErrorMessage] = React.useState<string | null>(null);


Suggested change

const [errorMessage, setErrorMessage] = React.useState<string | null>(null);

const [errorMessage, setErrorMessage] = React.useState<string>('');

GowthamShanmugam · 2023-11-21T12:36:24Z

packages/ocs/modals/osd-migration/osdMigrationModal.tsx

+  cephData,
+}) => {
+  const { t } = useCustomTranslation();
+  const dRSetupStatus: string = getOSDMigrationStatus(cephData);


this line will render again and again, use useMemo to prevent

GowthamShanmugam · 2023-11-21T12:37:04Z

packages/ocs/modals/osd-migration/osdMigrationModal.tsx

+
+  const closeModal = () => {
+    setOpen(false);
+    setErrorMessage(null);


Suggested change

setErrorMessage(null);

setErrorMessage('');

GowthamShanmugam · 2023-11-21T12:38:04Z

packages/ocs/modals/osd-migration/osdMigrationModal.tsx

+  };
+
+  return (
+    <div>


Suggested change

<div>

<>

GowthamShanmugam · 2023-11-21T12:42:25Z

packages/ocs/modals/osd-migration/osdMigrationModal.tsx

+          onClose={closeModal}
+          actions={[
+            <Button key="close" variant="secondary" onClick={closeModal}>
+              Close


Suggested change

Close

t('Close')

GowthamShanmugam · 2023-11-21T12:42:36Z

packages/ocs/modals/osd-migration/osdMigrationModal.tsx

+              Close
+            </Button>,
+            <Button key="optimize" variant="primary" onClick={handleOptimize}>
+              Optimize


Suggested change

Optimize

t('Optimize')

GowthamShanmugam · 2023-11-21T12:44:59Z

packages/ocs/modals/osd-migration/osdMigrationModal.tsx

+  ModalBoxHeader,
+  ModalBoxBody,


Suggested change

ModalBoxHeader,

ModalBoxBody,

GowthamShanmugam · 2023-11-21T12:46:58Z

packages/ocs/modals/osd-migration/osdMigrationModal.tsx

+          <p>
+            {t(
+              'Configure the cluster for a Regional-DR setup by migrating OSDs. Migration may take sometime depending on several factors. To learn more about OSDs migration best practices and its consequences refer to the documentation.'
+            )}
+          </p>
+          {errorMessage && (
+            <ModalBoxHeader>
+              <Title headingLevel="h2" size="lg">
+                Error
+              </Title>
+            </ModalBoxHeader>
+          )}
+          <ModalBoxBody>{errorMessage}</ModalBoxBody>


Suggested change

<p>

{t(

'Configure the cluster for a Regional-DR setup by migrating OSDs. Migration may take sometime depending on several factors. To learn more about OSDs migration best practices and its consequences refer to the documentation.'

)}

</p>

{errorMessage && (

<ModalBoxHeader>

<Title headingLevel="h2" size="lg">

Error

</Title>

</ModalBoxHeader>

)}

<ModalBoxBody>{errorMessage}</ModalBoxBody>

use the title & description prop of the modal to pass this text.

GowthamShanmugam · 2023-11-21T12:47:50Z

packages/ocs/modals/osd-migration/osdMigrationModal.tsx

+          <p>
+            {t(
+              'Configure the cluster for a Regional-DR setup by migrating OSDs. Migration may take sometime depending on several factors. To learn more about OSDs migration best practices and its consequences refer to the documentation.'
+            )}
+          </p>
+          {errorMessage && (
+            <ModalBoxHeader>
+              <Title headingLevel="h2" size="lg">
+                Error
+              </Title>
+            </ModalBoxHeader>
+          )}
+          <ModalBoxBody>{errorMessage}</ModalBoxBody>


the modal body should be inside <ModalBody> tag

Also are simply displaying error messages as a text inside modal body ?

GowthamShanmugam · 2023-11-21T12:49:36Z

packages/ocs/utils/osd-migration.ts

+export const IN_PROGRESS = 'In Progress';
+export const PENDING = 'Pending';
+export const COMPLETED = 'Completed';
+export const FAILED = 'Failed';


I think you misunderstood to keep it as constants,, Convert this status as enum and move it to the constant directory. under dataProtection.ts

GowthamShanmugam · 2023-11-21T12:49:50Z

packages/ocs/utils/osd-migration.ts

+export const BLUESTORE_RDR = 'bluestore-rdr';
+export const BLUESTORE = 'bluestore';


move this to a constant file dataProtection.ts

GowthamShanmugam · 2023-11-21T12:55:21Z

packages/ocs/dashboards/persistent-internal/OptimizeModal.spec.tsx

@@ -0,0 +1,71 @@
+import React from 'react';


Rename this file as osdMigrationModal.spec.tsx and keep it along with original file. Move this to same directory of osdMigrationModal.tsx

SanjalKatiyar · 2023-11-28T05:05:31Z

packages/ocs/utils/osd-migration.ts

+  return ceph.status?.storage?.osd?.storeType?.[BLUESTORE] || 0;
+};
+
+const getBluestoreRdrCount = (ceph: CephClusterKind): number => {
+  return ceph.status?.storage?.osd?.storeType?.[BLUESTORE_RDR] || 0;


create a separate function under utils which returns ceph.status?.storage?.osd?.storeType, and use that every where needed... this will be used in another files as well related to this epic...

eg:

const getBluestoreCount = (ceph: CephClusterKind): number => { return getCephStoreType(ceph)?.[BLUESTORE] || 0; };

SanjalKatiyar · 2023-11-28T12:09:43Z

/approve

SanjalKatiyar · 2023-11-28T12:10:01Z

/approve cancel

SanjalKatiyar · 2023-11-28T12:10:52Z

plz update PR and commit title, this PR is not for "enable DR support"

TimothyAsirJeyasing · 2023-11-28T14:36:28Z

/retitle Provide option to optimise cluster for Regional-DR

SanjalKatiyar · 2023-11-28T17:17:23Z

/retitle Provide option to optimise cluster for Regional-DR

as suggested above, plz update commit title as well (not just PR title)...

GowthamShanmugam · 2023-11-29T07:58:55Z

/approve cancel

SanjalKatiyar · 2023-11-29T08:06:23Z

LGTM

SanjalKatiyar · 2023-11-29T16:50:18Z

packages/ocs/modals/osd-migration/osdMigrationDetails.tsx

+type OSDMigrationDetailsProps = {
+  cephData: CephClusterKind;
+  ocsData: StorageClusterKind;
+};


rename file to osd-migration-details.tsx

SanjalKatiyar · 2023-11-29T16:50:42Z

packages/ocs/modals/osd-migration/osdMigrationDetails.spec.tsx

+      ).toBeInTheDocument();
+    });
+  });
+});


rename file to osd-migration-details...

SanjalKatiyar · 2023-11-29T16:50:59Z

packages/odf/constants/dataProtection.ts

+}
+
+export const BLUESTORE_RDR = 'bluestore-rdr';
+export const BLUESTORE = 'bluestore';


plz rename this file to data-protection...

Signed-off-by: Timothy Asir Jeyasingh <[email protected]>

SanjalKatiyar · 2023-12-03T07:55:30Z

/approve
/lgtm

openshift-ci · 2023-12-03T07:55:39Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: SanjalKatiyar, TimothyAsirJeyasing

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [SanjalKatiyar]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

bipuladh force-pushed the dr-brownfield-odf-cluster-overview branch from bcf9d6c to a9a2a9c Compare November 7, 2023 08:50

GowthamShanmugam reviewed Nov 7, 2023

View reviewed changes

SanjalKatiyar reviewed Nov 17, 2023

View reviewed changes

TimothyAsirJeyasing force-pushed the dr-brownfield-odf-cluster-overview branch from a9a2a9c to 4be4ca7 Compare November 17, 2023 15:32

GowthamShanmugam reviewed Nov 20, 2023

View reviewed changes

TimothyAsirJeyasing force-pushed the dr-brownfield-odf-cluster-overview branch 3 times, most recently from 1034dbc to 72ce5b7 Compare November 21, 2023 12:15

GowthamShanmugam reviewed Nov 21, 2023

View reviewed changes

openshift-ci bot removed the lgtm label Nov 27, 2023

SanjalKatiyar reviewed Nov 28, 2023

View reviewed changes

TimothyAsirJeyasing force-pushed the dr-brownfield-odf-cluster-overview branch from 6494c93 to 464be9d Compare November 28, 2023 05:48

openshift-ci bot added the approved label Nov 28, 2023

openshift-ci bot removed the approved label Nov 28, 2023

openshift-ci bot changed the title ~~Provide option to enable DR support~~ Provide option to optimise cluster for Regional-DR Nov 28, 2023

TimothyAsirJeyasing force-pushed the dr-brownfield-odf-cluster-overview branch from 464be9d to 19d72b1 Compare November 29, 2023 07:08

GowthamShanmugam approved these changes Nov 29, 2023

View reviewed changes

openshift-ci bot added the lgtm label Nov 29, 2023

SanjalKatiyar reviewed Nov 29, 2023

View reviewed changes

TimothyAsirJeyasing force-pushed the dr-brownfield-odf-cluster-overview branch from 19d72b1 to 3ad33a6 Compare November 30, 2023 04:56

openshift-ci bot removed the lgtm label Nov 30, 2023

TimothyAsirJeyasing force-pushed the dr-brownfield-odf-cluster-overview branch from 3ad33a6 to 1422907 Compare November 30, 2023 17:07

Provide option to optimise cluster for Regional-DR

74e1979

Signed-off-by: Timothy Asir Jeyasingh <[email protected]>

TimothyAsirJeyasing force-pushed the dr-brownfield-odf-cluster-overview branch from 1422907 to 74e1979 Compare December 1, 2023 14:44

openshift-ci bot assigned SanjalKatiyar Dec 3, 2023

openshift-ci bot added the lgtm label Dec 3, 2023

openshift-ci bot added the approved label Dec 3, 2023

openshift-merge-bot bot merged commit 046ef75 into red-hat-storage:master Dec 3, 2023
3 checks passed

		export const DISASTER_RECOVERY_TARGET_ANNOTATION =
		'ocs.openshift.io/clusterIsDisasterRecoveryTarget';

	const OptimizeModal: React.FC<OptimizeModalProps> = ({ cephData }) => {
	const OSDMigrationModal: React.FC<OSDMigrationModalProps> = ({ cephData }) => {

	export const getMigrationStatus = (cephData) => {
	export const getMigrationStatus = (ceph: CephClusterKind) => {

	const bluestoreCount = ceph?.status?.storage?.osd?.storeType?.['bluestore'];
	const bluestoreCount = ceph?.status?.storage?.osd?.storeType?.[BLUESTORE];

	ceph?.status?.storage?.osd?.storeType?.['bluestore-rdr'];
	ceph?.status?.storage?.osd?.storeType?.[BLUESTORE_RDR];

	<OptimizeModal cephData={cephData} />
	<OptimizeModal cephData={cephData?.[0]} />

	const [errorMessage, setErrorMessage] = React.useState<string \| null>(null);
	const [errorMessage, setErrorMessage] = React.useState<string>('');

		export const BLUESTORE_RDR = 'bluestore-rdr';
		export const BLUESTORE = 'bluestore';

Provide option to optimise cluster for Regional-DR #1095

Provide option to optimise cluster for Regional-DR #1095

Conversation

TimothyAsirJeyasing commented Nov 7, 2023

TimothyAsirJeyasing commented Nov 7, 2023

bipuladh commented Nov 7, 2023

TimothyAsirJeyasing commented Nov 7, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

SanjalKatiyar commented Nov 17, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

TimothyAsirJeyasing commented Nov 17, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

GowthamShanmugam Nov 20, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

GowthamShanmugam Nov 20, 2023 • edited Loading

Choose a reason for hiding this comment

GowthamShanmugam Nov 20, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

GowthamShanmugam Nov 21, 2023 • edited Loading

Choose a reason for hiding this comment

GowthamShanmugam Nov 21, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

SanjalKatiyar commented Nov 28, 2023

SanjalKatiyar commented Nov 28, 2023

SanjalKatiyar commented Nov 28, 2023

TimothyAsirJeyasing commented Nov 28, 2023

SanjalKatiyar commented Nov 28, 2023

GowthamShanmugam commented Nov 29, 2023

SanjalKatiyar commented Nov 29, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

SanjalKatiyar commented Dec 3, 2023

openshift-ci bot commented Dec 3, 2023

TimothyAsirJeyasing commented Nov 7, 2023 •

edited

Loading

GowthamShanmugam Nov 20, 2023 •

edited

Loading

GowthamShanmugam Nov 20, 2023 •

edited

Loading

GowthamShanmugam Nov 20, 2023 •

edited

Loading

GowthamShanmugam Nov 21, 2023 •

edited

Loading

GowthamShanmugam Nov 21, 2023 •

edited

Loading