Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Syncing latest changes from master for noobaa-core #18

Open
wants to merge 241 commits into
base: release-4.19
Choose a base branch
from

Conversation

df-build-team
Copy link

PR containing the latest commits from master branch

naveenpaul1 and others added 30 commits October 9, 2024 09:40
NSFS | Object Version when trying to delete, logs a WARN message
- Bumping deps to avoid CVE

Signed-off-by: liranmauda <[email protected]>
Signed-off-by: shirady <[email protected]>
fixed get lifecycle conf to support all possible fields
NC | NSFS | Versioning | Add Concurrency Tests - Suspended
NC | NSFS | Versioning | Add Tests With Nested Keys (more than 1 level)
NSFS | versioning | use linkat in gpfs safe_link to not override existing versions
Signed-off-by: Nimrod Becker <[email protected]>
Signed-off-by: nimrod-becker <[email protected]>
Update stale actions with exempt rules
1. Update IAM API Users, Access Keys and additional changes in accountspace_fs:
 - Move the config creation from the function _copy_data_from_requesting_account_to_account_config to the create_user.
 - Fix the ARN account ID for root accounts that were operated by the roots accounts manager (before we copied the requesting_account._id which was true only for root accounts on IAM users).
 - Fix _check_root_account as it has a redundant line that was not relevant (it was there when we thought of additional case, but we never get to it).
 - Add 2 helper functions: _get_account_owner_id_for_arn, _get_owner_account_argument.
 - Improve performance in the function _check_if_root_account_does_not_have_IAM_users_before_deletion after we have the new structure.
2. Update the ConfigFS module to support the new structure and operate on users configs.
3. Update docs:
 - With the config dire restructure (identities/, accounts_by_name/, users/directories).
 - IAM docs - regarding the naming scope (that we have with the new structure) and about the new structure with users/ directory.
4. Update the IAM API tests:
 - Mainly reading the config file in the new structure.
 - Add account validation to accounts created hardcoded (to avoid schema changes without them updated).
 - Refactor `it` names to multiple lines.
5. In rest_s3 change the 'is_owner` part (the gap mentioned in NC | Bucket Owner Removal noobaa#8289), where it checks the name, to make sure the account is not a user with the same name.

Signed-off-by: shirady <[email protected]>
…cture-users-dir

NC | NSFS | Config Dir Restructure - Add `users/` Dir
Signed-off-by: nadav mizrahi <[email protected]>
NSFS | NC | GPFS | modify versioning tests to work with GPFS
* Fix the store deletion ownership check
* Handle cases in which a pool has no owner
* Change error type

Signed-off-by: Ben <[email protected]>
Signed-off-by: Danny Zaken <[email protected]>
shirady and others added 29 commits January 16, 2025 11:46
NC | NSFS | Fix Issue DFBUGS-1307 | Bucket Policy With Principal as ID
… to both Containerized and NC environments

Signed-off-by: Romy <[email protected]>
…ral-terms

Upgrade utils | change variables, errors and log prints to be general to both Containerized and NC environments
…egration-tests

NC | Online Upgrade | Integration tests | Add CLI and S3 integration tests
…umentation

NC | Online Upgrade | Documentation
- Correct minor problems in the AWS API compatibility doc

Signed-off-by: Ben <[email protected]>
…all-test-and-action

NC | RPM build and install github action
…ilds

Fix python version to 3.9 to fix builds on RHEL 8
…ion Move module and Allow IAM User to Create Bucket)

1. IAM Integration Tests: add the file test_nc_iam_basic_integration.js and make the needed changes in the fiiles nc_coretest.js (add the IAM port), nc_index (add the new test in the CI) and test_utils.js (add the IAM client - like we have S3 client) - the IAM integration tests the APIs of IAM that we support today.
2. Username Validation Move the Module: we have 2 flows noobaa-cli and API (S3, IAM), and don't want to import modules between the flows and only from an above level. Therefore, I moved the function validate_username from the iam_utils to validation_utils, since it used other functions I also had to move them and move the testing file.
3. Allow IAM Users to Create Bucket - we temporarily didn't allow IAM users to create buckets.

Signed-off-by: shirady <[email protected]>
NC | NSFS | IAM | Tech Debts (IAM Integration Tests, Username Validation Move module and Allow IAM User to Create Bucket)
Signed-off-by: shirady <[email protected]>
remove librdkafka/examples directory from our image - in order to decrease its size
NSFS | add option to unset supplemental groups using noobaa cli
Changing get bucket encryption defaults
Update ceph_s3_tests_pending_list_status.md
Copy link

openshift-ci bot commented Jan 24, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: df-build-team

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.