Batch subcommand filter #199
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yazug
force-pushed
the
batch_subcommand_filter
branch
from
ace7d8b to
64c760f
Compare
2 tasks
- helper method to implement general filter query pattern
- add support for release/product difference in nesting filter
parameters
- support for paginated requests
- basic unittest for filter helper based on usage
Works with the following
et.get_filter('/api/v1/releases', 'filter', is_active="true",
enabled="true", name='OpenStack 14.0.z for RHEL 7')
works with the following
et.get_filter('/errata', 'errata_filter[filter_params]',
show_type_RHBA=1, show_type_RHEA=1, show_type_RHSA=1,
show_state_NEW_FILES=1, show_state_QE=1,
show_state_REL_PREP=1,show_state_PUSH_READY=1,
open_closed_option='exclude', release=856)
Note: errata endpoint releases and products have to be special
handled to include extra [] and multiple entries if you want them
Related: red-hat-storage#132
errata-tool batch get <id or name of batch> errata-tool batch list based on ErrataConnector::get_filter method prints the returned json blob also has --summary to show some more details
BatchSearch encapsulates the searching functionality and exposes 2 methods for querying ET Batch is an object for a specific batch from ET Batch object has properties exposed for some of the relevant data extracted it also exposes the raw data returned for the batch as well as accessors methods to work with the raw returned data. Batch can be constructed from data already partially broken down from BatchSearch or to directly query ET and parse the data the Batch::errata property will lazy load the Errata objects. If you are just wanting to know which advisories you can look at Batch::errata_ids property which will provide you with the list of advisories ids that in the batch.
yazug
force-pushed
the
batch_subcommand_filter
branch
from
64c760f to
fe0a317
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
simple batch subcommand using get_filter implementation
get_filter abstracts several filter request patterns for paginated and
non-paginated get interactions with errata
Exposes the top level api calls for searching and does not do any additional processing at the moment
errata-tool batch list
errata-tool batch get <batch_id_or_name>