Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Apple automation for bucket list causing abnormal client IO #664

Merged
merged 1 commit into from
Jan 27, 2025
Merged

Apple automation for bucket list causing abnormal client IO #664

merged 1 commit into from
Jan 27, 2025
+136 −0

Conversation

viduship
Copy link
Contributor

@viduship viduship commented Jan 18, 2025 •
edited
Loading

@viduship viduship force-pushed the vim-restore-s3-object branch from 3c471de to c968567 Compare January 18, 2025 18:58
@viduship viduship requested a review from a team as a code owner January 18, 2025 18:58
@viduship viduship closed this Jan 20, 2025
@viduship viduship force-pushed the vim-restore-s3-object branch from c968567 to 710849a Compare January 20, 2025 07:09
@viduship viduship reopened this Jan 20, 2025
@viduship viduship force-pushed the vim-restore-s3-object branch from 7175efc to 36edd21 Compare January 20, 2025 08:58
@viduship viduship requested a review from a team January 20, 2025 08:59
ckulal
ckulal reviewed Jan 20, 2025
View reviewed changes
Copy link
Contributor

@ckulal ckulal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than existing comment regarding inclusion of polarion, script file in config.
remaining changes looks good.

@viduship viduship closed this Jan 20, 2025
@viduship viduship force-pushed the vim-restore-s3-object branch from 36edd21 to a033094 Compare January 20, 2025 10:49
@viduship viduship reopened this Jan 20, 2025
@viduship viduship force-pushed the vim-restore-s3-object branch 3 times, most recently from 6f410d4 to 3bca6b2 Compare January 21, 2025 05:13
@viduship viduship added RGW RGW close-loop-automation close-loop-automation customer BZ automated as part of close-loop hotfix automation done during the testing of any hotfix tier-3 tier-3 automation labels Jan 21, 2025
hmaheswa
hmaheswa previously approved these changes Jan 21, 2025
View reviewed changes
@openshift-ci openshift-ci bot added the lgtm Looks good to me label Jan 21, 2025
@viduship viduship added the DNM label Jan 21, 2025
@openshift-ci openshift-ci bot removed the lgtm Looks good to me label Jan 25, 2025
@viduship viduship closed this Jan 26, 2025
@viduship viduship force-pushed the vim-restore-s3-object branch from 7726e15 to a033094 Compare January 26, 2025 09:15
@viduship viduship reopened this Jan 27, 2025
@viduship viduship force-pushed the vim-restore-s3-object branch from 150e566 to 72923fa Compare January 27, 2025 02:14
@viduship viduship removed the DNM label Jan 27, 2025
@viduship viduship force-pushed the vim-restore-s3-object branch 2 times, most recently from ba91592 to 68bc944 Compare January 27, 2025 02:28
@viduship
Copy link
Contributor Author

viduship commented Jan 27, 2025 •
edited
Loading

@psathyan please review the PR with requested changes addressed.
passed logs with parallel execution takes 56mins : http://magna002.ceph.redhat.com/cephci-jenkins/vidushi-runs/logs_test_bucket_listing_fake_mp_4

@psathyan Thanks.
new passed log with max_workers for threads not set is
(http://magna002.ceph.redhat.com/cephci-jenkins/vidushi-runs/logs_test_bucket_listing_fake_mp_5)

The execution time is ~57mins. Please review

@viduship viduship force-pushed the vim-restore-s3-object branch from 68bc944 to 256d4d0 Compare January 27, 2025 05:45
psathyan
psathyan reviewed Jan 27, 2025
View reviewed changes
Copy link
Contributor

@psathyan psathyan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Looks good to me label Jan 27, 2025
@TejasC88
Copy link
Contributor

LGTM

@viduship viduship added the approved Approving PR. label Jan 27, 2025
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jan 27, 2025

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: psathyan, viduship

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@viduship viduship removed the approved Approving PR. label Jan 27, 2025
@openshift-merge-bot openshift-merge-bot bot merged commit 9d9c353 into red-hat-storage:master Jan 27, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anrao19 anrao19 anrao19 left review comments

@ckulal ckulal ckulal left review comments

@psathyan psathyan psathyan approved these changes

@hmaheswa hmaheswa hmaheswa left review comments

@mkasturi18 mkasturi18 Awaiting requested review from mkasturi18 mkasturi18 is a code owner

@TejasC88 TejasC88 Awaiting requested review from TejasC88 TejasC88 is a code owner

Assignees

@psathyan psathyan

@hmaheswa hmaheswa

Labels
close-loop-automation close-loop-automation customer BZ automated as part of close-loop hotfix automation done during the testing of any hotfix lgtm Looks good to me RGW RGW tier-3 tier-3 automation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@viduship @TejasC88 @psathyan @ckulal @anrao19 @hmaheswa