Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Syncing latest changes from upstream devel for ceph-csi #453

Merged
merged 3 commits into from
Jan 20, 2025

Conversation

df-build-team
Copy link

PR containing the latest commits from upstream devel branch

nixpanic and others added 3 commits January 17, 2025 08:47
The Kubernetes CSI community has released an updated external-resizer
sidecar that fixes some issues and adds a few improvements.

See: https://github.com/kubernetes-csi/external-resizer/releases/tag/v1.13.1
Signed-off-by: Niels de Vos <[email protected]>
The `offlineExpansion` option enables tests that try to expand volumes
in the CSI Controller (provisioner). This is only possible for BlockMode
volumes, as a FileMode volume needs run a filesystem resizer while the
volume is attached.

Signed-off-by: Niels de Vos <[email protected]>
Problem: When the encryptionType is not specified in the StorageClass,
the default type (block) is used and stored in OMAP. However, during
OMAP regeneration in a secondary cluster, the default type is incorrectly
set to none. This discrepancy leads to errors during PVC cloning,
with the message: `cannot create encrypted volume from unencrypted volume.`

Solution: Update the default encryption type to consistently use
block instead of none.

Signed-off-by: Praveen M <[email protected]>
@df-build-team df-build-team requested a review from a team January 18, 2025 08:03
@nixpanic
Copy link
Member

/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm Code looks good label Jan 20, 2025
Copy link

openshift-ci bot commented Jan 20, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: df-build-team, nixpanic

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Its a good idea label Jan 20, 2025
@openshift-merge-bot openshift-merge-bot bot merged commit 79a3226 into devel Jan 20, 2025
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Its a good idea lgtm Code looks good
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants