Impose pre-determined routes instead of announcing them in the manife…

…st (#91) * Impose pre-determined routes rather than announcing them in the manifest, for #84 * Remove mention of iframe * Remove the mention of form elements. Co-authored-by: Fabian Steeg <[email protected]> Co-authored-by: Fabian Steeg <[email protected]>
reconciliation-api · Nov 10, 2022 · e6e6132 · e6e6132
1 parent 6e65e1a
commit e6e6132
Show file tree

Hide file tree

Showing 13 changed files with 97 additions and 247 deletions.
diff --git a/latest/examples/flyout-response/valid/example.json b/latest/examples/flyout-response/valid/example.json
diff --git a/latest/examples/manifest/valid/findthatcharity.json b/latest/examples/manifest/valid/findthatcharity.json
@@ -7,7 +7,6 @@
     "url": "https://findthatcharity.uk/charity/{id}"
   },
   "preview": {
-    "url": "https://findthatcharity.uk/preview/charity/{id}",
     "width": 430,
     "height": 300
   },

diff --git a/latest/examples/manifest/valid/geocollider-sinatra.json b/latest/examples/manifest/valid/geocollider-sinatra.json
@@ -7,10 +7,9 @@
     "url": "{+id}"
   },
   "suggest": {
-    "property": {
-      "service_url": "https://geocollider-sinatra.herokuapp.com",
-      "service_path": "/suggest"
-    }
+    "entity": false,
+    "property": true,
+    "type": false
   },
   "defaultTypes": [
     {

diff --git a/latest/examples/manifest/valid/getty.json b/latest/examples/manifest/valid/getty.json
@@ -23,15 +23,13 @@
   "batchSize": 50,
   "preview": {
     "height": 200,
-    "url": "https://services.getty.edu/vocab/reconcile/preview{?id}",
     "width": 350
   },
   "schemaSpace": "http://vocab.getty.edu/doc/#The_Getty_Vocabularies_and_LOD",
   "suggest": {
-    "property": {
-      "service_path": "/suggest/property",
-      "service_url": "https://services.getty.edu/vocab/reconcile"
-    }
+    "entity": false,
+    "property": true,
+    "type": false
   },
   "view": {
     "url": "http://vocab.getty.edu/page/{id}"

diff --git a/latest/examples/manifest/valid/kerameikos.json b/latest/examples/manifest/valid/kerameikos.json
@@ -61,15 +61,12 @@
     }
   ],
   "preview": {
-    "url": "http://kerameikos.org/apis/reconcile/preview{?id}",
     "height": 90,
     "width": 320
   },
   "suggest": {
-    "entity": {
-      "service_url": "http://kerameikos.org/apis/reconcile",
-      "service_path": "/suggest/entity",
-      "flyout_service_path": "/flyout{?id}"
-    }
+    "entity": true,
+    "property": false,
+    "type": false
   }
 }
diff --git a/latest/examples/manifest/valid/kew.json b/latest/examples/manifest/valid/kew.json
@@ -12,24 +12,9 @@
     "height": 400
   },
   "suggest": {
-    "type": {
-      "service_url": "http://data1.kew.org",
-      "service_path": "/reconciliation/reconcile/IpniName/suggestType",
-      "flyout_service_url": "http://data1.kew.org",
-      "flyout_service_path": "/reconciliation/reconcile/IpniName/flyoutType/${id}"
-    },
-    "property": {
-      "service_url": "http://data1.kew.org",
-      "service_path": "/reconciliation/reconcile/IpniName/suggestProperty",
-      "flyout_service_url": "http://data1.kew.org",
-      "flyout_service_path": "/reconciliation/reconcile/IpniName/flyoutProperty/${id}"
-    },
-    "entity": {
-      "service_url": "http://data1.kew.org",
-      "service_path": "/reconciliation/reconcile/IpniName",
-      "flyout_service_url": "http://data1.kew.org",
-      "flyout_service_path": "/reconciliation/reconcile/IpniName/flyout/${id}"
-    }
+    "type": true,
+    "property": true,
+    "entity": true
   },
   "defaultTypes": [
     {

diff --git a/latest/examples/manifest/valid/lobid-gnd.json b/latest/examples/manifest/valid/lobid-gnd.json
@@ -48,8 +48,7 @@
   },
   "preview": {
     "height": 100,
-    "width": 320,
-    "url": "https://lobid.org/gnd/{{id}}.preview"
+    "width": 320
   },
   "extend": {
     "property_settings": [
@@ -78,26 +77,11 @@
         ]
       }
     ],
-    "propose_properties": {
-      "service_url": "https://lobid.org",
-      "service_path": "/gnd/reconcile/properties"
-    }
+    "propose_properties": true
   },
   "suggest": {
-    "property": {
-      "service_url": "https://lobid.org/gnd/reconcile",
-      "service_path": "/suggest/property",
-      "flyout_service_path": "/flyout/property?id=${id}"
-    },
-    "entity": {
-      "service_url": "https://lobid.org/gnd/reconcile",
-      "service_path": "/suggest/entity",
-      "flyout_service_path": "/flyout/entity?id=${id}"
-    },
-    "type": {
-      "service_url": "https://lobid.org/gnd/reconcile",
-      "service_path": "/suggest/type",
-      "flyout_service_path": "/flyout/type?id=${id}"
-    }
+    "property": true,
+    "entity": true,
+    "type": true
   }
 }
diff --git a/latest/examples/manifest/valid/nomisma.json b/latest/examples/manifest/valid/nomisma.json
@@ -101,15 +101,12 @@
     }
   ],
   "preview": {
-    "url": "http://nomisma.org/apis/reconcile/preview?id={{id}}",
     "height": 90,
     "width": 320
   },
   "suggest": {
-    "entity": {
-      "service_url": "http://nomisma.org/apis/reconcile",
-      "service_path": "/suggest/entity",
-      "flyout_service_path": "/flyout?id=${id}"
-    }
+    "entity": true,
+    "property": false,
+    "type": false
   }
 }
diff --git a/latest/examples/manifest/valid/occrp.json b/latest/examples/manifest/valid/occrp.json
@@ -7,23 +7,13 @@
     "url": "https://aleph.occrp.org/entities/{{id}}"
   },
   "preview": {
-    "url": "https://aleph.occrp.org/entities/{{id}}",
     "width": 800,
     "height": 400
   },
   "suggest": {
-    "entity": {
-      "service_url": "https://aleph.occrp.org",
-      "service_path": "/api/freebase/suggest?api_key=eyJ0eXAiOiJKV1QiLCJhbGciOiJIUzI1NiJ9.eyJ1IjpudWxsLCJleHAiOjE1NzEzMTQ5MzQsInIiOlsxXSwiYSI6ZmFsc2UsInMiOiIvYXBpL2ZyZWViYXNlL3N1Z2dlc3QifQ.LullhAvG1hGfMnaVpPjOwIUnt-BOpO8_xHxSoGieMeQ"
-    },
-    "type": {
-      "service_url": "https://aleph.occrp.org",
-      "service_path": "/api/freebase/type"
-    },
-    "property": {
-      "service_url": "https://aleph.occrp.org",
-      "service_path": "/api/freebase/property"
-    }
+    "entity": true,
+    "type": true,
+    "property": true
   },
   "defaultTypes": [
     {

diff --git a/latest/examples/manifest/valid/wikidata.json b/latest/examples/manifest/valid/wikidata.json
@@ -2,7 +2,6 @@
   "versions": ["0.1", "0.2"],
   "name": "Wikidata (en)",
   "preview": {
-    "url": "https://tools.wmflabs.org/openrefine-wikidata/en/preview?id={{id}}",
     "width": 400,
     "height": 100
   },
@@ -69,10 +68,7 @@
         "default": false
       }
     ],
-    "propose_properties": {
-      "service_url": "https://tools.wmflabs.org/openrefine-wikidata",
-      "service_path": "/en/propose_properties"
-    }
+    "propose_properties": true
   },
   "defaultTypes": [
     {
@@ -84,21 +80,9 @@
     "url": "https://www.wikidata.org/wiki/{{id}}"
   },
   "suggest": {
-    "type": {
-      "service_url": "https://tools.wmflabs.org/openrefine-wikidata",
-      "service_path": "/en/suggest/type",
-      "flyout_service_path": "/en/flyout/type?id=${id}"
-    },
-    "entity": {
-      "service_url": "https://tools.wmflabs.org/openrefine-wikidata",
-      "service_path": "/en/suggest/entity",
-      "flyout_service_path": "/en/flyout/entity?id=${id}"
-    },
-    "property": {
-      "service_url": "https://tools.wmflabs.org/openrefine-wikidata",
-      "service_path": "/en/suggest/property",
-      "flyout_service_path": "/en/flyout/property?id=${id}"
-    }
+    "type": true,
+    "entity": true,
+    "property": true
   },
   "identifierSpace": "http://www.wikidata.org/entity/"
 }
diff --git a/latest/examples/suggest-metadata/valid/example.json b/latest/examples/suggest-metadata/valid/example.json