Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Season index to search Subs #1093

Closed
wants to merge 2 commits into from

Conversation

KingLucius
Copy link
Contributor

If Extenstion is using the SeasonData and doesn't provide both (season & displaySeason) as displaySeason is nullable.

if (seasonData != null) seasonData.displaySeason else i.season,


using seasonIndex assures subtitles search uses the right season number in all cases.

@fire-light42
Copy link
Collaborator

fire-light42 commented May 18, 2024

No, this is wrong as seasonIndex is a unique value, where as seasonData.displaySeason is the "real" season number. This means for example that if we have duplicate seasons the seasonIndex wont be correct. seasonIndex is only used internally as it is unique

@KingLucius
Copy link
Contributor Author

No, this is wrong as seasonIndex is a unique value, where as seasonData.displaySeason is the "real" season number. This means for example that if we have duplicate seasons the seasonIndex wont be correct. seasonIndex is only used internally as it is unique

OK I will solved another way
Thanks

@KingLucius KingLucius closed this May 18, 2024
@KingLucius KingLucius deleted the seasonIndex branch August 23, 2024 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants