Use Season index to search Subs #1093
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
No, this is wrong as seasonIndex is a unique value, where as seasonData.displaySeason is the "real" season number. This means for example that if we have duplicate seasons the seasonIndex wont be correct. seasonIndex is only used internally as it is unique |
OK I will solved another way |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If Extenstion is using the SeasonData and doesn't provide both (season & displaySeason) as displaySeason is nullable.
cloudstream/app/src/main/java/com/lagradost/cloudstream3/ui/result/ResultViewModel2.kt
Line 2319 in ee4d1de
cloudstream/app/src/main/java/com/lagradost/cloudstream3/metaproviders/TraktProvider.kt
Line 172 in ee4d1de
using seasonIndex assures subtitles search uses the right season number in all cases.