Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add explicit support for 'mini.nvim' #57

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

echasnovski
Copy link

@echasnovski echasnovski commented Jul 7, 2022

Hi! I would like to add explicit support for mini.nvim.

Basic choices are taken from either highlight groups to which 'mini.nvim' makes default links or from analogous plugins.

Differences from default linked groups:

  • 'mini.indentscope' is based on 'indent-blankline'.
  • 'mini.jump2d' takes color from "SpellRare" to be consistent with 'mini.jump'. Using nocombine = true to be consistent (not have italic labels on italic text).
  • 'mini.starter' is based on 'dashboard.lua', 'whichkey.lua', 'telescope.lua', and personal choices:
    • MiniStarterSection is chosen to be visible (as from "Special" highlight group).
    • MiniStarterItemBullet is as border.
    • MiniStarterItemPrefix and MiniStarterQuery are based on "warning" and "info" diagnostic colors to be opposite of each other.
  • 'mini.statusline' is based on 'lualine/themes/kanagawa.lua' and personal choices:
    • All MiniStatuslineMode* have bold text as this seems to be used in screenshot.
    • MiniStatuslineDevinfo and MiniStatuslineFileinfo are "slightly different text".
    • MiniStatuslineModeOther is chosen to be different from others.
  • 'mini.tabline' is based on explicit 'TabLine*' groups:
    • MiniTablineCurrent has bold font to be visually distinctive.
    • MiniTablineVisible has slightly darker foreground than MiniTablineCurrent.
    • MiniTablineTabpagesection is chosen from Search.
    • MiniTablineModified* groups have inverted fg and bg of their counterparts.
  • 'mini.test' has red for fail and green for pass. Red and green chosen to be visible inside floating window.
  • 'mini.trailspace' has group with red background to draw attention.

Before:

kanagawa_before.mp4

After:

kanagawa_after.mp4

Copy link
Owner

@rebelot rebelot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please do not use color names directly, instead use their alias defined in themes. This will be safer once other themes will become available.

@echasnovski
Copy link
Author

please do not use color names directly, instead use their alias defined in themes. This will be safer once other themes will become available.

I replaced "red" and "green" colors with git.removed and git.added.

The only other places with direct color names are mode highlights for 'mini.statusline'. These are verbatim taken from 'lualine/themes/kanagawa.lua'. What do you prefer to do here? Replace with some theme alias (like crystalBlue with fn)? There are duplicates there, what should be done then?

@rebelot
Copy link
Owner

rebelot commented Jul 14, 2022

What do you prefer to do here? Replace with some theme alias (like crystalBlue with fn)? There are duplicates there, what should be done then?

That should be optimal, yes. I do not use lualine and I missed that.

@echasnovski
Copy link
Author

Replaced with corresponding theme aliases in 'mini.statusline' highlight groups. I don't really feel that this is optimal because extra attention is needed to have those groups have separate colors.

@bluz71
Copy link

bluz71 commented Jan 16, 2023

Is there any reason why this can't be merged?

I have a vested interest in this PR since I want to use the MiniStatusLine colors in my own plugin.

Cheers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants