Add specific exception for auth errors being sent to to the Sync Session error handler #1643
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@nirinchev believes that Core would automatically trigger a reconnect if you log the same user back in again. If this happens, users do not need to close the Realm. We need to test the behaviour. |
cmelchior
commented
Jan 29, 2024
| @@ -79,6 +80,7 @@ internal fun convertSyncError(syncError: SyncError): SyncException { | |||
| val errorCode = syncError.errorCode | |||
| val message = createMessageFromSyncError(errorCode) | |||
| return when (errorCode.errorCode) { | |||
| ErrorCode.RLM_ERR_AUTH_ERROR -> AuthExpiredException(message) | |||
There was a problem hiding this comment.
We should also send this to the AuthenticationListener
There was a problem hiding this comment.
We should also send this to the AuthenticationListener
We should probably update the AuthenticationListener to take advantage of realm/realm-core#7302 instead of issuing these events ourselves.
Would also be fixed by #1676
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1640
This adds a specific exception class for auth errors being sent to the SyncSession error handler. This is relevant as this indicates the user's credentials are no longer valid and they need to log in again.
Some open questions:
SyncExceptionwhen we already haveAuthExceptionunderAppException. But relaxing the interface would be a breaking change and besides, this is the only "App" type exception that would surface here anyway.SyncSessionExpiredException,SyncAuthException,SyncSessionAuthExpired. ChoosingAuthExpiredExceptionwas somewhat arbitrary, except it felt short and to the point. Not sure ifSyncorSessionshould somehow be part of the name to separate it more from the genericAuthExceptionthat is anAppException. All our other specific exception types end withException