RDART-973: Add support for the new progress notifications #1546
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* main: (28 commits) Wrong test for local development (#1591) Add vNext Changelog header (#1589) [Release 2.0.0-beta.2] (#1588) Update melos to 5.2.0 (#1587) RDART-977: Hierarchical logger (#1574) Fix release workflow (#1582) RDART-978: Add support RealmValue.fromJson (#1581) Fix oversight in install command Add vNext Changelog header (#1579) [Release 2.0.0-beta.1] (#1577) RDART-976: Fix install command (#1576) Update build instructions and switching Flutter/Dart versions (#1571) gitignore release folder Remove incorrectly committed files Cleanup changelog, bring back melos publishing (#1573) Add vNext Changelog header (#1572) [Release 2.0.0-alpha.5] (#1570) Revert "Copy symlinks for realm_dart" Copy symlinks for realm_dart Fix changelog ... # Conflicts: # packages/realm_dart/lib/src/session.dart # packages/realm_dart/src/realm-core # packages/realm_dart/test/realm_test.dart # packages/realm_dart/test/session_test.dart # packages/realm_dart/test/test.dart
nirinchev
changed the title
nielsenko
approved these changes
Apr 11, 2024
Comment on lines
+217
to
+230
| // We should not see more updates in either direction | ||
| final uploadCallbacks = uploadData.callbacksInvoked; | ||
| final downloadCallbacks = downloadData.callbacksInvoked; | ||
|
|
||
| uploadRealm.write(() { | ||
| uploadRealm.add(NullableTypes(ObjectId(), differentiator, stringProp: generateRandomString(50))); | ||
| }); | ||
|
|
||
| await uploadRealm.syncSession.waitForUpload(); | ||
| await downloadRealm.syncSession.waitForDownload(); | ||
|
|
||
| expect(uploadRealm.all<NullableTypes>().length, downloadRealm.all<NullableTypes>().length); | ||
| expect(uploadData.callbacksInvoked, uploadCallbacks); | ||
| expect(downloadData.callbacksInvoked, downloadCallbacks); |
There was a problem hiding this comment.
Could you elaborate the explanation of this part a bit? Why will we not see more upload callbacks here, when we add and wait for upload?
| @@ -418,7 +418,7 @@ void setupTests() { | |||
|
|
|||
| Realm.logger.setLogLevel(LogLevel.detail); | |||
| Realm.logger.onRecord.listen((record) { | |||
| testing.printOnFailure('${record.category} ${record.level.name}: ${record.message}'); | |||
| testing.printOnFailure('${DateTime.now().toUtc()} ${record.category} ${record.level.name}: ${record.message}'); | |||
|
Some test failures needs to be resolved |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1564
TODO: