RCORE-2058 Adding clickbench importer and query tool for evaluating compression #7664
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
--------- Co-authored-by: Finn Schiermer Andersen <[email protected]>
nicola-cab
changed the title
Pull Request Test Coverage Report for Build nicola.cabiddu_1689Details
💛 - Coveralls |
finnschiermer
force-pushed
the
nc/rcore-2076
branch
from
dd25e23
to
c436b44
Compare
jedelbo
reviewed
May 15, 2024
src/realm/exec/clickbench.cpp
Outdated
| const int bufs_per_commit = 100; | ||
| while (auto buf = mbx.receive()) { | ||
| // t->create_objects(buf); | ||
| // for (auto& val : buf->values) { |
There was a problem hiding this comment.
Too many comments to actually import anything.
There was a problem hiding this comment.
ops my bad, it should now be OK, although the strings are not going to be compressed right now.
There was a problem hiding this comment.
Just to be sure: you want to keep the verification? It will not exactly boost performance.
There was a problem hiding this comment.
I think, at this stage I do want to verify that the columns are correct, we may disable it in the future.
|
@finnschiermer @jedelbo can we get this reviewed, thanks :-) |
jedelbo
approved these changes
May 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What, How & Why?
In order to evaluate compression results, a new utility has been created for importing clickbench files.
Fixes: https://jira.mongodb.org/browse/RCORE-2076
Depends by: #7571