Remove BSON library again #7630
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What, How & Why?
I was working on actually making Bson support the real BSON encoding and wanted to have this library as a reference implementation. However I had to drop the work because realm-swift uses our current Bson class and the changes I had to make to the API did not really do well for the swift use. So this whole work is on standby. I could sense that some had problems building this library, so I thought it was better to just remove it again. We can always re-introduce it if necessary. (It came as a surprise that the Bson class was part of our public API)
☑️ ToDos
bindgen/spec.yml, if public C++ API changed