RCORE-7544 Optimize EQ search for a single interned string #7596
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
finnschiermer
changed the title
finnschiermer
force-pushed
the
fsa/string-interning
branch
from
5500793
to
7ae8865
Compare
…to fsa/eq_interning_compression
…to fsa/eq_interning_compression
nicola-cab
approved these changes
May 23, 2024
| @@ -2931,27 +2931,9 @@ DisableReplication::~DisableReplication() | |||
| m_tr.initialize_replication(); | |||
| } | |||
|
|
|||
| StringInterner* DB::get_string_interner(TableKey tk, ColKey::Idx col_idx) | |||
| StringInterner* DB::get_string_interner(TableKey tk, ColKey col_key) | |||
There was a problem hiding this comment.
Do we still need this? We are not expecting to reach this function, don't we?
There was a problem hiding this comment.
You're right, I'll remove it in the target branch.
| if (sd.data() == nullptr) | ||
| return 0; | ||
| if (sd.data() == nullptr) { | ||
| if (null_seen) |
There was a problem hiding this comment.
I guess this is the machinery for handling a null string, right?
| @@ -340,7 +340,7 @@ void ArrayString::clear() | |||
| } | |||
| } | |||
|
|
|||
| size_t ArrayString::find_first(StringData value, size_t begin, size_t end) const noexcept | |||
| size_t ArrayString::find_first(StringData value, size_t begin, size_t end, std::optional<StringID> id) const noexcept | |||
There was a problem hiding this comment.
Maybe you can pass the optional String ID by const ref? ... I guess it doesn't matter too much though, since StringID should be an integer right?
There was a problem hiding this comment.
It should not make any difference.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First half (EQ part) of #7544