Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix superfluous disable command for custom rules #5546

Draft
wants to merge 15 commits into
base: main
Choose a base branch
from
Draft

Fix superfluous disable command for custom rules #5546

wants to merge 15 commits into from

Commits on May 11, 2024

  1. Added Marcelo's changes back in

    @mildm8nnered
    mildm8nnered committed May 11, 2024
    Configuration menu
    Copy the full SHA
    030060a View commit details
    Browse the repository at this point in the history

  2. Fixed up the tests, including one failing one

    @mildm8nnered
    mildm8nnered committed May 11, 2024
    Configuration menu
    Copy the full SHA
    4e45795 View commit details
    Browse the repository at this point in the history

  3. Made more general

    @mildm8nnered
    mildm8nnered committed May 11, 2024
    Configuration menu
    Copy the full SHA
    22c5d97 View commit details
    Browse the repository at this point in the history

  4. Better pattern

    @mildm8nnered
    mildm8nnered committed May 11, 2024
    Configuration menu
    Copy the full SHA
    61d8d32 View commit details
    Browse the repository at this point in the history

  5. Simplified

    @mildm8nnered
    mildm8nnered committed May 11, 2024
    Configuration menu
    Copy the full SHA
    a9267ae View commit details
    Browse the repository at this point in the history

  6. Refactor

    @mildm8nnered
    mildm8nnered committed May 11, 2024
    Configuration menu
    Copy the full SHA
    f227155 View commit details
    Browse the repository at this point in the history

  7. Fixed method name

    @mildm8nnered
    mildm8nnered committed May 11, 2024
    Configuration menu
    Copy the full SHA
    52cd44c View commit details
    Browse the repository at this point in the history

  8. Fixed up linter errors

    @mildm8nnered
    mildm8nnered committed May 11, 2024
    Configuration menu
    Copy the full SHA
    7a470c3 View commit details
    Browse the repository at this point in the history

  9. function_body_length

    @mildm8nnered
    mildm8nnered committed May 11, 2024
    Configuration menu
    Copy the full SHA
    ad79fc4 View commit details
    Browse the repository at this point in the history

  10. queuedFatalError

    @mildm8nnered
    mildm8nnered committed May 11, 2024
    Configuration menu
    Copy the full SHA
    07d8290 View commit details
    Browse the repository at this point in the history

  11. use queuedFatalError

    @mildm8nnered
    mildm8nnered committed May 11, 2024
    Configuration menu
    Copy the full SHA
    fd5cb0d View commit details
    Browse the repository at this point in the history

  12. Not too sure about why we need to disable the disable command tests

    @mildm8nnered
    mildm8nnered committed May 11, 2024
    Configuration menu
    Copy the full SHA
    8f5fcef View commit details
    Browse the repository at this point in the history

  13. fatalError is ok here, we're ignoring the swiftlint:disable all at … 

    …the top of the file.
    @mildm8nnered
    mildm8nnered committed May 11, 2024
    Configuration menu
    Copy the full SHA
    dc820cd View commit details
    Browse the repository at this point in the history

  14. Handle the all case as well

    @mildm8nnered
    mildm8nnered committed May 11, 2024
    Configuration menu
    Copy the full SHA
    2d8b087 View commit details
    Browse the repository at this point in the history

  15. Added test for disable all

    @mildm8nnered
    mildm8nnered committed May 11, 2024
    Configuration menu
    Copy the full SHA
    344f376 View commit details
    Browse the repository at this point in the history