Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

- rule added for avoiding redundant extensions resolve #5359 #5388

Open
wants to merge 12 commits into
base: main
Choose a base branch
from

Conversation

mzeeshanid
Copy link
Contributor

New rule added for avoiding redundant extensions based on:

  • Extensions can't be nested
  • Opt-In rule
  • Severity is configurable

@SwiftLintBot
Copy link

SwiftLintBot commented Dec 11, 2023

1 Error
🚫 Please rebase to get rid of the merge commits in this PR
940 Warnings
⚠️ This PR introduced a violation in Alamofire: /Source/NetworkReachabilityManager.swift:260:1: warning: Redundant Extension Violation: Avoid redundant extensions (redundant_extension)
⚠️ This PR introduced a violation in Alamofire: /Source/Protected.swift:77:1: warning: Redundant Extension Violation: Avoid redundant extensions (redundant_extension)
⚠️ This PR introduced a violation in Alamofire: /Source/ResponseSerialization.swift:905:1: warning: Redundant Extension Violation: Avoid redundant extensions (redundant_extension)
⚠️ This PR introduced a violation in Alamofire: /Source/ResponseSerialization.swift:907:1: warning: Redundant Extension Violation: Avoid redundant extensions (redundant_extension)
⚠️ This PR introduced a violation in Alamofire: /Source/ServerTrustEvaluation.swift:478:1: warning: Redundant Extension Violation: Avoid redundant extensions (redundant_extension)
⚠️ This PR introduced a violation in Alamofire: /Source/ServerTrustEvaluation.swift:506:1: warning: Redundant Extension Violation: Avoid redundant extensions (redundant_extension)
⚠️ This PR introduced a violation in Alamofire: /Source/ServerTrustEvaluation.swift:683:1: warning: Redundant Extension Violation: Avoid redundant extensions (redundant_extension)
⚠️ This PR introduced a violation in Alamofire: /Source/ServerTrustEvaluation.swift:713:1: warning: Redundant Extension Violation: Avoid redundant extensions (redundant_extension)
⚠️ This PR introduced a violation in Alamofire: /Source/ServerTrustEvaluation.swift:726:1: warning: Redundant Extension Violation: Avoid redundant extensions (redundant_extension)
⚠️ This PR introduced a violation in Alamofire: /Source/ServerTrustEvaluation.swift:755:1: warning: Redundant Extension Violation: Avoid redundant extensions (redundant_extension)
⚠️ This PR introduced a violation in Alamofire: /Source/ServerTrustEvaluation.swift:761:1: warning: Redundant Extension Violation: Avoid redundant extensions (redundant_extension)
⚠️ This PR introduced a violation in Alamofire: /Source/URLSessionConfiguration+Alamofire.swift:27:1: warning: Redundant Extension Violation: Avoid redundant extensions (redundant_extension)
⚠️ This PR introduced a violation in Brave: /Sources/Brave/Extensions/Rewards/PublisherInfoExtensions.swift:32:1: warning: Redundant Extension Violation: Avoid redundant extensions (redundant_extension)
⚠️ This PR introduced a violation in Brave: /Sources/Brave/Frontend/Browser/BrowserViewController/BrowserViewController+Wallet.swift:116:1: warning: Redundant Extension Violation: Avoid redundant extensions (redundant_extension)
⚠️ This PR introduced a violation in Brave: /Sources/Brave/Frontend/Browser/Playlist/Browser/PlaylistPopoverView.swift:83:1: warning: Redundant Extension Violation: Avoid redundant extensions (redundant_extension)
⚠️ This PR introduced a violation in Brave: /Sources/BraveWallet/Crypto/Transactions/TransactionParser.swift:659:1: warning: Redundant Extension Violation: Avoid redundant extensions (redundant_extension)
⚠️ This PR introduced a violation in Brave: /Sources/BraveWallet/Extensions/BraveWalletSwiftUIExtensions.swift:32:1: warning: Redundant Extension Violation: Avoid redundant extensions (redundant_extension)
⚠️ This PR introduced a violation in Brave: /Sources/Data/models/CRUDProtocols.swift:161:1: warning: Redundant Extension Violation: Avoid redundant extensions (redundant_extension)
⚠️ This PR introduced a violation in Brave: /Sources/Growth/P3ATimedStorage.swift:102:1: warning: Redundant Extension Violation: Avoid redundant extensions (redundant_extension)
⚠️ This PR introduced a violation in Brave: /Sources/Growth/P3ATimedStorage.swift:103:1: warning: Redundant Extension Violation: Avoid redundant extensions (redundant_extension)
⚠️ This PR introduced a violation in Brave: /Sources/Preferences/Preferences.swift:232:1: warning: Redundant Extension Violation: Avoid redundant extensions (redundant_extension)
⚠️ This PR introduced a violation in Brave: /Sources/Preferences/Preferences.swift:233:1: warning: Redundant Extension Violation: Avoid redundant extensions (redundant_extension)
⚠️ This PR introduced a violation in Brave: /Sources/Preferences/Preferences.swift:234:1: warning: Redundant Extension Violation: Avoid redundant extensions (redundant_extension)
⚠️ This PR introduced a violation in Brave: /Sources/Preferences/Preferences.swift:235:1: warning: Redundant Extension Violation: Avoid redundant extensions (redundant_extension)
⚠️ This PR introduced a violation in Brave: /Sources/Preferences/Preferences.swift:236:1: warning: Redundant Extension Violation: Avoid redundant extensions (redundant_extension)
⚠️ This PR introduced a violation in Brave: /Sources/Preferences/Preferences.swift:237:1: warning: Redundant Extension Violation: Avoid redundant extensions (redundant_extension)
⚠️ This PR introduced a violation in Brave: /Sources/Preferences/Preferences.swift:238:1: warning: Redundant Extension Violation: Avoid redundant extensions (redundant_extension)
⚠️ This PR introduced a violation in Brave: /Sources/Preferences/Preferences.swift:239:1: warning: Redundant Extension Violation: Avoid redundant extensions (redundant_extension)
⚠️ This PR introduced a violation in Brave: /Sources/Preferences/Preferences.swift:240:1: warning: Redundant Extension Violation: Avoid redundant extensions (redundant_extension)
⚠️ This PR introduced a violation in Brave: /Sources/Preferences/Preferences.swift:241:1: warning: Redundant Extension Violation: Avoid redundant extensions (redundant_extension)
⚠️ This PR introduced a violation in Brave: /Sources/Preferences/Preferences.swift:242:1: warning: Redundant Extension Violation: Avoid redundant extensions (redundant_extension)
⚠️ This PR introduced a violation in DuckDuckGo: /Core/AppTrackerEntity.swift:90:1: warning: Redundant Extension Violation: Avoid redundant extensions (redundant_extension)
⚠️ This PR introduced a violation in DuckDuckGo: /Core/BookmarkObjects.swift:79:1: warning: Redundant Extension Violation: Avoid redundant extensions (redundant_extension)
⚠️ This PR introduced a violation in DuckDuckGo: /Core/BookmarkObjects.swift:81:1: warning: Redundant Extension Violation: Avoid redundant extensions (redundant_extension)
⚠️ This PR introduced a violation in DuckDuckGo: /Core/PixelEvent.swift:569:1: warning: Redundant Extension Violation: Avoid redundant extensions (redundant_extension)
⚠️ This PR introduced a violation in DuckDuckGo: /Core/WebCacheManager.swift:293:1: warning: Redundant Extension Violation: Avoid redundant extensions (redundant_extension)
⚠️ This PR introduced a violation in DuckDuckGo: /DuckDuckGo/ActionMessageView.swift:22:1: warning: Redundant Extension Violation: Avoid redundant extensions (redundant_extension)
⚠️ This PR introduced a violation in DuckDuckGo: /DuckDuckGo/AppConfigurationFetch.swift:34:1: warning: Redundant Extension Violation: Avoid redundant extensions (redundant_extension)
⚠️ This PR introduced a violation in DuckDuckGo: /DuckDuckGo/Autoconsent/AutoconsentUserScript.swift:34:1: warning: Redundant Extension Violation: Avoid redundant extensions (redundant_extension)
⚠️ This PR introduced a violation in DuckDuckGo: /DuckDuckGo/AutofillLoginDetailsViewModel.swift:472:1: warning: Redundant Extension Violation: Avoid redundant extensions (redundant_extension)
⚠️ This PR introduced a violation in DuckDuckGo: /DuckDuckGo/BrowsingMenu/BrowsingMenuButton.swift:22:1: warning: Redundant Extension Violation: Avoid redundant extensions (redundant_extension)
⚠️ This PR introduced a violation in DuckDuckGo: /DuckDuckGo/ContentBlockingUpdating.swift:33:1: warning: Redundant Extension Violation: Avoid redundant extensions (redundant_extension)
⚠️ This PR introduced a violation in DuckDuckGo: /DuckDuckGo/FireproofFaviconUpdater.swift:30:1: warning: Redundant Extension Violation: Avoid redundant extensions (redundant_extension)
⚠️ This PR introduced a violation in DuckDuckGo: /DuckDuckGo/OmniBar.swift:26:1: warning: Redundant Extension Violation: Avoid redundant extensions (redundant_extension)
⚠️ This PR introduced a violation in DuckDuckGo: /DuckDuckGo/PrivacyDashboard/PrivacyDashboardViewController.swift:193:1: warning: Redundant Extension Violation: Avoid redundant extensions (redundant_extension)
⚠️ This PR introduced a violation in DuckDuckGo: /DuckDuckGo/WebContainerViewController.swift:105:1: warning: Redundant Extension Violation: Avoid redundant extensions (redundant_extension)
⚠️ This PR introduced a violation in DuckDuckGo: /PacketTunnelProvider/ProxyServer/Utils/BinaryDataScanner.swift:33:1: warning: Redundant Extension Violation: Avoid redundant extensions (redundant_extension)
⚠️ This PR introduced a violation in DuckDuckGo: /PacketTunnelProvider/ProxyServer/Utils/BinaryDataScanner.swift:35:1: warning: Redundant Extension Violation: Avoid redundant extensions (redundant_extension)
⚠️ This PR introduced a violation in DuckDuckGo: /PacketTunnelProvider/ProxyServer/Utils/BinaryDataScanner.swift:37:1: warning: Redundant Extension Violation: Avoid redundant extensions (redundant_extension)
⚠️ This PR introduced a violation in DuckDuckGo: /PacketTunnelProvider/ProxyServer/Utils/Port.swift:77:1: warning: Redundant Extension Violation: Avoid redundant extensions (redundant_extension)
⚠️ This PR introduced a violation in DuckDuckGo: /PacketTunnelProvider/ProxyServer/Utils/UInt128.swift:595:1: warning: Redundant Extension Violation: Avoid redundant extensions (redundant_extension)
⚠️ This PR introduced a violation in Firefox: /BrowserKit/Sources/Common/Logger/Wrapper/SwiftyBeaverWrapper.swift:35:1: warning: Redundant Extension Violation: Avoid redundant extensions (redundant_extension)
⚠️ This PR introduced a violation in Firefox: /BrowserKit/Sources/Common/Protocols/FileManagerProtocol.swift:20:1: warning: Redundant Extension Violation: Avoid redundant extensions (redundant_extension)
⚠️ This PR introduced a violation in Firefox: /BrowserKit/Sources/Common/Utilities/DispatchQueueInterface.swift:55:1: warning: Redundant Extension Violation: Avoid redundant extensions (redundant_extension)
⚠️ This PR introduced a violation in Firefox: /BrowserKit/Sources/Common/Utilities/UserDefaultsInterface.swift:21:1: warning: Redundant Extension Violation: Avoid redundant extensions (redundant_extension)
⚠️ This PR introduced a violation in Firefox: /BrowserKit/Sources/SiteImageView/ImageProcessing/SiteImageFetcher/SiteImageDownloader.swift:81:1: warning: Redundant Extension Violation: Avoid redundant extensions (redundant_extension)
⚠️ This PR introduced a violation in Firefox: /Client/AdjustTelemetryHelper.swift:15:1: warning: Redundant Extension Violation: Avoid redundant extensions (redundant_extension)
⚠️ This PR introduced a violation in Firefox: /Client/Experiments/Messaging/GleanPlumbMessage.swift:16:1: warning: Redundant Extension Violation: Avoid redundant extensions (redundant_extension)
⚠️ This PR introduced a violation in Firefox: /Client/Experiments/Messaging/GleanPlumbMessage.swift:23:1: warning: Redundant Extension Violation: Avoid redundant extensions (redundant_extension)
⚠️ This PR introduced a violation in Firefox: /Client/Frontend/Library/Bookmarks/FxBookmarkNode.swift:27:1: warning: Redundant Extension Violation: Avoid redundant extensions (redundant_extension)
⚠️ This PR introduced a violation in Firefox: /Client/Protocols/ApplicationStateProvider.swift:11:1: warning: Redundant Extension Violation: Avoid redundant extensions (redundant_extension)
⚠️ This PR introduced a violation in Firefox: /Client/Protocols/FileManagerInterface.swift:24:1: warning: Redundant Extension Violation: Avoid redundant extensions (redundant_extension)
⚠️ This PR introduced a violation in Firefox: /Client/Protocols/Presenter.swift:22:1: warning: Redundant Extension Violation: Avoid redundant extensions (redundant_extension)
⚠️ This PR introduced a violation in Firefox: /Client/Protocols/UIDeviceInterface.swift:11:1: warning: Redundant Extension Violation: Avoid redundant extensions (redundant_extension)
⚠️ This PR introduced a violation in Firefox: /Client/Protocols/URLSession/URLSessionDataTaskProtocol.swift:11:1: warning: Redundant Extension Violation: Avoid redundant extensions (redundant_extension)
⚠️ This PR introduced a violation in Firefox: /Client/UserNotificationCenterProtocol.swift:22:1: warning: Redundant Extension Violation: Avoid redundant extensions (redundant_extension)
⚠️ This PR introduced a violation in Firefox: /firefox-ios/firefox-ios-tests/Tests/SharedTests/DeferredTestUtils.swift:13:1: warning: Redundant Extension Violation: Avoid redundant extensions (redundant_extension)
⚠️ This PR introduced a violation in Kickstarter: /Kickstarter-iOS/Features/Activities/Controller/ActivitiesViewController.swift:364:1: warning: Redundant Extension Violation: Avoid redundant extensions (redundant_extension)
⚠️ This PR introduced a violation in Kickstarter: /Kickstarter-iOS/Features/Search/Controller/SearchViewController.swift:265:1: warning: Redundant Extension Violation: Avoid redundant extensions (redundant_extension)
⚠️ This PR introduced a violation in Kickstarter: /Kickstarter-iOS/Library/BrazeTypes.swift:15:1: warning: Redundant Extension Violation: Avoid redundant extensions (redundant_extension)
⚠️ This PR introduced a violation in Kickstarter: /Kickstarter-iOS/Library/BrazeTypes.swift:9:1: warning: Redundant Extension Violation: Avoid redundant extensions (redundant_extension)
⚠️ This PR introduced a violation in Kickstarter: /Kickstarter-iOS/Library/UIFeedbackGeneratorType.swift:15:1: warning: Redundant Extension Violation: Avoid redundant extensions (redundant_extension)
⚠️ This PR introduced a violation in Kickstarter: /Kickstarter-iOS/Library/UIFeedbackGeneratorType.swift:23:1: warning: Redundant Extension Violation: Avoid redundant extensions (redundant_extension)
⚠️ This PR introduced a violation in Kickstarter: /Kickstarter-iOS/Library/UIFeedbackGeneratorType.swift:31:1: warning: Redundant Extension Violation: Avoid redundant extensions (redundant_extension)
⚠️ This PR introduced a violation in Kickstarter: /Kickstarter-iOS/Library/WebViewController.swift:79:1: warning: Redundant Extension Violation: Avoid redundant extensions (redundant_extension)
⚠️ This PR introduced a violation in Kickstarter: /Kickstarter-iOS/Library/WebViewController.swift:81:1: warning: Redundant Extension Violation: Avoid redundant extensions (redundant_extension)
⚠️ This PR introduced a violation in Kickstarter: /Kickstarter-iOS/Library/WebViewController.swift:87:1: warning: Redundant Extension Violation: Avoid redundant extensions (redundant_extension)
⚠️ This PR introduced a violation in Kickstarter: /KsApi/models/Activity.swift:41:1: warning: Redundant Extension Violation: Avoid redundant extensions (redundant_extension)
⚠️ This PR introduced a violation in Kickstarter: /KsApi/models/ActivityComment.swift:46:1: warning: Redundant Extension Violation: Avoid redundant extensions (redundant_extension)
⚠️ This PR introduced a violation in Kickstarter: /KsApi/models/ActivityEnvelope.swift:23:1: warning: Redundant Extension Violation: Avoid redundant extensions (redundant_extension)
⚠️ This PR introduced a violation in Kickstarter: /KsApi/models/Backing.swift:115:1: warning: Redundant Extension Violation: Avoid redundant extensions (redundant_extension)
⚠️ This PR introduced a violation in Kickstarter: /KsApi/models/Backing.swift:43:1: warning: Redundant Extension Violation: Avoid redundant extensions (redundant_extension)
⚠️ This PR introduced a violation in Kickstarter: /KsApi/models/Category.swift:118:1: warning: Redundant Extension Violation: Avoid redundant extensions (redundant_extension)
⚠️ This PR introduced a violation in Kickstarter: /KsApi/models/Comment.swift:50:1: warning: Redundant Extension Violation: Avoid redundant extensions (redundant_extension)
⚠️ This PR introduced a violation in Kickstarter: /KsApi/models/Comment.swift:88:1: warning: Redundant Extension Violation: Avoid redundant extensions (redundant_extension)
⚠️ This PR introduced a violation in Kickstarter: /KsApi/models/Config.swift:72:1: warning: Redundant Extension Violation: Avoid redundant extensions (redundant_extension)
⚠️ This PR introduced a violation in Kickstarter: /KsApi/models/DiscoveryParams.swift:81:1: warning: Redundant Extension Violation: Avoid redundant extensions (redundant_extension)
⚠️ This PR introduced a violation in Kickstarter: /KsApi/models/ErrorEnvelope.swift:139:1: warning: Redundant Extension Violation: Avoid redundant extensions (redundant_extension)
⚠️ This PR introduced a violation in Kickstarter: /KsApi/models/ErrorEnvelope.swift:175:1: warning: Redundant Extension Violation: Avoid redundant extensions (redundant_extension)
⚠️ This PR introduced a violation in Kickstarter: /KsApi/models/ErrorEnvelope.swift:190:1: warning: Redundant Extension Violation: Avoid redundant extensions (redundant_extension)
⚠️ This PR introduced a violation in Kickstarter: /KsApi/models/ErrorEnvelope.swift:200:1: warning: Redundant Extension Violation: Avoid redundant extensions (redundant_extension)
⚠️ This PR introduced a violation in Kickstarter: /KsApi/models/FindFriendsEnvelope.swift:25:1: warning: Redundant Extension Violation: Avoid redundant extensions (redundant_extension)
⚠️ This PR introduced a violation in Kickstarter: /KsApi/models/Location.swift:30:1: warning: Redundant Extension Violation: Avoid redundant extensions (redundant_extension)
⚠️ This PR introduced a violation in Kickstarter: /KsApi/models/MessageSubject.swift:28:1: warning: Redundant Extension Violation: Avoid redundant extensions (redundant_extension)
⚠️ This PR introduced a violation in Kickstarter: /KsApi/models/MessageThread.swift:25:1: warning: Redundant Extension Violation: Avoid redundant extensions (redundant_extension)
⚠️ This PR introduced a violation in Kickstarter: /KsApi/models/Param.swift:44:1: warning: Redundant Extension Violation: Avoid redundant extensions (redundant_extension)
⚠️ This PR introduced a violation in Kickstarter: /KsApi/models/Project.Country.swift:104:1: warning: Redundant Extension Violation: Avoid redundant extensions (redundant_extension)
⚠️ This PR introduced a violation in Kickstarter: /KsApi/models/Project.swift:258:1: warning: Redundant Extension Violation: Avoid redundant extensions (redundant_extension)
⚠️ This PR introduced a violation in Kickstarter: /KsApi/models/Project.swift:464:1: warning: Redundant Extension Violation: Avoid redundant extensions (redundant_extension)
⚠️ This PR introduced a violation in Kickstarter: /KsApi/models/ProjectNotification.swift:16:1: warning: Redundant Extension Violation: Avoid redundant extensions (redundant_extension)
⚠️ This PR introduced a violation in Kickstarter: /KsApi/models/ProjectNotification.swift:18:1: warning: Redundant Extension Violation: Avoid redundant extensions (redundant_extension)
⚠️ This PR introduced a violation in Kickstarter: /KsApi/models/ProjectNotification.swift:20:1: warning: Redundant Extension Violation: Avoid redundant extensions (redundant_extension)
⚠️ This PR introduced a violation in Kickstarter: /KsApi/models/ProjectNotification.swift:25:1: warning: Redundant Extension Violation: Avoid redundant extensions (redundant_extension)
⚠️ This PR introduced a violation in Kickstarter: /KsApi/models/ProjectStatsEnvelope.swift:110:1: warning: Redundant Extension Violation: Avoid redundant extensions (redundant_extension)
⚠️ This PR introduced a violation in Kickstarter: /KsApi/models/ProjectStatsEnvelope.swift:143:1: warning: Redundant Extension Violation: Avoid redundant extensions (redundant_extension)
⚠️ This PR introduced a violation in Kickstarter: /KsApi/models/ProjectStatsEnvelope.swift:164:1: warning: Redundant Extension Violation: Avoid redundant extensions (redundant_extension)
⚠️ This PR introduced a violation in Kickstarter: /KsApi/models/ProjectStatsEnvelope.swift:195:1: warning: Redundant Extension Violation: Avoid redundant extensions (redundant_extension)
⚠️ This PR introduced a violation in Kickstarter: /KsApi/models/ProjectStatsEnvelope.swift:242:1: warning: Redundant Extension Violation: Avoid redundant extensions (redundant_extension)
⚠️ This PR introduced a violation in Kickstarter: /KsApi/models/ProjectStatsEnvelope.swift:257:1: warning: Redundant Extension Violation: Avoid redundant extensions (redundant_extension)
⚠️ This PR introduced a violation in Kickstarter: /KsApi/models/Reward.swift:85:1: warning: Redundant Extension Violation: Avoid redundant extensions (redundant_extension)
⚠️ This PR introduced a violation in Kickstarter: /KsApi/models/Reward.swift:92:1: warning: Redundant Extension Violation: Avoid redundant extensions (redundant_extension)
⚠️ This PR introduced a violation in Kickstarter: /KsApi/models/ShippingRule.swift:24:1: warning: Redundant Extension Violation: Avoid redundant extensions (redundant_extension)
⚠️ This PR introduced a violation in Kickstarter: /KsApi/models/StarEnvelope.swift:8:1: warning: Redundant Extension Violation: Avoid redundant extensions (redundant_extension)
⚠️ This PR introduced a violation in Kickstarter: /KsApi/models/SurveyResponse.swift:18:1: warning: Redundant Extension Violation: Avoid redundant extensions (redundant_extension)
⚠️ This PR introduced a violation in Kickstarter: /KsApi/models/SurveyResponse.swift:32:1: warning: Redundant Extension Violation: Avoid redundant extensions (redundant_extension)
⚠️ This PR introduced a violation in Kickstarter: /KsApi/models/SurveyResponse.swift:33:1: warning: Redundant Extension Violation: Avoid redundant extensions (redundant_extension)
⚠️ This PR introduced a violation in Kickstarter: /KsApi/models/Update.swift:28:1: warning: Redundant Extension Violation: Avoid redundant extensions (redundant_extension)
⚠️ This PR introduced a violation in Kickstarter: /KsApi/models/Update.swift:69:1: warning: Redundant Extension Violation: Avoid redundant extensions (redundant_extension)
⚠️ This PR introduced a violation in Kickstarter: /KsApi/models/Update.swift:71:1: warning: Redundant Extension Violation: Avoid redundant extensions (redundant_extension)
⚠️ This PR introduced a violation in Kickstarter: /KsApi/models/UpdateDraft.swift:32:1: warning: Redundant Extension Violation: Avoid redundant extensions (redundant_extension)
⚠️ This PR introduced a violation in Kickstarter: /KsApi/models/UpdateDraft.swift:57:1: warning: Redundant Extension Violation: Avoid redundant extensions (redundant_extension)
⚠️ This PR introduced a violation in Kickstarter: /KsApi/models/UpdateDraft.swift:76:1: warning: Redundant Extension Violation: Avoid redundant extensions (redundant_extension)
⚠️ This PR introduced a violation in Kickstarter: /KsApi/models/UpdateDraft.swift:77:1: warning: Redundant Extension Violation: Avoid redundant extensions (redundant_extension)
⚠️ This PR introduced a violation in Kickstarter: /KsApi/models/UpdateDraft.swift:78:1: warning: Redundant Extension Violation: Avoid redundant extensions (redundant_extension)
⚠️ This PR introduced a violation in Kickstarter: /KsApi/models/User.swift:102:1: warning: Redundant Extension Violation: Avoid redundant extensions (redundant_extension)
⚠️ This PR introduced a violation in Kickstarter: /KsApi/models/User.swift:232:1: warning: Redundant Extension Violation: Avoid redundant extensions (redundant_extension)
⚠️ This PR introduced a violation in Kickstarter: /KsApi/models/User.swift:293:1: warning: Redundant Extension Violation: Avoid redundant extensions (redundant_extension)
⚠️ This PR introduced a violation in Kickstarter: /KsApi/models/VoidEnvelope.swift:4:1: warning: Redundant Extension Violation: Avoid redundant extensions (redundant_extension)
⚠️ This PR introduced a violation in Kickstarter: /Library/AssetImageGeneratorType.swift:13:1: warning: Redundant Extension Violation: Avoid redundant extensions (redundant_extension)
⚠️ This PR introduced a violation in Kickstarter: /Library/ExpandableRow.swift:45:1: warning: Redundant Extension Violation: Avoid redundant extensions (redundant_extension)
⚠️ This PR introduced a violation in Kickstarter: /Library/Instantiable.swift:14:1: warning: Redundant Extension Violation: Avoid redundant extensions (redundant_extension)
⚠️ This PR introduced a violation in Kickstarter: /Library/KeyValueStoreType.swift:171:1: warning: Redundant Extension Violation: Avoid redundant extensions (redundant_extension)
⚠️ This PR introduced a violation in Kickstarter: /Library/Language.swift:47:1: warning: Redundant Extension Violation: Avoid redundant extensions (redundant_extension)
⚠️ This PR introduced a violation in Kickstarter: /Library/NSHTTPCookieStorageType.swift:12:1: warning: Redundant Extension Violation: Avoid redundant extensions (redundant_extension)
⚠️ This PR introduced a violation in Kickstarter: /Library/Navigation.swift:83:1: warning: Redundant Extension Violation: Avoid redundant extensions (redundant_extension)
⚠️ This PR introduced a violation in Kickstarter: /Library/ProcessInfoType.swift:7:1: warning: Redundant Extension Violation: Avoid redundant extensions (redundant_extension)
⚠️ This PR introduced a violation in Kickstarter: /Library/RefTag.swift:163:1: warning: Redundant Extension Violation: Avoid redundant extensions (redundant_extension)
⚠️ This PR introduced a violation in Kickstarter: /Library/SelectableRow.swift:51:1: warning: Redundant Extension Violation: Avoid redundant extensions (redundant_extension)
⚠️ This PR introduced a violation in Kickstarter: /Library/ShortcutItem.swift:31:1: warning: Redundant Extension Violation: Avoid redundant extensions (redundant_extension)
⚠️ This PR introduced a violation in Kickstarter: /Library/TestHelpers/AlertError+Equatable.swift:3:1: warning: Redundant Extension Violation: Avoid redundant extensions (redundant_extension)
⚠️ This PR introduced a violation in Kickstarter: /Library/Tracking/Segment.swift:33:1: warning: Redundant Extension Violation: Avoid redundant extensions (redundant_extension)
⚠️ This PR introduced a violation in Kickstarter: /Library/Tracking/Segment.swift:34:1: warning: Redundant Extension Violation: Avoid redundant extensions (redundant_extension)
⚠️ This PR introduced a violation in Kickstarter: /Library/UIApplication.swift:3:1: warning: Redundant Extension Violation: Avoid redundant extensions (redundant_extension)
⚠️ This PR introduced a violation in Kickstarter: /Library/UIScreenType.swift:10:1: warning: Redundant Extension Violation: Avoid redundant extensions (redundant_extension)
⚠️ This PR introduced a violation in Kickstarter: /Library/UUIDType.swift:8:1: warning: Redundant Extension Violation: Avoid redundant extensions (redundant_extension)
⚠️ This PR introduced a violation in Kickstarter: /Library/ViewModels/ProjectPamphletSubpageCellViewModel.swift:150:1: warning: Redundant Extension Violation: Avoid redundant extensions (redundant_extension)
⚠️ This PR introduced a violation in Kickstarter: /Library/ViewModels/ProjectPamphletSubpageCellViewModel.swift:97:1: warning: Redundant Extension Violation: Avoid redundant extensions (redundant_extension)
⚠️ This PR introduced a violation in Kickstarter: /Library/ViewModels/RootViewModel.swift:452:1: warning: Redundant Extension Violation: Avoid redundant extensions (redundant_extension)
⚠️ Danger found 940 violations with this PR. Due to GitHub's max issue comment size, the number shown has been truncated to 148.
17 Messages
📖 Linting Aerial with this PR took 1.19s vs 1.18s on main (0% slower)
📖 Linting Alamofire with this PR took 1.66s vs 1.64s on main (1% slower)
📖 Linting Brave with this PR took 9.31s vs 9.31s on main (0% slower)
📖 Linting DuckDuckGo with this PR took 4.79s vs 4.76s on main (0% slower)
📖 Linting Firefox with this PR took 10.89s vs 10.91s on main (0% faster)
📖 Linting Kickstarter with this PR took 11.27s vs 11.21s on main (0% slower)
📖 Linting Moya with this PR took 0.63s vs 0.63s on main (0% slower)
📖 Linting NetNewsWire with this PR took 3.33s vs 3.35s on main (0% faster)
📖 Linting Nimble with this PR took 0.84s vs 0.84s on main (0% slower)
📖 Linting PocketCasts with this PR took 9.06s vs 9.03s on main (0% slower)
📖 Linting Quick with this PR took 0.4s vs 0.4s on main (0% slower)
📖 Linting Realm with this PR took 5.88s vs 5.83s on main (0% slower)
📖 Linting Sourcery with this PR took 2.84s vs 2.82s on main (0% slower)
📖 Linting Swift with this PR took 5.37s vs 5.35s on main (0% slower)
📖 Linting VLC with this PR took 1.6s vs 1.6s on main (0% slower)
📖 Linting Wire with this PR took 20.13s vs 20.06s on main (0% slower)
📖 Linting WordPress with this PR took 13.66s vs 13.65s on main (0% slower)

Generated by 🚫 Danger

- new case added in non triggering example
@SimplyDanny SimplyDanny linked an issue Dec 12, 2023 that may be closed by this pull request
Copy link
Collaborator

@SimplyDanny SimplyDanny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Short and easy. Well done!

CHANGELOG.md Outdated
@@ -10,6 +10,10 @@

#### Enhancements

* Add new `redundant_extension` rule that detect redundant extensions.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* Add new `redundant_extension` rule that detect redundant extensions.
* Add new `redundant_extension` rule that detects redundant extensions.
An extension is considered redundant if it does not define any
members, but only conformances.

@SimplyDanny
Copy link
Collaborator

You need to rebase to get rid of the failing test.

CHANGELOG.md Outdated
@@ -10,6 +10,12 @@

#### Enhancements

* Add new `redundant_extension` rule that detects redundant extensions.
An extension is considered redundant if it does not define any
members, but only conformances.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The two spaces are required here to enforce a line break in the rendered Markdown:

Suggested change
members, but only conformances.
members, but only conformances.

* main:
  Use explicit version for Bundler (realm#5395)
  Add destination to xcodebuild test instructions (realm#5392)
  Support Swift version 5.9.2 (realm#5391)
@mzeeshanid
Copy link
Contributor Author

You need to rebase to get rid of the failing test.

I have synced the main branch from the original repo into my fork and merge the changes in my current branch. But still its failing.

@SimplyDanny
Copy link
Collaborator

You need to rebase to get rid of the failing test.

I have synced the main branch from the original repo into my fork and merge the changes in my current branch. But still its failing.

Merge is not the same as rebase. 😉

Danger fails because of merge commits which are undesirable.

- new case added in non triggering example
… into redundant_extension

* 'redundant_extension' of github.com:mzeeshanid/SwiftLint:
  - change log updated
  - change log updated
  - new example added
  - simplified logic - new case added in non triggering example
  - rule added for avoiding redundant extensions resolve realm#5359
@mzeeshanid
Copy link
Contributor Author

This branch is messed up 🙃. I have created a new pull request with the same changes in a single commit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Detect redundant extensions
3 participants