Add new uiimage_requires_bundle Rule
#5177
Conversation
| @@ -206,6 +206,7 @@ public let builtInRules: [Rule.Type] = [ | |||
| UnavailableConditionRule.self, | |||
| UnavailableFunctionRule.self, | |||
| UnhandledThrowingTaskRule.self, | |||
| UIImageIncludesBundleRule.self, | |||
There was a problem hiding this comment.
I added this and the lines in GeneratedTests.swift to check the rule, but I'm sure there's a more appropriate way to get Sourcery involved here.
| static let description = RuleDescription( | ||
| identifier: "uiimage_requires_bundle", | ||
| name: "UIImage Requires Bundle", | ||
| description: "`UIImage(named:) must specify a bundle via the `in:` parameter", |
There was a problem hiding this comment.
| description: "`UIImage(named:) must specify a bundle via the `in:` parameter", | |
| description: "`UIImage(named:)` must specify a bundle via the `in:` parameter", |
| @@ -206,6 +206,7 @@ public let builtInRules: [Rule.Type] = [ | |||
| UnavailableConditionRule.self, | |||
| UnavailableFunctionRule.self, | |||
| UnhandledThrowingTaskRule.self, | |||
| UIImageIncludesBundleRule.self, | |||
| } | ||
| } | ||
|
|
||
| private extension TupleExprElementListSyntax { |
There was a problem hiding this comment.
This is a copy of the same extension in NSLocalizedStringRequireBundleRule. Please move it to SwiftSyntax+SwiftLint.swift to make it reusable.
There was a problem hiding this comment.
This pushed that file beyond 400 lines! I tried working around this by moving any extensions on structures defined inside the generated SyntaxCollections (these three: AttributeListSyntax, ModifierListSyntax, and TupleExprElementListSyntax), but I get this error: testSwiftLintLints(): failed - File name should match a type or extension declared in the file (if any) This is on a file I called SwiftSyntaxCollections+SwiftLint.swift. How would you recommend getting around this?
There was a problem hiding this comment.
The file_length rule has meanwhile been disabled in SwiftSyntax+SwiftLint.swift. You don't have to bother with that anymore. I'd rather like to have these extension in one place.
Adds a new rule to help ensure that use of
UIImage(named:)includes a bundle, helpful for modularized codebases.This was based on the very similar
NSLocalizedStringRequireBundleRule