Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comment style #5148

Open
wants to merge 21 commits into
base: main
Choose a base branch
from
Open

Comment style #5148

wants to merge 21 commits into from

Conversation

mredig
Copy link
Contributor

@mredig mredig commented Jul 31, 2023

Allows for options to enforce styling of comments. Should all comments be multiline comments? Should they be single line? Or should there be a threshold, where if x number of single line comments are in a row, should they be multiline?

I want to add the same functionality to documentation comments and, while I added the skeletal capability, I haven't had the chance to add the examples, tests, and actual rule (tho the rule should be very simple since it should be the exact same logic as the comment logic).

@SwiftLintBot
Copy link

SwiftLintBot commented Jul 31, 2023

2153 Warnings
⚠️ Big PR
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Controllers/CustomVideoController.swift:104:17: warning: Comment Style Violation: Multiline comments not allowed (comment_style)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Controllers/CustomVideoController.swift:226:1: warning: Comment Style Violation: Multiline comments not allowed (comment_style)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Controllers/CustomVideoController.swift:573:5: warning: Comment Style Violation: Multiline comments not allowed (comment_style)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Models/API/OneCall.swift:180:5: warning: Comment Style Violation: Multiline comments not allowed (comment_style)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Models/API/OneCall.swift:33:9: warning: Comment Style Violation: Multiline comments not allowed (comment_style)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Models/API/OneCall.swift:83:1: warning: Comment Style Violation: Multiline comments not allowed (comment_style)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Models/Aerial.swift:255:5: warning: Comment Style Violation: Multiline comments not allowed (comment_style)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Models/Cache/Cache.swift:178:9: warning: Comment Style Violation: Multiline comments not allowed (comment_style)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Models/Cache/PoiStringProvider.swift:114:9: warning: Comment Style Violation: Multiline comments not allowed (comment_style)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Models/Cache/PoiStringProvider.swift:80:13: warning: Comment Style Violation: Multiline comments not allowed (comment_style)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Models/Cache/Thumbnails.swift:22:5: warning: Comment Style Violation: Multiline comments not allowed (comment_style)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Models/Cache/VideoCache.swift:213:13: warning: Comment Style Violation: Multiline comments not allowed (comment_style)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Models/ErrorLog.swift:50:1: warning: Comment Style Violation: Multiline comments not allowed (comment_style)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Models/ManifestLoader.swift:159:9: warning: Comment Style Violation: Multiline comments not allowed (comment_style)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Models/ManifestLoader.swift:180:13: warning: Comment Style Violation: Multiline comments not allowed (comment_style)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Models/ManifestLoader.swift:269:13: warning: Comment Style Violation: Multiline comments not allowed (comment_style)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Models/ManifestLoader.swift:291:1: warning: Comment Style Violation: Multiline comments not allowed (comment_style)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Models/ManifestLoader.swift:456:9: warning: Comment Style Violation: Multiline comments not allowed (comment_style)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Models/ManifestLoader.swift:732:9: warning: Comment Style Violation: Multiline comments not allowed (comment_style)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Models/ManifestLoader.swift:802:9: warning: Comment Style Violation: Multiline comments not allowed (comment_style)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Models/ManifestLoader.swift:978:1: warning: Comment Style Violation: Multiline comments not allowed (comment_style)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Models/Sources/Source.swift:212:21: warning: Comment Style Violation: Multiline comments not allowed (comment_style)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Models/Sources/SourceList.swift:48:5: warning: Comment Style Violation: Multiline comments not allowed (comment_style)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Models/Sources/VideoList.swift:181:9: warning: Comment Style Violation: Multiline comments not allowed (comment_style)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Models/Sources/VideoList.swift:186:9: warning: Comment Style Violation: Multiline comments not allowed (comment_style)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Models/Sources/VideoList.swift:413:1: warning: Comment Style Violation: Multiline comments not allowed (comment_style)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Models/Sources/VideoList.swift:465:13: warning: Comment Style Violation: Multiline comments not allowed (comment_style)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Models/Time/TimeManagement.swift:334:1: warning: Comment Style Violation: Multiline comments not allowed (comment_style)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Models/Time/TimeManagement.swift:355:1: warning: Comment Style Violation: Multiline comments not allowed (comment_style)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Views/AerialView.swift:119:9: warning: Comment Style Violation: Multiline comments not allowed (comment_style)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Views/AerialView.swift:161:9: warning: Comment Style Violation: Multiline comments not allowed (comment_style)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Views/Layers/BatteryIconLayer.swift:43:1: warning: Comment Style Violation: Multiline comments not allowed (comment_style)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Views/Layers/Music/ArtworkLayer.swift:53:5: warning: Comment Style Violation: Multiline comments not allowed (comment_style)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Views/Layers/Music/MusicLayer.swift:44:9: warning: Comment Style Violation: Multiline comments not allowed (comment_style)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Views/Layers/Music/MusicLayer.swift:64:13: warning: Comment Style Violation: Multiline comments not allowed (comment_style)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Views/Layers/Weather/ConditionSymbolLayer.swift:219:17: warning: Comment Style Violation: Multiline comments not allowed (comment_style)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Views/Layers/Weather/WeatherLayer.swift:110:1: warning: Comment Style Violation: Multiline comments not allowed (comment_style)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Views/Layers/Weather/WeatherLayer.swift:46:43: warning: Comment Style Violation: Multiline comments not allowed (comment_style)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Views/Layers/Weather/WeatherLayer.swift:79:43: warning: Comment Style Violation: Multiline comments not allowed (comment_style)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Views/MainUI/SidebarOutlineView.swift:17:5: warning: Comment Style Violation: Multiline comments not allowed (comment_style)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Views/PrefPanel/InfoTableSource.swift:46:17: warning: Comment Style Violation: Multiline comments not allowed (comment_style)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Views/PrefPanel/VideoViewItem.swift:43:5: warning: Comment Style Violation: Multiline comments not allowed (comment_style)
⚠️ This PR introduced a violation in Aerial: /Resources/MainUI/Settings panels/CacheViewController.swift:105:13: warning: Comment Style Violation: Multiline comments not allowed (comment_style)
⚠️ This PR introduced a violation in Aerial: /Resources/MainUI/Settings panels/Collection View/PlayingCollectionViewItem.swift:78:5: warning: Comment Style Violation: Multiline comments not allowed (comment_style)
⚠️ This PR introduced a violation in Aerial: /Resources/MainUI/Settings panels/SourcesViewController.swift:342:1: warning: Comment Style Violation: Multiline comments not allowed (comment_style)
⚠️ This PR introduced a violation in Aerial: /Resources/MainUI/Settings panels/SourcesViewController.swift:87:9: warning: Comment Style Violation: Multiline comments not allowed (comment_style)
⚠️ This PR introduced a violation in Aerial: /Resources/MainUI/SidebarViewController.swift:108:13: warning: Comment Style Violation: Multiline comments not allowed (comment_style)
⚠️ This PR introduced a violation in Aerial: /Resources/MainUI/SidebarViewController.swift:249:1: warning: Comment Style Violation: Multiline comments not allowed (comment_style)
⚠️ This PR introduced a violation in Aerial: /Resources/MainUI/VideosViewController.swift:298:8: warning: Comment Style Violation: Multiline comments not allowed (comment_style)
⚠️ This PR introduced a violation in Aerial: /Tests/PreferencesTests.swift:8:1: warning: Comment Style Violation: Multiline comments not allowed (comment_style)
⚠️ This PR introduced a violation in Brave: /App/iOS/Delegates/AppDelegate.swift:101:5: warning: Comment Style Violation: Singleline comments not allowed (comment_style)
⚠️ This PR introduced a violation in Brave: /App/iOS/Delegates/AppDelegate.swift:105:5: warning: Comment Style Violation: Singleline comments not allowed (comment_style)
⚠️ This PR introduced a violation in Brave: /App/iOS/Delegates/AppDelegate.swift:110:9: warning: Comment Style Violation: Singleline comments not allowed (comment_style)
⚠️ This PR introduced a violation in Brave: /App/iOS/Delegates/AppDelegate.swift:117:9: warning: Comment Style Violation: Singleline comments not allowed (comment_style)
⚠️ This PR introduced a violation in Brave: /App/iOS/Delegates/AppDelegate.swift:134:9: warning: Comment Style Violation: Singleline comments not allowed (comment_style)
⚠️ This PR introduced a violation in Brave: /App/iOS/Delegates/AppDelegate.swift:153:5: warning: Comment Style Violation: Singleline comments not allowed (comment_style)
⚠️ This PR introduced a violation in Brave: /App/iOS/Delegates/AppDelegate.swift:155:7: warning: Comment Style Violation: Singleline comments not allowed (comment_style)
⚠️ This PR introduced a violation in Brave: /App/iOS/Delegates/AppDelegate.swift:168:5: warning: Comment Style Violation: Singleline comments not allowed (comment_style)
⚠️ This PR introduced a violation in Brave: /App/iOS/Delegates/AppDelegate.swift:171:5: warning: Comment Style Violation: Singleline comments not allowed (comment_style)
⚠️ This PR introduced a violation in Brave: /App/iOS/Delegates/AppDelegate.swift:175:5: warning: Comment Style Violation: Singleline comments not allowed (comment_style)
⚠️ This PR introduced a violation in Brave: /App/iOS/Delegates/AppDelegate.swift:178:5: warning: Comment Style Violation: Singleline comments not allowed (comment_style)
⚠️ This PR introduced a violation in Brave: /App/iOS/Delegates/AppDelegate.swift:188:5: warning: Comment Style Violation: Singleline comments not allowed (comment_style)
⚠️ This PR introduced a violation in Brave: /App/iOS/Delegates/AppDelegate.swift:191:5: warning: Comment Style Violation: Singleline comments not allowed (comment_style)
⚠️ This PR introduced a violation in Brave: /App/iOS/Delegates/AppDelegate.swift:205:5: warning: Comment Style Violation: Singleline comments not allowed (comment_style)
⚠️ This PR introduced a violation in Brave: /App/iOS/Delegates/AppDelegate.swift:209:5: warning: Comment Style Violation: Singleline comments not allowed (comment_style)
⚠️ This PR introduced a violation in Brave: /App/iOS/Delegates/AppDelegate.swift:216:5: warning: Comment Style Violation: Singleline comments not allowed (comment_style)
⚠️ This PR introduced a violation in Brave: /App/iOS/Delegates/AppDelegate.swift:220:5: warning: Comment Style Violation: Singleline comments not allowed (comment_style)
⚠️ This PR introduced a violation in Brave: /App/iOS/Delegates/AppDelegate.swift:223:5: warning: Comment Style Violation: Singleline comments not allowed (comment_style)
⚠️ This PR introduced a violation in Brave: /App/iOS/Delegates/AppDelegate.swift:229:7: warning: Comment Style Violation: Singleline comments not allowed (comment_style)
⚠️ This PR introduced a violation in Brave: /App/iOS/Delegates/AppDelegate.swift:231:7: warning: Comment Style Violation: Singleline comments not allowed (comment_style)
⚠️ This PR introduced a violation in Brave: /App/iOS/Delegates/AppDelegate.swift:238:7: warning: Comment Style Violation: Singleline comments not allowed (comment_style)
⚠️ This PR introduced a violation in Brave: /App/iOS/Delegates/AppDelegate.swift:244:5: warning: Comment Style Violation: Singleline comments not allowed (comment_style)
⚠️ This PR introduced a violation in Brave: /App/iOS/Delegates/AppDelegate.swift:252:5: warning: Comment Style Violation: Singleline comments not allowed (comment_style)
⚠️ This PR introduced a violation in Brave: /App/iOS/Delegates/AppDelegate.swift:256:5: warning: Comment Style Violation: Singleline comments not allowed (comment_style)
⚠️ This PR introduced a violation in Brave: /App/iOS/Delegates/AppDelegate.swift:267:5: warning: Comment Style Violation: Singleline comments not allowed (comment_style)
⚠️ This PR introduced a violation in Brave: /App/iOS/Delegates/AppDelegate.swift:271:7: warning: Comment Style Violation: Singleline comments not allowed (comment_style)
⚠️ This PR introduced a violation in Brave: /App/iOS/Delegates/AppDelegate.swift:275:5: warning: Comment Style Violation: Singleline comments not allowed (comment_style)
⚠️ This PR introduced a violation in Brave: /App/iOS/Delegates/AppDelegate.swift:288:5: warning: Comment Style Violation: Singleline comments not allowed (comment_style)
⚠️ This PR introduced a violation in Brave: /App/iOS/Delegates/AppDelegate.swift:297:5: warning: Comment Style Violation: Singleline comments not allowed (comment_style)
⚠️ This PR introduced a violation in Brave: /App/iOS/Delegates/AppDelegate.swift:302:5: warning: Comment Style Violation: Singleline comments not allowed (comment_style)
⚠️ This PR introduced a violation in Brave: /App/iOS/Delegates/AppDelegate.swift:315:5: warning: Comment Style Violation: Singleline comments not allowed (comment_style)
⚠️ This PR introduced a violation in Brave: /App/iOS/Delegates/AppDelegate.swift:322:5: warning: Comment Style Violation: Singleline comments not allowed (comment_style)
⚠️ This PR introduced a violation in Brave: /App/iOS/Delegates/AppDelegate.swift:330:7: warning: Comment Style Violation: Singleline comments not allowed (comment_style)
⚠️ This PR introduced a violation in Brave: /App/iOS/Delegates/AppDelegate.swift:338:9: warning: Comment Style Violation: Singleline comments not allowed (comment_style)
⚠️ This PR introduced a violation in Brave: /App/iOS/Delegates/AppDelegate.swift:341:9: warning: Comment Style Violation: Singleline comments not allowed (comment_style)
⚠️ This PR introduced a violation in Brave: /App/iOS/Delegates/AppDelegate.swift:358:5: warning: Comment Style Violation: Singleline comments not allowed (comment_style)
⚠️ This PR introduced a violation in Brave: /App/iOS/Delegates/AppDelegate.swift:36:3: warning: Comment Style Violation: Singleline comments not allowed (comment_style)
⚠️ This PR introduced a violation in Brave: /App/iOS/Delegates/AppDelegate.swift:386:5: warning: Comment Style Violation: Singleline comments not allowed (comment_style)
⚠️ This PR introduced a violation in Brave: /App/iOS/Delegates/AppDelegate.swift:391:5: warning: Comment Style Violation: Singleline comments not allowed (comment_style)
⚠️ This PR introduced a violation in Brave: /App/iOS/Delegates/AppDelegate.swift:406:5: warning: Comment Style Violation: Singleline comments not allowed (comment_style)
⚠️ This PR introduced a violation in Brave: /App/iOS/Delegates/AppDelegate.swift:420:5: warning: Comment Style Violation: Singleline comments not allowed (comment_style)
⚠️ This PR introduced a violation in Brave: /App/iOS/Delegates/AppDelegate.swift:447:5: warning: Comment Style Violation: Singleline comments not allowed (comment_style)
⚠️ This PR introduced a violation in Brave: /App/iOS/Delegates/AppDelegate.swift:455:5: warning: Comment Style Violation: Singleline comments not allowed (comment_style)
⚠️ This PR introduced a violation in Brave: /App/iOS/Delegates/AppDelegate.swift:480:9: warning: Comment Style Violation: Singleline comments not allowed (comment_style)
⚠️ This PR introduced a violation in Brave: /App/iOS/Delegates/AppDelegate.swift:495:5: warning: Comment Style Violation: Singleline comments not allowed (comment_style)
⚠️ This PR introduced a violation in Brave: /App/iOS/Delegates/AppDelegate.swift:502:3: warning: Comment Style Violation: Singleline comments not allowed (comment_style)
⚠️ This PR introduced a violation in Brave: /App/iOS/Delegates/AppDelegate.swift:505:5: warning: Comment Style Violation: Singleline comments not allowed (comment_style)
⚠️ This PR introduced a violation in Brave: /App/iOS/Delegates/AppDelegate.swift:517:5: warning: Comment Style Violation: Singleline comments not allowed (comment_style)
⚠️ This PR introduced a violation in Brave: /App/iOS/Delegates/AppDelegate.swift:53:7: warning: Comment Style Violation: Singleline comments not allowed (comment_style)
⚠️ This PR introduced a violation in Brave: /Package.swift:335:62: warning: Comment Style Violation: Multiline comments not allowed (comment_style)
⚠️ This PR introduced a violation in Brave: /Sources/Brave/Extensions/DispatchQueueExtensions.swift:7:1: warning: Comment Style Violation: Singleline comments not allowed (comment_style)
⚠️ This PR introduced a violation in Brave: /Sources/Brave/Extensions/HttpCookieExtension.swift:22:5: warning: Comment Style Violation: Multiline comments not allowed (comment_style)
⚠️ This PR introduced a violation in Brave: /Sources/Brave/Extensions/NSURLExtensionsMailTo.swift:28:5: warning: Comment Style Violation: Singleline comments not allowed (comment_style)
⚠️ This PR introduced a violation in Brave: /Sources/Brave/Extensions/NSURLExtensionsMailTo.swift:38:5: warning: Comment Style Violation: Singleline comments not allowed (comment_style)
⚠️ This PR introduced a violation in Brave: /Sources/Brave/Extensions/UIAlertControllerExtensions.swift:10:1: warning: Comment Style Violation: Singleline comments not allowed (comment_style)
⚠️ This PR introduced a violation in Brave: /Sources/Brave/Extensions/UIAlertControllerExtensions.swift:154:3: warning: Comment Style Violation: Singleline comments not allowed (comment_style)
⚠️ This PR introduced a violation in Brave: /Sources/Brave/Extensions/UIAlertControllerExtensions.swift:183:5: warning: Comment Style Violation: Singleline comments not allowed (comment_style)
⚠️ This PR introduced a violation in Brave: /Sources/Brave/Extensions/UIAlertControllerExtensions.swift:198:1: warning: Comment Style Violation: Singleline comments not allowed (comment_style)
⚠️ This PR introduced a violation in Brave: /Sources/Brave/Extensions/UIViewExtensions.swift:64:5: warning: Comment Style Violation: Singleline comments not allowed (comment_style)
⚠️ This PR introduced a violation in Brave: /Sources/Brave/Frontend/Brave Notifications/Brave Rewards/RewardsNotification.swift:117:10: warning: Comment Style Violation: Multiline comments not allowed (comment_style)
⚠️ This PR introduced a violation in Brave: /Sources/Brave/Frontend/Brave Notifications/Brave Rewards/RewardsNotification.swift:122:17: warning: Comment Style Violation: Multiline comments not allowed (comment_style)
⚠️ This PR introduced a violation in Brave: /Sources/Brave/Frontend/Browser/Authenticator.swift:103:7: warning: Comment Style Violation: Singleline comments not allowed (comment_style)
⚠️ This PR introduced a violation in Brave: /Sources/Brave/Frontend/Browser/Authenticator.swift:109:7: warning: Comment Style Violation: Singleline comments not allowed (comment_style)
⚠️ This PR introduced a violation in Brave: /Sources/Brave/Frontend/Browser/Authenticator.swift:42:5: warning: Comment Style Violation: Singleline comments not allowed (comment_style)
⚠️ This PR introduced a violation in Brave: /Sources/Brave/Frontend/Browser/Authenticator.swift:47:5: warning: Comment Style Violation: Singleline comments not allowed (comment_style)
⚠️ This PR introduced a violation in Brave: /Sources/Brave/Frontend/Browser/Authenticator.swift:58:5: warning: Comment Style Violation: Singleline comments not allowed (comment_style)
⚠️ This PR introduced a violation in Brave: /Sources/Brave/Frontend/Browser/Authenticator.swift:63:5: warning: Comment Style Violation: Singleline comments not allowed (comment_style)
⚠️ This PR introduced a violation in Brave: /Sources/Brave/Frontend/Browser/Authenticator.swift:85:7: warning: Comment Style Violation: Singleline comments not allowed (comment_style)
⚠️ This PR introduced a violation in Brave: /Sources/Brave/Frontend/Browser/Authenticator.swift:97:7: warning: Comment Style Violation: Singleline comments not allowed (comment_style)
⚠️ This PR introduced a violation in Brave: /Sources/Brave/Frontend/Browser/BackForwardListViewController.swift:203:3: warning: Comment Style Violation: Singleline comments not allowed (comment_style)
⚠️ This PR introduced a violation in Brave: /Sources/Brave/Frontend/Browser/BackForwardListViewController.swift:91:5: warning: Comment Style Violation: Singleline comments not allowed (comment_style)
⚠️ This PR introduced a violation in Brave: /Sources/Brave/Frontend/Browser/BraveGetUA.swift:34:5: warning: Comment Style Violation: Singleline comments not allowed (comment_style)
⚠️ This PR introduced a violation in Brave: /Sources/Brave/Frontend/Browser/BrowserPrompts.swift:101:5: warning: Comment Style Violation: Singleline comments not allowed (comment_style)
⚠️ This PR introduced a violation in Brave: /Sources/Brave/Frontend/Browser/BrowserViewController.swift:1041:5: warning: Comment Style Violation: Singleline comments not allowed (comment_style)
⚠️ This PR introduced a violation in Brave: /Sources/Brave/Frontend/Browser/BrowserViewController.swift:1061:5: warning: Comment Style Violation: Singleline comments not allowed (comment_style)
⚠️ This PR introduced a violation in Brave: /Sources/Brave/Frontend/Browser/BrowserViewController.swift:108:5: warning: Comment Style Violation: Singleline comments not allowed (comment_style)
⚠️ This PR introduced a violation in Brave: /Sources/Brave/Frontend/Browser/BrowserViewController.swift:1100:5: warning: Comment Style Violation: Singleline comments not allowed (comment_style)
⚠️ This PR introduced a violation in Brave: /Sources/Brave/Frontend/Browser/BrowserViewController.swift:1105:5: warning: Comment Style Violation: Singleline comments not allowed (comment_style)
⚠️ This PR introduced a violation in Brave: /Sources/Brave/Frontend/Browser/BrowserViewController.swift:1108:5: warning: Comment Style Violation: Singleline comments not allowed (comment_style)
⚠️ This PR introduced a violation in Brave: /Sources/Brave/Frontend/Browser/BrowserViewController.swift:1111:5: warning: Comment Style Violation: Singleline comments not allowed (comment_style)
⚠️ This PR introduced a violation in Brave: /Sources/Brave/Frontend/Browser/BrowserViewController.swift:1179:9: warning: Comment Style Violation: Singleline comments not allowed (comment_style)
⚠️ This PR introduced a violation in Brave: /Sources/Brave/Frontend/Browser/BrowserViewController.swift:1200:13: warning: Comment Style Violation: Singleline comments not allowed (comment_style)
⚠️ This PR introduced a violation in Brave: /Sources/Brave/Frontend/Browser/BrowserViewController.swift:1244:5: warning: Comment Style Violation: Singleline comments not allowed (comment_style)
⚠️ This PR introduced a violation in Brave: /Sources/Brave/Frontend/Browser/BrowserViewController.swift:1269:13: warning: Comment Style Violation: Singleline comments not allowed (comment_style)
⚠️ This PR introduced a violation in Brave: /Sources/Brave/Frontend/Browser/BrowserViewController.swift:1286:5: warning: Comment Style Violation: Singleline comments not allowed (comment_style)
⚠️ This PR introduced a violation in Brave: /Sources/Brave/Frontend/Browser/BrowserViewController.swift:1303:7: warning: Comment Style Violation: Singleline comments not allowed (comment_style)
⚠️ This PR introduced a violation in Brave: /Sources/Brave/Frontend/Browser/BrowserViewController.swift:1319:7: warning: Comment Style Violation: Singleline comments not allowed (comment_style)
⚠️ This PR introduced a violation in Brave: /Sources/Brave/Frontend/Browser/BrowserViewController.swift:1337:7: warning: Comment Style Violation: Singleline comments not allowed (comment_style)
⚠️ This PR introduced a violation in Brave: /Sources/Brave/Frontend/Browser/BrowserViewController.swift:134:3: warning: Comment Style Violation: Singleline comments not allowed (comment_style)
⚠️ This PR introduced a violation in Brave: /Sources/Brave/Frontend/Browser/BrowserViewController.swift:1370:9: warning: Comment Style Violation: Singleline comments not allowed (comment_style)
⚠️ This PR introduced a violation in Brave: /Sources/Brave/Frontend/Browser/BrowserViewController.swift:1452:9: warning: Comment Style Violation: Singleline comments not allowed (comment_style)
⚠️ This PR introduced a violation in Brave: /Sources/Brave/Frontend/Browser/BrowserViewController.swift:1511:7: warning: Comment Style Violation: Singleline comments not allowed (comment_style)
⚠️ This PR introduced a violation in Brave: /Sources/Brave/Frontend/Browser/BrowserViewController.swift:1536:7: warning: Comment Style Violation: Singleline comments not allowed (comment_style)
⚠️ This PR introduced a violation in Brave: /Sources/Brave/Frontend/Browser/BrowserViewController.swift:1581:3: warning: Comment Style Violation: Singleline comments not allowed (comment_style)
⚠️ This PR introduced a violation in Brave: /Sources/Brave/Frontend/Browser/BrowserViewController.swift:1589:15: warning: Comment Style Violation: Singleline comments not allowed (comment_style)
⚠️ This PR introduced a violation in Brave: /Sources/Brave/Frontend/Browser/BrowserViewController.swift:1592:5: warning: Comment Style Violation: Singleline comments not allowed (comment_style)
⚠️ This PR introduced a violation in Brave: /Sources/Brave/Frontend/Browser/BrowserViewController.swift:1598:5: warning: Comment Style Violation: Singleline comments not allowed (comment_style)
⚠️ Danger found 2153 violations with this PR. Due to GitHub's max issue comment size, the number shown has been truncated to 148.
17 Messages
📖 Linting Aerial with this PR took 1.12s vs 1.11s on main (0% slower)
📖 Linting Alamofire with this PR took 1.45s vs 1.44s on main (0% slower)
📖 Linting Brave with this PR took 8.11s vs 8.08s on main (0% slower)
📖 Linting DuckDuckGo with this PR took 3.95s vs 3.94s on main (0% slower)
📖 Linting Firefox with this PR took 9.57s vs 9.56s on main (0% slower)
📖 Linting Kickstarter with this PR took 10.42s vs 10.34s on main (0% slower)
📖 Linting Moya with this PR took 0.6s vs 0.59s on main (1% slower)
📖 Linting NetNewsWire with this PR took 3.12s vs 3.11s on main (0% slower)
📖 Linting Nimble with this PR took 0.78s vs 0.76s on main (2% slower)
📖 Linting PocketCasts with this PR took 8.07s vs 8.05s on main (0% slower)
📖 Linting Quick with this PR took 0.39s vs 0.38s on main (2% slower)
📖 Linting Realm with this PR took 11.27s vs 11.21s on main (0% slower)
📖 Linting Sourcery with this PR took 2.37s vs 2.35s on main (0% slower)
📖 Linting Swift with this PR took 5.23s vs 5.22s on main (0% slower)
📖 Linting VLC with this PR took 1.42s vs 1.41s on main (0% slower)
📖 Linting Wire with this PR took 8.62s vs 8.61s on main (0% slower)
📖 Linting WordPress with this PR took 12.43s vs 12.44s on main (0% faster)

Generated by 🚫 Danger

should not trigger on the swiftlint code now
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants