Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Indentation style #5144

Open
wants to merge 11 commits into
base: main
Choose a base branch
from
Open

Indentation style #5144

wants to merge 11 commits into from

Commits on Feb 23, 2024

  1. (feat) add indentation style rule

    @mredig
    mredig committed Feb 23, 2024
    Configuration menu
    Copy the full SHA
    c21f01d View commit details
    Browse the repository at this point in the history

  2. (refactor) test multiline strings in indentation_style

    @mredig
    mredig committed Feb 23, 2024
    Configuration menu
    Copy the full SHA
    89b5ab9 View commit details
    Browse the repository at this point in the history

  3. (nit) notate the reason to expect the violation in indentation_style

    @mredig
    mredig committed Feb 23, 2024
    Configuration menu
    Copy the full SHA
    45b84aa View commit details
    Browse the repository at this point in the history

  4. (refactor) slightly ironic indentation_style indentation update

    @mredig
    mredig committed Feb 23, 2024
    Configuration menu
    Copy the full SHA
    92983c3 View commit details
    Browse the repository at this point in the history

  5. (refactor/indentation_style) set violation placement expectation

    @mredig
    mredig committed Feb 23, 2024
    Configuration menu
    Copy the full SHA
    bdf4735 View commit details
    Browse the repository at this point in the history

  6. (refactor/indentation_style) test and implement multiline comment enf… 

    …orcement
    @mredig
    mredig committed Feb 23, 2024
    Configuration menu
    Copy the full SHA
    513d9e5 View commit details
    Browse the repository at this point in the history

  7. (nit) swiftlint autocorrections

    @mredig
    mredig committed Feb 23, 2024
    Configuration menu
    Copy the full SHA
    2dfad93 View commit details
    Browse the repository at this point in the history

  8. (nit) add changelog entry with predicted PR number 

    (nit) spelling

(fix) corrected PR number in changelog

(nit) ironically didn't run swiftlint to see that I needed to fix some violations

... until now

(fix) changelog values
    @mredig
    mredig committed Feb 23, 2024
    Configuration menu
    Copy the full SHA
    5909311 View commit details
    Browse the repository at this point in the history

  9. (fix) address reviewed issues 

    * use `symbol` instead of `string`
* `!boolean` instead of `boolean == false`
* produce violation instead of fatalError
* More professional description
* readdressed line length on private func
* document `tab_width` usage
    @mredig
    mredig committed Feb 23, 2024
    Configuration menu
    Copy the full SHA
    5bbee51 View commit details
    Browse the repository at this point in the history

  10. (fix) after merging in latest swiftlint main branch, updated changes 

    to build and pass tests
    @mredig
    mredig committed Feb 23, 2024
    Configuration menu
    Copy the full SHA
    9490124 View commit details
    Browse the repository at this point in the history

  11. (fix) address integration tests issues

    @mredig
    mredig committed Feb 23, 2024
    Configuration menu
    Copy the full SHA
    e78e18d View commit details
    Browse the repository at this point in the history