Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Vertical whitespace between functions #5136

Open
wants to merge 11 commits into
base: main
Choose a base branch
from
Open

Vertical whitespace between functions #5136

wants to merge 11 commits into from

Commits on Jul 19, 2023

  1. Change tuple into a struct in preparation for adding more contextual … 

    …information
    @bunnyhero
    bunnyhero committed Jul 19, 2023
    Configuration menu
    Copy the full SHA
    9842ef2 View commit details
    Browse the repository at this point in the history

  2. Detect whether blank section is next to a function

    @bunnyhero
    bunnyhero committed Jul 19, 2023
    Configuration menu
    Copy the full SHA
    18344a1 View commit details
    Browse the repository at this point in the history

  3. Separately configure lines-between-functions

    @bunnyhero
    bunnyhero committed Jul 19, 2023
    Configuration menu
    Copy the full SHA
    03dc723 View commit details
    Browse the repository at this point in the history

  4. Fix linting violations

    @bunnyhero
    bunnyhero committed Jul 19, 2023
    Configuration menu
    Copy the full SHA
    440c645 View commit details
    Browse the repository at this point in the history

  5. Use contains() instead of first() != nil

    @bunnyhero
    bunnyhero committed Jul 19, 2023
    Configuration menu
    Copy the full SHA
    d066d27 View commit details
    Browse the repository at this point in the history

  6. Update violation message to match appropriate situation

    @bunnyhero
    bunnyhero committed Jul 19, 2023
    Configuration menu
    Copy the full SHA
    97e19f4 View commit details
    Browse the repository at this point in the history

  7. Update CHANGELOG.md for vertical_whitespace rule change.

    @bunnyhero
    bunnyhero committed Jul 19, 2023
    Configuration menu
    Copy the full SHA
    aae6622 View commit details
    Browse the repository at this point in the history

  8. Add test for new option

    @bunnyhero
    bunnyhero committed Jul 19, 2023
    Configuration menu
    Copy the full SHA
    60b5849 View commit details
    Browse the repository at this point in the history

  9. Add autocorrection test

    @bunnyhero
    bunnyhero committed Jul 19, 2023
    Configuration menu
    Copy the full SHA
    1c2fe0b View commit details
    Browse the repository at this point in the history

  10. Add violation message test

    @bunnyhero
    bunnyhero committed Jul 19, 2023
    Configuration menu
    Copy the full SHA
    38cc8d3 View commit details
    Browse the repository at this point in the history

  11. Add correction test to ensure max_empty_lines result is not affecte… 

    …d by a different `max_empty_lines_between_functions` value
    @bunnyhero
    bunnyhero committed Jul 19, 2023
    Configuration menu
    Copy the full SHA
    765055f View commit details
    Browse the repository at this point in the history