Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow dynamic redirect uri from provider configuration #17

Merged
merged 1 commit into from
Feb 17, 2015

Conversation

ychaze
Copy link
Contributor

@ychaze ychaze commented Jan 8, 2015

By adding this to the strategy you can pass the redirect uri directly in the configuration of the provider.

For example, with devise in devise.rb:

Devise.setup do |config|

  config.omniauth :salesforce, 'key', 'secret', {redirect_uri: 'http://localhost:3000/users/auth/salesforce/callback'}

end

@ychaze
Copy link
Contributor Author

ychaze commented Feb 17, 2015

@realdoug Is it possible that you merge it so we get the fix in the gem ?

@realdoug
Copy link
Owner

@yann Sorry about that. Testing now.

realdoug added a commit that referenced this pull request Feb 17, 2015
Allow dynamic redirect uri from provider configuration
@realdoug realdoug merged commit 6d042ec into realdoug:master Feb 17, 2015
@realdoug
Copy link
Owner

I can't seem to break this. Merged. Will cut a new gem soon.

@ychaze
Copy link
Contributor Author

ychaze commented Feb 17, 2015

Thanks!

@robvolk
Copy link

robvolk commented Sep 26, 2017

@realdoug can you cut a new gem? would like to use an official version instead of referencing it from github

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants