Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring. Cleanup. RSpec upgrade. Etc... #10

Closed
wants to merge 8 commits into from

Conversation

simonoff
Copy link

No description provided.

@realdoug
Copy link
Owner

@simonoff There is a lot of code here (500+ changes). Can you provide a verbal description of everything that you're changing and why you'd like to change it? Thanks!

@simonoff
Copy link
Author

Refactoring. Following ruby code style. And tests rewritten on 70%. Add support for Travis CI.

@realdoug
Copy link
Owner

realdoug commented Aug 1, 2014

So I'm pretty resistant to testing changes, because this library is not undergoing lots and lots of active development and there is not currently a problem with bugs getting missed.

Adding rake in the Gemfile is fine, and your readme changes are fine too. You can send those in a separate request and I'll merge.

In general I'm going to be pretty resistant to any code changes if there is not an actual new feature or bug that is being implemented.

@simonoff
Copy link
Author

simonoff commented Aug 1, 2014

Hm... Code just now tested better then was. In any case as you wish.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants