Refactoring. Cleanup. RSpec upgrade. Etc... #10
Conversation
|
@simonoff There is a lot of code here (500+ changes). Can you provide a verbal description of everything that you're changing and why you'd like to change it? Thanks! |
|
Refactoring. Following ruby code style. And tests rewritten on 70%. Add support for Travis CI. |
|
So I'm pretty resistant to testing changes, because this library is not undergoing lots and lots of active development and there is not currently a problem with bugs getting missed. Adding rake in the Gemfile is fine, and your readme changes are fine too. You can send those in a separate request and I'll merge. In general I'm going to be pretty resistant to any code changes if there is not an actual new feature or bug that is being implemented. |
|
Hm... Code just now tested better then was. In any case as you wish. |
No description provided.