Webhooks: refactor branch/tag building#12014
Conversation
Extracted from #11942
humitos
left a comment
There was a problem hiding this comment.
I left some questions since I have some doubts, but I think it's getting close.
ericholscher
left a comment
There was a problem hiding this comment.
This looks close to me, with just a couple notes. @humitos could also review it again, but I think overall looks good.
Do we plan to build tags directly with this logic? Is there more info on how this changes anything downstream around that?
Only tags/branches that come from a repo webhook
Not sure what downstream refers to here. But all the logic is the same as before, just more exact when selecting the version that corresponds to the branch/tag to build. |
ericholscher
left a comment
There was a problem hiding this comment.
Looks good to me -- would still like to have @humitos give a 👍 to merge tho, since he had some other review comments.
Extracted from #11942