Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update allauth #11327

Merged
merged 8 commits into from
May 22, 2024
Merged

Update allauth #11327

merged 8 commits into from
May 22, 2024

Conversation

stsewd
Copy link
Member

@stsewd stsewd commented May 15, 2024

0.63 is the latest release, but pip-tools doesn't seem to recognize the SAML deps, probably a bug with the package (also, the last version is quiet recent), so better to stick to 0.61 for now. Fixed, we are using the latest version now.

Changes are small, the templates changes were mostly to move the base override to another file. The old bitbucket integration was also removed (we would still have integrations in the db, see #11162).

URLs for listing the social accounts have changed, but they added redirects for them.

Closes #11309

@stsewd stsewd marked this pull request as ready for review May 16, 2024 22:51
@stsewd stsewd requested review from a team as code owners May 16, 2024 22:51
@stsewd stsewd requested review from agjohnson and humitos May 16, 2024 22:51
Copy link
Contributor

@agjohnson agjohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes here seem minimal, but I cannot speak as to the issues with 0.58.0. I would get @humitos opinion here.

I did raise in the ext-theme PR whether or not the template changes have any other affect on our templates. How much did the previous base.html template deviate from the new base_entrance.html?

@stsewd
Copy link
Member Author

stsewd commented May 21, 2024

I did raise in the ext-theme PR whether or not the template changes have any other affect on our templates. How much did the previous base.html template deviate from the new base_entrance.html?

@agjohnson all UI elements look the same to me, for what I can tell the re-organization was made in order to be able to re-use the base template across all views.

Copy link
Member

@humitos humitos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍🏼

@humitos
Copy link
Member

humitos commented May 21, 2024

I'm blocking releasing this today due to readthedocs/ext-theme#350 that hasn't been approved yet and it seems there is a bug to fix yet. We can release it next week, since it shouldn't take too much to create the fix.

@stsewd stsewd merged commit 411e177 into main May 22, 2024
7 checks passed
@stsewd stsewd deleted the update-allauth branch May 22, 2024 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allauth: update to use latest version
3 participants