-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(parser): rewriting the library in typescript #932
Merged
Merged
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
79bb52b
feat(parser): rewriting the library in typescript
erunion 1d37388
feat: ESM'ing our tests
erunion bb1a912
fix: a number of weird quirks in unit tests
erunion 9e2d21f
fix: surfacing a test quirk up a bit in a formal vitest config
erunion 8c5861c
fix: numerous typing issues throughout the parser
erunion edde00e
fix: cleaning up some unused exports
erunion 0184c5a
fix: renaming the main exports from SwaggerParser to OpenAPIParser
erunion ccc4a7a
fix: various linting issues, removing old linting exclusions
erunion 7663342
fix: variety of issues with the parser and getting `oas-normalize` up…
erunion a8fd68f
chore: smol lint + test fixes
kanadgupta 52f807e
chore: prettier
kanadgupta File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,4 @@ | ||
{ | ||
"extends": ["@readme/eslint-config", "@readme/eslint-config/typescript", "@readme/eslint-config/esm"], | ||
"root": true | ||
"root": true, | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
packages/parser/test/specs/large-file-memory-leak/cloudflare-stringified.json |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,7 @@ | ||
{ | ||
"editor.defaultFormatter": "esbenp.prettier-vscode", | ||
"editor.codeActionsOnSave": { | ||
"source.fixAll": "explicit" | ||
}, | ||
"editor.formatOnSave": true | ||
} |
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,49 +1,10 @@ | ||
{ | ||
"root": true, | ||
"extends": [ | ||
"@readme/eslint-config", | ||
"@readme/eslint-config/typescript", | ||
], | ||
"env": { | ||
"browser": true, | ||
"node": true | ||
}, | ||
"rules": { | ||
"camelcase": ["error", { "allow": ["OpenAPIV3_1"] }], | ||
"lines-between-class-members": "off", | ||
"no-continue": "off", | ||
"no-plusplus": "off", | ||
"no-restricted-syntax": "off", | ||
"no-underscore-dangle": "off", | ||
"no-use-before-define": "off", | ||
"prefer-rest-params": "off", | ||
"prefer-spread": "off" | ||
"prefer-spread": "off", | ||
}, | ||
"overrides": [ | ||
{ | ||
// The typings in this file are pretty bad right now, when we have native types we can | ||
// remove this. | ||
"files": ["lib/index.d.ts"], | ||
"rules": { | ||
"@typescript-eslint/consistent-indexed-object-style": "off", | ||
"@typescript-eslint/consistent-type-imports": "off", | ||
"@typescript-eslint/no-explicit-any": "off", | ||
"@typescript-eslint/sort-type-constituents": "off", | ||
"eslint-comments/no-unused-disable": "off", | ||
"lines-between-class-members": "off", | ||
"max-classes-per-file": "off", | ||
"quotes": "off", | ||
"typescript-sort-keys/interface": "off" | ||
} | ||
}, | ||
{ | ||
// These can all get removed when the library is moved over to native TS. | ||
"files": ["*.js"], | ||
"rules": { | ||
"@typescript-eslint/no-this-alias": "off", | ||
"@typescript-eslint/no-unused-vars": "off", | ||
"@typescript-eslint/no-use-before-define": "off", | ||
"@typescript-eslint/no-var-requires": "off", | ||
"eslint-comments/no-unused-disable": "off", | ||
"func-names": "off" | ||
} | ||
} | ||
] | ||
} |
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
considering this is now a named import:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
was already planning on making all of this a breaking change once the warning work is in
planning on doing a docs only followup after merging this