feat: add option to disable horizontal swiping when scroll is true.

[tm-bookshop]

I'm looking to add the equivalent functionality that was added here: readium/swift-toolkit#531

[mickael-menu]

Thanks for contributing this @tm-bookshop!

[qnga]

The name scrollModeDisableSwipePagination sounds a bit confusing to me. Pagination? In scroll mode?scrollModeDisableSwipe could be enough. It's a bit mysterious but at least not confusing.

[tm-bookshop]

The name scrollModeDisableSwipePagination sounds a bit confusing to me. Pagination? In scroll mode?scrollModeDisableSwipe could be enough. It's a bit mysterious but at least not confusing.

Fair point @qnga , I thought about "swipe" initially but thought that was also confusing. Swipes can be up/down or left/right and this only impacts left/right. disclaimer: my understanding of this repo is not very deep.

The reason I chose "pagination" is because it seemed to fit best with "resource paging" (via the R2ViewPager).

I'm not really attached to the name though, so happy to with whatever the reviewers land on. Maybe something like "scrollModeDisableSwipeResourcePaging" if we want to get real verbose?

[mickael-menu]

@tm-bookshop For the sake of consistency, I suggest using the same name as the one in the Swift toolkit: Configuration.disablePageTurnsWhileScrolling.

[tm-bookshop]

@tm-bookshop For the sake of consistency, I suggest using the same name as the one in the Swift toolkit: Configuration.disablePageTurnsWhileScrolling.

@mickael-menu , done

[mickael-menu]

Thank you @tm-bookshop 🙏

[mickael-menu]

Ha, I made some changes and also fixed the lint but I can't push it to your fork. Could you enable "Edit from maintainers" in your PR? Thanks

[mickael-menu]

Alternatively, here's the patch to apply
patch.diff.zip

[tm-bookshop]

@mickael-menu diff applied, thank you. I think the "Edit from maintainers" option might be disabled because I'm on an Enterprise github account