-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MSIEXEC][MSI] Sync msiexec to wine-9.8 #6897
base: master
Are you sure you want to change the base?
[MSIEXEC][MSI] Sync msiexec to wine-9.8 #6897
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When syncing a wine module, the corresponding winetest must also be synced.
Shouldn't this MSIEXEC sync go also with a sync of MSI.DLL ?
(Request for change may not fully apply here)
…copy_file(). wine commit id a58c6251870dfb7d214464e709bbbc9ca649b900 by Paul Gofman <[email protected]>
…irecord. wine commit id 2fde0a3f5c233b0ea1637f409998ce4ee85d28a7 by Alex Henrie <[email protected]>
wine commit id 7cc7a6defc08d4de7574b7a75d574c3ab1f32db8 by Alex Henrie <[email protected]>
… them. wine commit id b07c95e79cdf6ae26c5170daa481ad160e0ce76a by Alex Henrie <[email protected]>
wine commit id d920aa81ad0c4618c27ebd7e9863618e988328e0 by Alex Henrie <[email protected]>
The pSignatureSettings field was not unitilized so it got a random value from the stack causing a later crash when it was dereferenced in Wintrust (SoftPubloadSignature). wine commit id 904bedb3e96bc68101652e151db102532399abe8 by Philip K. Gisslow <[email protected]>
…_query (cppcheck). wine commit id 3e231d0f36a56ce991c7edbb6ae7845094e8417e by Alex Henrie <[email protected]>
…text (cppcheck). wine commit id 6c1dd0f2c5669e084eb1f84571c38761a97c0970 by Alex Henrie <[email protected]>
…y (cppcheck). wine commit id d394df4a30feb685927908fce2887bf5496b5d66 by Alex Henrie <[email protected]>
wine commit id 69154f0329aec4fb64886a0689da198b5323dcde by Hans Leidekker <[email protected]>
Done |
…ent rights. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=51040 wine commit id 79ec3d9fb8551e84e9ff71dcf18861430246278a by Hans Leidekker <[email protected]>
wine commit id 9725a2286acdb791de316295d9bcb11411a3fd56 by Zebediah Figura <[email protected]>
This avoids overflow when component costs exceed 4 GB. wine commit id d7bbe884ef29215f4db2027f450fb959314f5383 by Zebediah Figura <[email protected]>
The main motivation here is to avoid overflow, and multiplying in one place seems simpler. wine commit id 4a227c62a59a55aff9bacf1473c7f478f5c83294 by Zebediah Figura <[email protected]>
Dragon Naturally Speaking 12.5 manually validates that the custom action server is elevated. One might imagine that the right approach here is to add a manifest to msiexec; however, msiexec does not always trigger a UAC prompt on Windows. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=51143 wine commit id 366398cc53c76028c8dfe8d8a16c78a6a10ce962 by Zebediah Figura <[email protected]>
wine commit id 43fb0ecd0717ad1a6aa0702ed68368ee35d3ecda by Alexandre Julliard <[email protected]>
wine commit id b3f11ceb7a0ddcf5fe742377f99c947b0b56a051 by Hans Leidekker <[email protected]>
Wine starts processes non-elevated since e92ba2de43d7afbe0704b11b29f7c30f44dfaeca which means that many tests are skipped now. wine commit id a6eb51f0e595b2e5ddc521fb61b10d72849dd0f2 by Hans Leidekker <[email protected]>
wine commit id 738ec8285583248a84349939734ed600a47ba73d by Hans Leidekker <[email protected]>
…tom actions. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=56493 wine commit id 7f0ca9c284d15d03f14a8fefefac834990d622cd by Hans Leidekker <[email protected]>
…s and before commit custom actions. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=56609 wine commit id 27f5470ff4c20121b9eacd702c888400191c7d9e by Hans Leidekker <[email protected]>
While it doesn't relate to the current build errors you should also remove nonamless defines from the precomp header |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for also syncing the tests.
Purpose
Sync msiexec & msi to wine 9.8
JIRA issue: None
Proposed changes
Todo:
Before:
After: