[SHLWAPI][SDK] Add IShellFolder_... helper functions #6893
Merged
+161
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
katahiromz
added
the
hackfix
whindsaks
reviewed
May 15, 2024
HBelusca
requested review from
binarymaster,
HBelusca,
cbialorucki and
DarkFire01
HBelusca
reviewed
May 15, 2024
|
Why is the PR tagged as "hackfix"? |
HBelusca
reviewed
May 16, 2024
| #undef IShellFolder_ParseDisplayName | ||
| #undef IShellFolder_CompareIDs | ||
|
|
||
| #define SHLWAPI_ISHELLFOLDER_HELPERS /* HACK! */ |
There was a problem hiding this comment.
Regarding "HACK": Well, it's kind of fine, because those exported IShellFolder functions from shlwapi seem to be quick-handly helpers for code that don't otherwise use a full-blown IShellFolder_.... interface, it seems to me at least. It's kind of undocumented, so it should be fine, in our undocumented header, to have a specific define to enable or disable definition of stuff.
There was a problem hiding this comment.
that don't otherwise use a full-blown IShellFolder_.... interface
No, it seems to be for the shell to use when interacting with 3rd-party IShellFolders that it does not fully trust to behave correctly.
katahiromz
removed
the
hackfix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Implementing missing features...
JIRA issue: CORE-19278
Proposed changes
IShellFolder_GetDisplayNameOf,IShellFolder_ParseDisplayName, andIShellFolder_CompareIDsfunctions.<shlwapi_undoc.h>.shlwapi.spec.SHCIDS_...macros intoshobjidl.idl.SHLWAPI_ISHELLFOLDER_HELPERSto avoid conflict with<shobjidl.h>IShellFolder_...inline functions. Ugly hack but effective!TODO