-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SHLWAPI][SDK] Add IShellFolder_... helper functions #6893
Conversation
Why is the PR tagged as "hackfix"? |
#undef IShellFolder_ParseDisplayName | ||
#undef IShellFolder_CompareIDs | ||
|
||
#define SHLWAPI_ISHELLFOLDER_HELPERS /* HACK! */ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Regarding "HACK": Well, it's kind of fine, because those exported IShellFolder functions from shlwapi seem to be quick-handly helpers for code that don't otherwise use a full-blown IShellFolder_.... interface, it seems to me at least. It's kind of undocumented, so it should be fine, in our undocumented header, to have a specific define to enable or disable definition of stuff.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
that don't otherwise use a full-blown IShellFolder_.... interface
No, it seems to be for the shell to use when interacting with 3rd-party IShellFolders that it does not fully trust to behave correctly.
Purpose
Implementing missing features...
JIRA issue: CORE-19278
Proposed changes
IShellFolder_GetDisplayNameOf
,IShellFolder_ParseDisplayName
, andIShellFolder_CompareIDs
functions.<shlwapi_undoc.h>
.shlwapi.spec
.SHCIDS_...
macros intoshobjidl.idl
.SHLWAPI_ISHELLFOLDER_HELPERS
to avoid conflict with<shobjidl.h>
IShellFolder_...
inline functions. Ugly hack but effective!TODO