[COMCTL32] Fix combo box crash on WPS Office 2016 v10.1.0.5614 install #6870
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I wonder whether this bug also happens in Wine proper. |
I do think this PR is a hack/workaround. And the bugfix should land otherwhere instead. |
JoachimHenze
added
hackfix
Not in latest Wine apparently. |
Doug-Lyons
force-pushed
the
comctl32_combo_wps_office
branch
from
88f15d3
to
2a251aa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Patch by @I_Kill_Bugs
Purpose
Fix crash in comctl32 combobox on WPS Office install.
JIRA issue: CORE-12033
Proposed changes
Only use 'RedrawWindow' from CBResetPos in combo.c when items in combobox != 0.
From @I_Kill_Bugs:
The combobox was sent a WM_PAINT message that it wasn't expecting
which caused the ATL based installer control to try and access listbox strings
that haven't been added yet causing the exception.