[SHELL32] RC: Fix some FIXMEs, add others #6861

JoachimHenze · 2024-05-09T13:18:53Z

fixes the last text truncations we had in IDD_FOLDER_OPTIONS_GENERAL
small tweaks otherwhere
add some FIXMEs

JIRA issue: none

- fixes the last text truncations we had in IDD_FOLDER_OPTIONS_GENERAL - small tweaks otherwhere - add some FIXMEs

dll/win32/shell32/lang/fr-FR.rc

HBelusca · 2024-05-09T13:56:37Z

dll/win32/shell32/lang/fr-FR.rc

@@ -707,7 +707,7 @@ STYLE DS_SHELLFONT | WS_CHILD | WS_CAPTION
 FONT 8, "MS Shell Dlg"
 BEGIN
 GROUPBOX "Quel type de dossier voulez-vous ?", IDC_STATIC, 5, 5, 230, 65, WS_TABSTOP
- LTEXT "Utiliser ce dossier comme modèle :", IDC_STATIC, 15, 20, 210, 12
+ LTEXT "Utiliser ce dossier comme modèle :", IDC_STATIC, 15, 20, 210, 12 //FIXME: accelerator is missing


Not only there but in other controls in this dialog ^^

dll/win32/shell32/lang/fr-FR.rc

dll/win32/shell32/lang/pt-PT.rc

HBelusca · 2024-05-09T14:04:01Z

dll/win32/shell32/lang/id-ID.rc

- PUSHBUTTON "&Kembalikan asal", IDC_FOLDER_OPTIONS_RESTORE, 167, 194, 90, 14, WS_TABSTOP
+ AUTORADIOBUTTON "D&ua klik untuk membuka butir (satu klik untuk pilih)", IDC_FOLDER_OPTIONS_DOUBLECLICK, 40, 156, 210, 10
+ AUTORADIOBUTTON "Garis bawahi judul ikon sesuai dengan &browser saya", IDC_FOLDER_OPTIONS_ULBROWSER, 50, 132, 200, 10, WS_TABSTOP | WS_GROUP
+ AUTORADIOBUTTON "Garis bawahi judul ikon hanya saat m&engarahkan kursor", IDC_FOLDER_OPTIONS_ULPOINT, 50, 144, 200, 10


Cc @reactos/lang-indonesian

@reactos/lang-indonesian approve this. please ship

HBelusca · 2024-05-09T14:06:06Z

dll/win32/shell32/lang/hu-HU.rc

 PUSHBUTTON "&Törlés", IDC_FILETYPES_DELETE, 200, 123, 55, 14, WS_TABSTOP
 GROUPBOX "'%s' kiterjesztés részletei", IDC_FILETYPES_DETAILS_GROUPBOX, 7, 143, 249, 70
 LTEXT "Megnyitás ezzel:", -1, 12, 153, 55, 10
 CONTROL "", IDC_FILETYPES_ICON, "STATIC", SS_BITMAP | SS_REALSIZEIMAGE, 85, 153, 10, 10
 LTEXT "", IDC_FILETYPES_APPNAME, 100, 153, 80, 10
 PUSHBUTTON "&Módosítás...", IDC_FILETYPES_CHANGE, 200, 153, 50, 14, WS_TABSTOP
 LTEXT "", IDC_FILETYPES_DESCRIPTION, 12, 168, 160, 40
- PUSHBUTTON "&Haladó", IDC_FILETYPES_ADVANCED, 200, 188, 50, 14, WS_TABSTOP
+ PUSHBUTTON "&Haladó", IDC_FILETYPES_ADVANCED, 200, 188, 50, 14, WS_TABSTOP //FIXME: accelerator collision &H


Suggested change

PUSHBUTTON "&Haladó", IDC_FILETYPES_ADVANCED, 200, 188, 50, 14, WS_TABSTOP //FIXME: accelerator collision &H

PUSHBUTTON "Ha&ladó", IDC_FILETYPES_ADVANCED, 200, 188, 50, 14, WS_TABSTOP

An example where this accelerator is used:
https://git.reactos.org/?p=reactos.git&a=search&h=HEAD&st=grep&s=Ha%26lad

Otherwise, put it on the first "a" , like here:
https://git.reactos.org/?p=reactos.git&a=search&h=HEAD&st=grep&s=H%26alad

No, you don't have any hu-HU Windows at hand. Either someone who does have one will give me the accelerator, or I will place the FIXME there instead in master head.

dll/win32/shell32/lang/bg-BG.rc

HBelusca · 2024-05-09T14:09:40Z

dll/win32/shell32/lang/cs-CZ.rc

 MENUITEM "&Seznam", FCIDM_SHVIEW_LISTVIEW
 MENUITEM "&Podrobnosti", FCIDM_SHVIEW_REPORTVIEW
 MENUITEM "", -1, MFT_SEPARATOR
- POPUP "Seřadit &ikony", FCIDM_SHVIEW_ARRANGE
+ POPUP "Seřadit &ikony", FCIDM_SHVIEW_ARRANGE //FIXME: accelerator collision &I


A suggestion would be to put the accelerator on the "e" of Seradit.

I know, but I will leave that to the native speakers, unless you would know exactly where it has to be placed for czech.

dll/win32/shell32/lang/fr-FR.rc

Co-authored-by: Hermès BÉLUSCA - MAÏTO <[email protected]>

dll/win32/shell32/lang/bg-BG.rc

dll/win32/shell32/lang/fr-FR.rc

Co-authored-by: Hermès BÉLUSCA - MAÏTO <[email protected]>

…-only-dlg.

…ctos into rfb/shell32_rcfixmes

…ecially none that would collide with "Ja till &alla"

…rect. No surprise. Thx to Hermes for additional confirmation on Windows. So only 0.4.15-dev was poor here.

…ince I touched that specific line anyway, let's get rid of the WS_TABSTOP as well. Please don't notify me about the neighbor lines TABSTOPs. I REALLY DON'T CARE WITHIN THIS COMMIT!

HBelusca

Except for the portuguese string changes, the rest of the changes look reasonable.

dll/win32/shell32/lang/pt-PT.rc

zecarlos1957

sugested changes on line 425
Sublinhar títulos de ícones consistentes com meu &navegador

sugested changes on line 426 that improves the translation
Sublinhar títulos de ícones sómente quando a&pontados

dll/win32/shell32/lang/pt-PT.rc

JoachimHenze · 2024-05-11T21:01:54Z

@zecarlos1957 Thank you for the good translation for line 425.

But the translation for 426 is not good yet, because the suggested accelerator
Sublinhar títulos de ícones sómente quando a&pontados
collides with the following line in the same dlg:
Mostrar tarefas comuns nas &pastas

Can you double-check both accelerators please in your pt-PT windows?
Can I stick with my &apontados ?

…los1957, he confirmed in chat that keeping "my" &a accelerator is the correct thing to do for the 2nd line. Thx.

zecarlos1957

Thankyou very much

…ast commit we can now finally remove that ugly hack for pt-PT.rc which made the 3 dialogs larger in x just to fit that damn string within. Now finally the 3 dlgs have the same size as en-US again and therefore do leave more space for the dynamic content in the 3rd dialog. That is a great win! I will attach the 3 pics in the PR!

JoachimHenze · 2024-05-11T23:05:21Z

[SHELL32] pt-PT.rc HOORAY: Thanks to the shortened strings from the last commit we can now finally remove that ugly hack for pt-PT.rc which made the 3 dialogs larger in x just to fit that damn string within. Now finally the 3 dlgs have the same size as en-US again and therefore do leave more space for the dynamic content in the 3rd dialog. That is a great win! I will attach the 3 pics in the PR!

After pics:

Borat says: GREAT SUCCESS!

…t truncate here, double-checked.

…w it's done in general

…ave the same title. May help with string-pooling later in a far distant future

zecarlos1957

&Seleccionar

zecarlos1957 · 2024-05-21T22:21:11Z

dll/win32/shell32/lang/pt-PT.rc

 MENUITEM "&Copiar\tCtrl+C", FCIDM_SHVIEW_COPY
 MENUITEM "Co&lar\tCtrl+V", FCIDM_SHVIEW_INSERT
 MENUITEM "Colar &atalho", FCIDM_SHVIEW_INSERTLINK
 MENUITEM SEPARATOR
 MENUITEM "Copiar &pasta...", FCIDM_SHVIEW_COPYTO
 MENUITEM "Mo&ver para pasta...", FCIDM_SHVIEW_MOVETO
 MENUITEM SEPARATOR
- MENUITEM "Seleccionar &tudo\tCtrl+A", FCIDM_SHVIEW_SELECTALL
+ MENUITEM "Seleccionar &tudo\tCtrl+A", FCIDM_SHVIEW_SELECTALL //FIXME: accelerator collision &T


&Seleccionar seems to me a good option on line 57

Sounds good to me, but please open a follow-up-PR, I am almost done with the backmerge now (already at 0.4.7) and I don't want to reiterate again from the start.

Ports back: partially 0.4.15-dev-8109-g d7be748 [SHELL32] RC: Fix some FIXMEs (#6861), leaving out the comments 0.4.15-dev-8106-g a549a9d [SHELL32] ro-RO.rc Improvement (#6844) 0.4.15-dev-8021-g 7ce96fd [SHELL32] Fix keyboard navigation in file deletion dialog CORE-19564 (#6833) partially 0.4.15-dev-7877-g e85ef79 [SHELL32] Update Romanian (ro-RO) translation (PR6657) 0.4.15-dev-7842-g 558ab78 [SHELL32] *.rc: Strip all unneeded WS_DISABLED in dlg style (#6675) 0.4.15-dev-7834-g 00c4b3d [SHELL32] *.rc: Anonymize the "LIST2" control in IDD_AUTOPLAY1 (#6672) 0.4.15-dev-7260-g 1061ed4 [SHELL32] *.rc 640x480-ify IDD_FOLDER_OPTIONS_* (#6165) CORE-1762 0.4.15-dev-3170-g e34a799 [BOOTDATA] Fix "DllName" casing. This backport focuses mainly on porting back the updates dimensions for folder-options-dlgs. Delete FCIDM_SHVIEW_COPYTO & FCIDM_SHVIEW_MOVETO (fixes accelerator collisions in es-ES) and IDS_ADVANCED_NET_CRAWLER & IDS_ADVANCED_WEB_VIEW_BARRICADE and IDS_EFI_FILE because all of that is unimplemented in the older versions, and I do not intend to port any of that back ever. Binary size of shell32.dll shrinks for all branches: shell32.dll master RosBEWin2.2.2 GCC8.4.0 dbg x86 10.631.168 (0.4.15-dev-8027-g565a4b3) shell32.dll releases/0.4.14 RosBEWin2.2.2 GCC8.4.0 dbg x86 9.201.664 -> 9.188.352 shell32.dll releases/0.4.14 RosBEWin2.1.6 GCC4.7.2 dbg x86 9.230.336 -> 9.216.512 shell32.dll releases/0.4.13 RosBEWin2.1.6 GCC4.7.2 dbg x86 9.086.976 -> 9.073.664 shell32.dll releases/0.4.12 RosBEWin2.1.6 GCC4.7.2 dbg x86 9.031.680 -> 9.018.368 shell32.dll releases/0.4.11 RosBEWin2.1.6 GCC4.7.2 dbg x86 8.954.880 -> 8.942.592 shell32.dll releases/0.4.10 RosBEWin2.1.6 GCC4.7.2 dbg x86 8.945.152 -> 8.932.352 shell32.dll releases/0.4. 9 RosBEWin2.1.6 GCC4.7.2 dbg x86 8.618.496 -> 8.607.744 shell32.dll releases/0.4. 8 RosBEWin2.1.6 GCC4.7.2 dbg x86 8.536.576 -> 8.528.896 shell32.dll releases/0.4. 7 RosBEWin2.1.6 GCC4.7.2 dbg x86 8.466.944 -> 8.459.776

Ports back: partially 0.4.15-dev-8109-g d7be748 [SHELL32] RC: Fix some FIXMEs (#6861), leaving out the comments 0.4.15-dev-8106-g a549a9d [SHELL32] ro-RO.rc Improvement (#6844) 0.4.15-dev-8021-g 7ce96fd [SHELL32] Fix keyboard navigation in file deletion dialog CORE-19564 (#6833) partially 0.4.15-dev-7877-g e85ef79 [SHELL32] Update Romanian (ro-RO) translation (PR6657) 0.4.15-dev-7842-g 558ab78 [SHELL32] *.rc: Strip all unneeded WS_DISABLED in dlg style (#6675) 0.4.15-dev-7834-g 00c4b3d [SHELL32] *.rc: Anonymize the "LIST2" control in IDD_AUTOPLAY1 (#6672) 0.4.15-dev-7260-g 1061ed4 [SHELL32] *.rc 640x480-ify IDD_FOLDER_OPTIONS_* (#6165) CORE-1762 0.4.15-dev-3170-g e34a799 [BOOTDATA] Fix "DllName" casing. 0.4.14-dev-1487-g c0d5e4f [SHELL32] CORE-16895 RC IDD_FOLDER_OPTIONS_FILETYPES All langs 0.4.14-dev-69-g 5d7ae44 [SHELL32] Demote an ERR to WARN (which was a tiny part of PR1907) which actually started to spam with zipfldr-introducation already This backport focuses mainly on porting back the updates dimensions for folder-options-dlgs. Delete FCIDM_SHVIEW_COPYTO & FCIDM_SHVIEW_MOVETO (fixes accelerator collisions in es-ES) and IDS_ADVANCED_NET_CRAWLER & IDS_ADVANCED_WEB_VIEW_BARRICADE and IDS_EFI_FILE because all of that is unimplemented in the older versions, and I do not intend to port any of that back ever. Binary size of shell32.dll shrinks for all branches: shell32.dll master RosBEWin2.2.2 GCC8.4.0 dbg x86 10.631.168 (0.4.15-dev-8027-g565a4b3) shell32.dll releases/0.4.14 RosBEWin2.2.2 GCC8.4.0 dbg x86 9.201.664 -> 9.188.352 shell32.dll releases/0.4.14 RosBEWin2.1.6 GCC4.7.2 dbg x86 9.230.336 -> 9.216.512 shell32.dll releases/0.4.13 RosBEWin2.1.6 GCC4.7.2 dbg x86 9.086.976 -> 9.073.664 shell32.dll releases/0.4.12 RosBEWin2.1.6 GCC4.7.2 dbg x86 9.031.680 -> 9.018.368 shell32.dll releases/0.4.11 RosBEWin2.1.6 GCC4.7.2 dbg x86 8.954.880 -> 8.942.592 shell32.dll releases/0.4.10 RosBEWin2.1.6 GCC4.7.2 dbg x86 8.945.152 -> 8.932.352 shell32.dll releases/0.4. 9 RosBEWin2.1.6 GCC4.7.2 dbg x86 8.618.496 -> 8.607.744 shell32.dll releases/0.4. 8 RosBEWin2.1.6 GCC4.7.2 dbg x86 8.536.576 -> 8.528.896 shell32.dll releases/0.4. 7 RosBEWin2.1.6 GCC4.7.2 dbg x86 8.466.944 -> 8.459.776

Ports back: partially 0.4.15-dev-8109-g d7be748 [SHELL32] RC: Fix some FIXMEs (#6861), leaving out the comments 0.4.15-dev-8106-g a549a9d [SHELL32] ro-RO.rc Improvement (#6844) 0.4.15-dev-8021-g 7ce96fd [SHELL32] Fix keyboard navigation in file deletion dialog CORE-19564 (#6833) partially 0.4.15-dev-7877-g e85ef79 [SHELL32] Update Romanian (ro-RO) translation (PR6657) 0.4.15-dev-7842-g 558ab78 [SHELL32] *.rc: Strip all unneeded WS_DISABLED in dlg style (#6675) 0.4.15-dev-7834-g 00c4b3d [SHELL32] *.rc: Anonymize the "LIST2" control in IDD_AUTOPLAY1 (#6672) 0.4.15-dev-7260-g 1061ed4 [SHELL32] *.rc 640x480-ify IDD_FOLDER_OPTIONS_* (#6165) CORE-1762 0.4.15-dev-3170-g e34a799 [BOOTDATA] Fix "DllName" casing. 0.4.14-dev-1487-g c0d5e4f [SHELL32] CORE-16895 RC IDD_FOLDER_OPTIONS_FILETYPES All langs 0.4.14-dev-69-g 5d7ae44 [SHELL32] Demote an ERR to WARN (which was a tiny part of PR1907) which actually started to spam with zipfldr-introducation already partially 0.4.13-dev-623-g 019e3ff [SHELL32] Recycle-Bin only rc-part LVS_SHOWSELALWAYS (part of PR1688, part of CORE12313) 0.4.13-dev-25-g 3b7f710 [BOOTDATA] Remove stray value. ("MS Shell Dlg") This backport focuses mainly on porting back the updates dimensions for folder-options-dlgs. Delete FCIDM_SHVIEW_COPYTO & FCIDM_SHVIEW_MOVETO (fixes accelerator collisions in es-ES) and IDS_ADVANCED_NET_CRAWLER & IDS_ADVANCED_WEB_VIEW_BARRICADE and IDS_EFI_FILE because all of that is unimplemented in the older versions, and I do not intend to port any of that back ever. Binary size of shell32.dll shrinks for all branches: shell32.dll master RosBEWin2.2.2 GCC8.4.0 dbg x86 10.631.168 (0.4.15-dev-8027-g565a4b3) shell32.dll releases/0.4.14 RosBEWin2.2.2 GCC8.4.0 dbg x86 9.201.664 -> 9.188.352 shell32.dll releases/0.4.14 RosBEWin2.1.6 GCC4.7.2 dbg x86 9.230.336 -> 9.216.512 shell32.dll releases/0.4.13 RosBEWin2.1.6 GCC4.7.2 dbg x86 9.086.976 -> 9.073.664 shell32.dll releases/0.4.12 RosBEWin2.1.6 GCC4.7.2 dbg x86 9.031.680 -> 9.018.368 shell32.dll releases/0.4.11 RosBEWin2.1.6 GCC4.7.2 dbg x86 8.954.880 -> 8.942.592 shell32.dll releases/0.4.10 RosBEWin2.1.6 GCC4.7.2 dbg x86 8.945.152 -> 8.932.352 shell32.dll releases/0.4. 9 RosBEWin2.1.6 GCC4.7.2 dbg x86 8.618.496 -> 8.607.744 shell32.dll releases/0.4. 8 RosBEWin2.1.6 GCC4.7.2 dbg x86 8.536.576 -> 8.528.896 shell32.dll releases/0.4. 7 RosBEWin2.1.6 GCC4.7.2 dbg x86 8.466.944 -> 8.459.776

Ports back: partially 0.4.15-dev-8109-g d7be748 [SHELL32] RC: Fix some FIXMEs (#6861), leaving out the comments 0.4.15-dev-8106-g a549a9d [SHELL32] ro-RO.rc Improvement (#6844) 0.4.15-dev-8021-g 7ce96fd [SHELL32] Fix keyboard navigation in file deletion dialog CORE-19564 (#6833) partially 0.4.15-dev-7877-g e85ef79 [SHELL32] Update Romanian (ro-RO) translation (PR6657) 0.4.15-dev-7842-g 558ab78 [SHELL32] *.rc: Strip all unneeded WS_DISABLED in dlg style (#6675) 0.4.15-dev-7834-g 00c4b3d [SHELL32] *.rc: Anonymize the "LIST2" control in IDD_AUTOPLAY1 (#6672) 0.4.15-dev-7260-g 1061ed4 [SHELL32] *.rc 640x480-ify IDD_FOLDER_OPTIONS_* (#6165) CORE-1762 0.4.15-dev-3170-g e34a799 [BOOTDATA] Fix "DllName" casing. 0.4.14-dev-1487-g c0d5e4f [SHELL32] CORE-16895 RC IDD_FOLDER_OPTIONS_FILETYPES All langs 0.4.14-dev-69-g 5d7ae44 [SHELL32] Demote an ERR to WARN (which was a tiny part of PR1907) which actually started to spam with zipfldr-introducation already partially 0.4.13-dev-623-g 019e3ff [SHELL32] Recycle-Bin only rc-part LVS_SHOWSELALWAYS (part of PR1688, part of CORE12313) 0.4.13-dev-25-g 3b7f710 [BOOTDATA] Remove stray value. ("MS Shell Dlg") 0.4.10-dev-253-g 1b1e1ba [SHELL32] Implement Folder Options File Types 'Change' button, part of (#629), part of CORE-12906 This backport focuses mainly on porting back the updates dimensions for folder-options-dlgs. This allows a rudimentary form of 'Delete' and 'Change' button in folder-properties/filetypes for 0.4.9/0.4.8/0.4.7 (instead of throwing an exception when clicking the 'change'-button) For now I did not port back the dlgs reachable by the 'New'-button and the 'Advanced'-button into older branches, because those implementations are rather complex. For now I did not port back the displaying of the icon / displaying of the associated application into older branches, because their current implementation (in 0.4.10 and higher) does slow down the filetypes-dialog dramatically. Delete FCIDM_SHVIEW_COPYTO & FCIDM_SHVIEW_MOVETO (fixes accelerator collisions in es-ES) and IDS_ADVANCED_NET_CRAWLER & IDS_ADVANCED_WEB_VIEW_BARRICADE and IDS_EFI_FILE because all of that is unimplemented in the older versions, and I do not intend to port any of that back ever. Binary size of shell32.dll shrinks for all branches: shell32.dll master RosBEWin2.2.2 GCC8.4.0 dbg x86 10.631.168 (0.4.15-dev-8027-g565a4b3) shell32.dll releases/0.4.14 RosBEWin2.2.2 GCC8.4.0 dbg x86 9.201.664 -> 9.188.352 shell32.dll releases/0.4.14 RosBEWin2.1.6 GCC4.7.2 dbg x86 9.230.336 -> 9.216.512 shell32.dll releases/0.4.13 RosBEWin2.1.6 GCC4.7.2 dbg x86 9.086.976 -> 9.073.664 shell32.dll releases/0.4.12 RosBEWin2.1.6 GCC4.7.2 dbg x86 9.031.680 -> 9.018.368 shell32.dll releases/0.4.11 RosBEWin2.1.6 GCC4.7.2 dbg x86 8.954.880 -> 8.942.592 shell32.dll releases/0.4.10 RosBEWin2.1.6 GCC4.7.2 dbg x86 8.945.152 -> 8.932.352 shell32.dll releases/0.4. 9 RosBEWin2.1.6 GCC4.7.2 dbg x86 8.618.496 -> 8.607.744 shell32.dll releases/0.4. 8 RosBEWin2.1.6 GCC4.7.2 dbg x86 8.536.576 -> 8.528.896 shell32.dll releases/0.4. 7 RosBEWin2.1.6 GCC4.7.2 dbg x86 8.466.944 -> 8.459.776

Ports back: partially 0.4.15-dev-8109-g d7be748 [SHELL32] RC: Fix some FIXMEs (#6861), leaving out the comments 0.4.15-dev-8106-g a549a9d [SHELL32] ro-RO.rc Improvement (#6844) 0.4.15-dev-8021-g 7ce96fd [SHELL32] Fix keyboard navigation in file deletion dialog CORE-19564 (#6833) partially 0.4.15-dev-7877-g e85ef79 [SHELL32] Update Romanian (ro-RO) translation (PR6657) 0.4.15-dev-7842-g 558ab78 [SHELL32] *.rc: Strip all unneeded WS_DISABLED in dlg style (#6675) 0.4.15-dev-7834-g 00c4b3d [SHELL32] *.rc: Anonymize the "LIST2" control in IDD_AUTOPLAY1 (#6672) 0.4.15-dev-7260-g 1061ed4 [SHELL32] *.rc 640x480-ify IDD_FOLDER_OPTIONS_* (#6165) CORE-1762 0.4.15-dev-3170-g e34a799 [BOOTDATA] Fix "DllName" casing. 0.4.14-dev-1487-g c0d5e4f [SHELL32] CORE-16895 RC IDD_FOLDER_OPTIONS_FILETYPES All langs 0.4.14-dev-69-g 5d7ae44 [SHELL32] Demote an ERR to WARN (which was a tiny part of PR1907) which actually started to spam with zipfldr-introducation already partially 0.4.13-dev-623-g 019e3ff [SHELL32] Recycle-Bin only rc-part LVS_SHOWSELALWAYS (part of PR1688, part of CORE12313) 0.4.13-dev-25-g 3b7f710 [BOOTDATA] Remove stray value. ("MS Shell Dlg") 0.4.10-dev-253-g 1b1e1ba [SHELL32] Implement Folder Options File Types 'Change' button, part of (#629), part of CORE-12906 partially 0.4.9-dev-874-g 82a5983 [SHELL32] Allow deleting a file type/extension (#553), part of CORE-12906 (without the confirmation dialog) This backport focuses mainly on porting back the updates dimensions for folder-options-dlgs. This allows a rudimentary form of 'Delete' and 'Change' button in folder-properties/filetypes for 0.4.9/0.4.8/0.4.7 (instead of throwing an exception when clicking the 'change'-button) For now I did not port back the dlgs reachable by the 'New'-button and the 'Advanced'-button into older branches, because those implementations are rather complex. For now I did not port back the displaying of the icon / displaying of the associated application into older branches, because their current implementation (in 0.4.10 and higher) does slow down the filetypes-dialog dramatically. Delete FCIDM_SHVIEW_COPYTO & FCIDM_SHVIEW_MOVETO (fixes accelerator collisions in es-ES) and IDS_ADVANCED_NET_CRAWLER & IDS_ADVANCED_WEB_VIEW_BARRICADE because all of that is unimplemented in the older versions, and I do not intend to port any of that back ever. Binary size of shell32.dll shrinks for all branches: shell32.dll master RosBEWin2.2.2 GCC8.4.0 dbg x86 10.631.168 (0.4.15-dev-8027-g565a4b3) shell32.dll releases/0.4.14 RosBEWin2.2.2 GCC8.4.0 dbg x86 9.201.664 -> 9.188.352 shell32.dll releases/0.4.14 RosBEWin2.1.6 GCC4.7.2 dbg x86 9.230.336 -> 9.216.512 shell32.dll releases/0.4.13 RosBEWin2.1.6 GCC4.7.2 dbg x86 9.086.976 -> 9.073.664 shell32.dll releases/0.4.12 RosBEWin2.1.6 GCC4.7.2 dbg x86 9.031.680 -> 9.018.368 shell32.dll releases/0.4.11 RosBEWin2.1.6 GCC4.7.2 dbg x86 8.954.880 -> 8.942.592 shell32.dll releases/0.4.10 RosBEWin2.1.6 GCC4.7.2 dbg x86 8.945.152 -> 8.932.352 shell32.dll releases/0.4. 9 RosBEWin2.1.6 GCC4.7.2 dbg x86 8.618.496 -> 8.607.744 shell32.dll releases/0.4. 8 RosBEWin2.1.6 GCC4.7.2 dbg x86 8.536.576 -> 8.528.896 shell32.dll releases/0.4. 7 RosBEWin2.1.6 GCC4.7.2 dbg x86 8.466.944 -> 8.459.776

JoachimHenze requested a review from HBelusca May 9, 2024 13:18

JoachimHenze requested review from learn-more and yagoulas as code owners May 9, 2024 13:18

[SHELL32] RC: Fix some FIXMEs, add others

0e16700

- fixes the last text truncations we had in IDD_FOLDER_OPTIONS_GENERAL - small tweaks otherwhere - add some FIXMEs

github-actions bot added the shell All PR's related to the shell (and shell extensions) label May 9, 2024

HBelusca reviewed May 9, 2024

View reviewed changes

JoachimHenze and others added 2 commits May 9, 2024 17:15

fr-FR.rc accelerators provided by Hermes (native speaker)

4188aa5

Co-authored-by: Hermès BÉLUSCA - MAÏTO <[email protected]>

french &P from Hermes can be trusted.

0f1f0e3

Co-authored-by: Hermès BÉLUSCA - MAÏTO <[email protected]>

JoachimHenze commented May 9, 2024

View reviewed changes

dll/win32/shell32/lang/bg-BG.rc Outdated Show resolved Hide resolved

bg-BG.rc Apply winterhells suggestion. Thank you.

b150d26

JoachimHenze commented May 9, 2024

View reviewed changes

dll/win32/shell32/lang/fr-FR.rc Outdated Show resolved Hide resolved

JoachimHenze and others added 9 commits May 9, 2024 17:29

fr-FR.rc: Strip superfluous FIXME

43a908b

pt-PT.rc the 3 suspected dots confirmed by Hermes

425954a

Co-authored-by: Hermès BÉLUSCA - MAÏTO <[email protected]>

fr-FR.rc: Strip Hermes' unloved french 's'. It's within a 0.4.15-dev'…

370f80e

…-only-dlg.

Merge branch 'rfb/shell32_rcfixmes' of https://github.com/reactos/rea…

32f62a4

…ctos into rfb/shell32_rcfixmes

sv-SE.rc: IDCANCEL "&Avbryt" should not have an accelerator here, esp…

e4219dc

…ecially none that would collide with "Ja till &alla"

uk-UA.rc: no accelerator for this IDCANCEL

a1f9bbf

fr-FR.rc: Like I thought, it is "A&vancé". So releases/0.4.14 was cor…

0c6837e

…rect. No surprise. Thx to Hermes for additional confirmation on Windows. So only 0.4.15-dev was poor here.

zh-CN.rc & zh-TW.rc: no accelerator at this IDCANCEL

7c1a80d

*.rc: Strip that accelerator everywhere where it still existed, and s…

518a44c

…ince I touched that specific line anyway, let's get rid of the WS_TABSTOP as well. Please don't notify me about the neighbor lines TABSTOPs. I REALLY DON'T CARE WITHIN THIS COMMIT!

HBelusca reviewed May 10, 2024

View reviewed changes

zecarlos1957 reviewed May 10, 2024

View reviewed changes

dll/win32/shell32/lang/pt-PT.rc Show resolved Hide resolved

zecarlos1957 suggested changes May 10, 2024

View reviewed changes

dll/win32/shell32/lang/pt-PT.rc Outdated Show resolved Hide resolved

zecarlos1957 suggested changes May 10, 2024

View reviewed changes

dll/win32/shell32/lang/pt-PT.rc Outdated Show resolved Hide resolved

binarymaster added the trivial fix For trivial changes. label May 11, 2024

[SHELL32] pt-PT.rc: Apply the 2 suggestions from native speaker zecar…

35336af

…los1957, he confirmed in chat that keeping "my" &a accelerator is the correct thing to do for the 2nd line. Thx.

zecarlos1957 approved these changes May 11, 2024

View reviewed changes

JoachimHenze removed the trivial fix For trivial changes. label May 11, 2024

HBelusca approved these changes May 12, 2024

View reviewed changes

JoachimHenze added 4 commits May 12, 2024 18:24

pl-PL.rc: we can sync that back to en-US and most other langs. Doesn'…

48d24a0

…t truncate here, double-checked.

sv-SE.rc: other langs do use max 4 spaces here

1d2c569

ja-JP.rc: Strip 2 spaces for consistency to neighbor-ctrls, and to ho…

a5bf510

…w it's done in general

pt-PT.rc: Capitalization harmonization with its neighbor-dlgs which h…

d5c5c27

…ave the same title. May help with string-pooling later in a far distant future

JoachimHenze self-assigned this May 20, 2024

JoachimHenze added 2 commits May 20, 2024 22:38

sq-AL.rc: add a FIXME as homework for the native speakers

30e17f7

pt-PT.rc: add another FIXME for accelerator collision &T

41f9de8

zecarlos1957 reviewed May 21, 2024

View reviewed changes

JoachimHenze added 2 commits May 22, 2024 01:46

sv-SE.rc: Add 10 accelerator FIXMEs/TODOs. And ABBA sings... "Mama mia!"

e0251ef

typo-fix in my comment

f6d132e

JoachimHenze merged commit d7be748 into master May 22, 2024
59 of 71 checks passed

JoachimHenze deleted the rfb/shell32_rcfixmes branch May 22, 2024 02:29

binarymaster mentioned this pull request May 23, 2024

[SHELL32] Fix accelerator collision in Portuguese (pt-PT) translation #6927

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[SHELL32] RC: Fix some FIXMEs, add others #6861

[SHELL32] RC: Fix some FIXMEs, add others #6861

JoachimHenze commented May 9, 2024

HBelusca May 9, 2024

JoachimHenze May 9, 2024

HBelusca May 9, 2024

Mas4hmad May 20, 2024

HBelusca May 9, 2024

JoachimHenze May 9, 2024

HBelusca May 9, 2024

JoachimHenze May 9, 2024

HBelusca left a comment •

edited

zecarlos1957 left a comment •

edited

JoachimHenze commented May 11, 2024

zecarlos1957 left a comment

JoachimHenze commented May 11, 2024

zecarlos1957 left a comment

zecarlos1957 May 21, 2024

JoachimHenze May 21, 2024

	PUSHBUTTON "&Haladó", IDC_FILETYPES_ADVANCED, 200, 188, 50, 14, WS_TABSTOP //FIXME: accelerator collision &H
	PUSHBUTTON "Ha&ladó", IDC_FILETYPES_ADVANCED, 200, 188, 50, 14, WS_TABSTOP

[SHELL32] RC: Fix some FIXMEs, add others #6861

[SHELL32] RC: Fix some FIXMEs, add others #6861

Conversation

JoachimHenze commented May 9, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

HBelusca left a comment • edited

Choose a reason for hiding this comment

zecarlos1957 left a comment • edited

Choose a reason for hiding this comment

JoachimHenze commented May 11, 2024

zecarlos1957 left a comment

Choose a reason for hiding this comment

JoachimHenze commented May 11, 2024

zecarlos1957 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

HBelusca left a comment •

edited

zecarlos1957 left a comment •

edited