Always use block/blockLast/verify with timeout

[violetagg]

No description provided.

[violetagg]

Failed tests on CI are not related

[pderop]

There are still some block/blockLast/verify methods which have not been updated with a Duration, is it intentional ?
for examples, see in

• https://github.com/reactor/reactor-netty/blob/1.0.x/reactor-netty-core/src/test/java/reactor/netty/channel/MonoSendManyTest.java#L159
• https://github.com/reactor/reactor-netty/blob/1.0.x/reactor-netty-core/src/test/java/reactor/netty/tcp/TcpResourcesTest.java#L143
• there are 45 calls to .bock() in https://github.com/reactor/reactor-netty/blob/1.0.x/reactor-netty-http/src/test/java/reactor/netty/http/client/Http2PoolTest.java
• https://github.com/reactor/reactor-netty/blob/1.0.x/reactor-netty-http/src/test/java/reactor/netty/http/client/HttpClientTest.java#L825
• https://github.com/reactor/reactor-netty/blob/1.0.x/reactor-netty-http/src/test/java/reactor/netty/http/client/WebsocketTest.java#L183
• https://github.com/reactor/reactor-netty/blob/1.0.x/reactor-netty-http/src/test/java/reactor/netty/http/client/WebsocketTest.java#L270
• https://github.com/reactor/reactor-netty/blob/1.0.x/reactor-netty-http/src/test/java/reactor/netty/http/client/WebsocketTest.java#L581
• https://github.com/reactor/reactor-netty/blob/1.0.x/reactor-netty-http/src/test/java/reactor/netty/http/server/HttpServerTests.java#L490
• https://github.com/reactor/reactor-netty/blob/1.0.x/reactor-netty-http/src/test/java/reactor/netty/http/server/HttpServerTests.java#L1284
• https://github.com/reactor/reactor-netty/blob/1.0.x/reactor-netty-http/src/test/java/reactor/netty/http/server/HttpServerTests.java#L2604
• https://github.com/reactor/reactor-netty/blob/1.0.x/reactor-netty-http/src/test/java/reactor/netty/http/HttpOperationsTest.java#L142

[violetagg]

There are still some block/blockLast/verify methods which have not been updated with a Duration, is it intentional ? for examples, see in

• https://github.com/reactor/reactor-netty/blob/1.0.x/reactor-netty-core/src/test/java/reactor/netty/channel/MonoSendManyTest.java#L159

Fixed.

• https://github.com/reactor/reactor-netty/blob/1.0.x/reactor-netty-core/src/test/java/reactor/netty/tcp/TcpResourcesTest.java#L143

Fixed.

• there are 45 calls to .bock() in https://github.com/reactor/reactor-netty/blob/1.0.x/reactor-netty-http/src/test/java/reactor/netty/http/client/Http2PoolTest.java

Fixed.

• https://github.com/reactor/reactor-netty/blob/1.0.x/reactor-netty-http/src/test/java/reactor/netty/http/client/HttpClientTest.java#L825

reactor-netty/reactor-netty-http/src/test/java/reactor/netty/http/client/HttpClientTest.java

Lines 821 to 825 in ce2b98a

	List<String> expected =
	Flux.range(1, 20)
	.map(v -> "test")
	.collectList()
	.block();

Flux is already defined with concrete values. I don't think there will be an endless waiting.

• https://github.com/reactor/reactor-netty/blob/1.0.x/reactor-netty-http/src/test/java/reactor/netty/http/client/WebsocketTest.java#L183

reactor-netty/reactor-netty-http/src/test/java/reactor/netty/http/client/WebsocketTest.java

Lines 179 to 183 in ce2b98a

	List<String> expected =
	Flux.range(1, c)
	.map(v -> "test")
	.collectList()
	.block();

Flux is already defined with concrete values. I don't think there will be an endless waiting.

• https://github.com/reactor/reactor-netty/blob/1.0.x/reactor-netty-http/src/test/java/reactor/netty/http/client/WebsocketTest.java#L270

reactor-netty/reactor-netty-http/src/test/java/reactor/netty/http/client/WebsocketTest.java

Lines 266 to 270 in ce2b98a

	List<String> expected =
	Flux.range(1, c)
	.map(v -> "test")
	.collectList()
	.block();

Flux is already defined with concrete values. I don't think there will be an endless waiting.

• https://github.com/reactor/reactor-netty/blob/1.0.x/reactor-netty-http/src/test/java/reactor/netty/http/client/WebsocketTest.java#L581

reactor-netty/reactor-netty-http/src/test/java/reactor/netty/http/client/WebsocketTest.java

Lines 577 to 581 in ce2b98a

	List<String> expected =
	Flux.range(1, 20)
	.map(v -> "test")
	.collectList()
	.block();

Flux is already defined with concrete values. I don't think there will be an endless waiting.

• https://github.com/reactor/reactor-netty/blob/1.0.x/reactor-netty-http/src/test/java/reactor/netty/http/server/HttpServerTests.java#L490

reactor-netty/reactor-netty-http/src/test/java/reactor/netty/http/server/HttpServerTests.java

Lines 486 to 490 in ce2b98a

	Flux<String> flux = Flux.range(0, 100)
	.map(n -> String.format("%010d", n));
	List<String> test =
	flux.collectList()
	.block();

flux is already defined with concrete values. I don't think there will be an endless waiting.

• https://github.com/reactor/reactor-netty/blob/1.0.x/reactor-netty-http/src/test/java/reactor/netty/http/server/HttpServerTests.java#L1284

reactor-netty/reactor-netty-http/src/test/java/reactor/netty/http/server/HttpServerTests.java

Lines 1275 to 1284 in ce2b98a

	Flux<String> flux = Flux.range(0, 100)
	.map(n -> String.format("%010d", n));
	AtomicReference<List<String>> receiver = new AtomicReference<>(new ArrayList<>());
	AtomicReference<WebSocketCloseStatus> statusServer = new AtomicReference<>();
	AtomicReference<WebSocketCloseStatus> statusClient = new AtomicReference<>();
	CountDownLatch latch = new CountDownLatch(3);
	List<String> test =
	flux.collectList()
	.block();

flux is already defined with concrete values. I don't think there will be an endless waiting.

• https://github.com/reactor/reactor-netty/blob/1.0.x/reactor-netty-http/src/test/java/reactor/netty/http/server/HttpServerTests.java#L2604

reactor-netty/reactor-netty-http/src/test/java/reactor/netty/http/server/HttpServerTests.java

Lines 2603 to 2604 in ce2b98a

	Mono.delay(Duration.ofMillis(500))
	.block();

A delay is known and then this will be completed. I don't think there will be an endless waiting.

• https://github.com/reactor/reactor-netty/blob/1.0.x/reactor-netty-http/src/test/java/reactor/netty/http/HttpOperationsTest.java#L142

reactor-netty/reactor-netty-http/src/test/java/reactor/netty/http/HttpOperationsTest.java

Lines 98 to 143 in ce2b98a

	void testPath() {
	TestHttpInfos infos = new TestHttpInfos();
	Flux<String> expectations = Flux.just("", "", "", "/", "a", "a", "", "a", "", "a", "a", "a b", "a");
	doTestPath(infos, expectations,
	Flux.just("http://localhost:8080",
	"http://localhost:8080/",
	"http://localhost:8080//",
	"http://localhost:8080///",
	"http://localhost:8080/a",
	"http://localhost:8080/a/",
	"http://localhost:8080/?b",
	"http://localhost:8080/a?b",
	"http://localhost:8080/#b",
	"http://localhost:8080/a#b",
	"http://localhost:8080/a?b#c",
	"http://localhost:8080/a%20b",
	"http://localhost:8080/a?b={}"));
	doTestPath(infos, expectations,
	Flux.just("localhost:8080",
	"localhost:8080/",
	"localhost:8080//",
	"localhost:8080///",
	"localhost:8080/a",
	"localhost:8080/a/",
	"localhost:8080/?b",
	"localhost:8080/a?b",
	"localhost:8080/#b",
	"localhost:8080/a#b",
	"localhost:8080/a?b#c",
	"localhost:8080/a%20b",
	"localhost:8080/a?b={}"));
	doTestPath(infos, expectations,
	Flux.just("", "/", "//", "///", "/a", "/a/", "/?b", "/a?b", "/#b", "/a#b", "/a?b#c", "/a%20b", "/a?b={}"));
	}
	private void doTestPath(TestHttpInfos infos, Flux<String> expectations, Flux<String> uris) {
	uris.zipWith(expectations)
	.doOnNext(tuple -> {
	infos.uri = tuple.getT1();
	assertThat(tuple.getT2()).isEqualTo(infos.path());
	})
	.blockLast();
	}

Flux<String> expectations and Flux<String> uris are already defined with concrete values. I don't think there will be an endless waiting.

[violetagg]

Failed tests on CI are not related

[violetagg]

@pderop Thanks!