Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix flaky DefaultPooledConnectionProviderTest#testDisposeInactivePoolsInBackground #3237

Merged
merged 2 commits into from
May 13, 2024
Merged

Fix flaky DefaultPooledConnectionProviderTest#testDisposeInactivePoolsInBackground #3237

merged 2 commits into from
May 13, 2024

Commits on May 9, 2024

  1. [test] Fix flaky DefaultPooledConnectionProviderTest#testDisposeInact… 

    …ivePoolsInBackground

There are random DefaultPooledConnectionProviderTest#testDisposeInactivePoolsInBackground failures

DefaultPooledConnectionProviderTest > testDisposeInactivePoolsInBackground(boolean, boolean, boolean) > [5] enableEvictInBackground=true, isHttp2=false, isBuiltInMetrics=false FAILED
    org.opentest4j.AssertionFailedError:
    expected: true
     but was: false
        at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method)
        at sun.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:62)
        at sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
        at reactor.netty.resources.DefaultPooledConnectionProviderTest.testDisposeInactivePoolsInBackground(DefaultPooledConnectionProviderTest.java:729)

DefaultPooledConnectionProviderTest > testDisposeInactivePoolsInBackground(boolean, boolean, boolean) > [8] enableEvictInBackground=true, isHttp2=true, isBuiltInMetrics=true FAILED
    org.opentest4j.AssertionFailedError:
    expected: null
     but was: io.micrometer.core.instrument.internal.DefaultGauge@78e01239
        at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method)
        at sun.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:62)
        at sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
        at reactor.netty.resources.DefaultPooledConnectionProviderTest.testDisposeInactivePoolsInBackground(DefaultPooledConnectionProviderTest.java:733)
    @violetagg
    violetagg committed May 9, 2024
    Configuration menu
    Copy the full SHA
    7620206 View commit details
    Browse the repository at this point in the history

  2. In addition to previous commit

    @violetagg
    violetagg committed May 9, 2024
    Configuration menu
    Copy the full SHA
    b93fe89 View commit details
    Browse the repository at this point in the history