Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync with react.dev @ 93177e6c #46

Merged
merged 14 commits into from
Apr 9, 2024
Merged

Sync with react.dev @ 93177e6c #46

merged 14 commits into from
Apr 9, 2024

Conversation

react-translations-bot
Copy link
Collaborator

This PR was automatically generated.

Merge changes from react.dev at 93177e6

DO NOT SQUASH MERGE THIS PULL REQUEST!

Doing so will "erase" the commits from main and cause them to show up as conflicts the next time we merge.

pavelsavva and others added 14 commits March 19, 2024 21:37
Co-authored-by: Sebastian Silbermann <[email protected]>
Co-authored-by: Allison Strandberg <[email protected]>
This example contains a list of person objects, but only the first 3 have id properties. This appears to be a mistake; in the next use of the list all 5 person objects have this property, but it is not changed as part of an instructive exercise.

This change makes the final two with objects consistent with the remainder of the list.
`an text area` -> `a text area`
`an discussion` -> `a discussion`
Noticed this randomly and couldn't unsee it, so here's a quick PR to
fix.
Copy link

github-actions bot commented Apr 8, 2024

Size changes

📦 Next.js Bundle Analysis for react-dev

This analysis was generated by the Next.js Bundle Analysis action. 🤖

Five Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load
/404 79.86 KB (-1 B) 183.76 KB
/500 79.86 KB (-1 B) 183.76 KB
/[[...markdownPath]] 81.64 KB (-1 B) 185.54 KB
/errors 80.04 KB (-1 B) 183.94 KB
/errors/[errorCode] 80.02 KB (-1 B) 183.91 KB
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 10% or more, there will be a red status indicator applied, indicating that special attention should be given to this.

@CarreraPHP CarreraPHP merged commit 8c090ad into main Apr 9, 2024
3 checks passed
@CarreraPHP CarreraPHP deleted the sync-93177e6c branch April 9, 2024 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.