Add Propshaft server rendering support #1345
Open
+358
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Server rendering currently raises an
undefined method '[]' for an instance of Propshaft::Assembly
error when using the Propshaft assets pipeline, since it assumes Sprockets is present.This PR adds a new
PropshaftContainer
adapter. According to the Propshaft documentation, this API works the same for both precompiled and dynamic assets.Pull Request checklist