Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update shouldCloseOnOverlayClick doc #1025

Merged
merged 1 commit into from
Feb 10, 2024

Conversation

jamesbechet
Copy link
Contributor

@jamesbechet jamesbechet commented Aug 8, 2023

Changes proposed:

  • updated documentation of the shouldCloseOnOverlayClick prop

Upgrade Path (for changed or removed APIs):

Acceptance Checklist:

  • The commit message follows the guidelines in CONTRIBUTING.md.
  • Documentation (README.md) and examples have been updated as needed.
  • If this is a code change, a spec testing the functionality has been added.
  • If the commit message has [changed] or [removed], there is an upgrade path above.

Copy link

@doeg doeg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jamesbechet!

@diasbruno a straightforward docs update for ya. :) Not sure if it needs a rebase to pick up the test fixes before merge.

@diasbruno diasbruno merged commit e4841d6 into reactjs:master Feb 10, 2024
1 check failed
@diasbruno
Copy link
Collaborator

Thanks, @jamesbechet for the PR. 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants