Change POCO type binding warning level to debug #3415 #3444
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The warning is deliberate. |
|
Warning is what we want in this case, better solution would be just to detect the case of the premade View's and add exemptions to them similar to what we do with winforms. |
|
Locking this PR, discussion can continue on #3415 thanks. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
This change changes POCO type binding warning level to debug
What is the current behavior?
Warning messages are at the warn level
What is the new behavior?
Warning messages are at the debug level
What might this PR break?
I don't think it should break anything, the same amount of tests passed before and after. The only thing changed is log messages, so it shouldn't harm anything
Other information:
Fulfils issue #3415