@all-contributors please add @Jharmony for add es translation and code #3041
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Big 4.0! Co-authored-by: Sara Federico <[email protected]> Co-authored-by: Paolo Mariotti <[email protected]> Co-authored-by: <[email protected]> Co-authored-by: Tan Nguyen <[email protected]> Co-authored-by: Jon Winn <[email protected]> Co-authored-by: paulogdm <[email protected]> Co-authored-by: Marcellin Nshimiyimana <[email protected]> Co-authored-by: Ryan Swart <[email protected]> Co-authored-by: Benedikt Franke <[email protected]> Co-authored-by: Khayyam Saleem <[email protected]> Co-authored-by: Vladimir Cibizov <[email protected]> Co-authored-by: Al-un <[email protected]> Co-authored-by: Larry <[email protected]>
…or app translations into spanish
Jharmony
requested review from
gretzky,
julienben,
justingreenberg,
jwinn and
Mensae
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ES TRANSLATION, ADD CODE IN i18n.js, es.json FILES
Refactored file at app/i18n.js by adding esLocaleData and esTranslationMessages variables. Also cleaned up the code in this file for proper functionality like pointing at new translation JSON file es.json. Added a new es.json file with a complete translation of the react-boilerplate app.
added variable/functions in i18n.js file, and added an es.json file for app translations into Spanish.