Move react-tools.umd.cjs back to react-tools.js to fix script blocking
#89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Change Vite config to output only a UMD build to react-tools.js * Fix script with nonstandard .cjs extension being blocked in the browser when the X-Content-Type-Options: nosniff header is present. * Fix missing rollup dependencies in package-lock.json by running npm audit fix
glin
commented
Sep 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed fix for #86. @timelyportfolio feel free to take/change whatever, but at least this should be one more possible workaround for the issue. Users can do a
remotes::install_github("glin/reactR")for 0.6.0 with this patch.react-tools.js.cjsextension being blocked in the browser when theX-Content-Type-Options: nosniffheader is present.package-lock.jsonby runningnpm audit fix- wasn't intentional, butnpm run buildfailed for me andnpm audit fixjust happened to resolve both that issue and a "high" vulnerability in some package.