refactor(client): explicit timeout during connect #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robsliwi
approved these changes
Nov 7, 2022
| } | ||
| }; | ||
| // Wait for connection state to be closed | ||
| let mut timer = interval(Duration::from_millis(10)); |
There was a problem hiding this comment.
Wonder were this magic number comes from. Or is it part of the spec? 🙈
There was a problem hiding this comment.
Probably just tried & tested? I'm not that familiar with the code to really say. Just looking at it now, it's even possible that the whole loop here could be removed because all the work happens inside the spawn_looping_tasks that build upon the read- and write-halfs of the connection and this task doesn't really need to do anything anymore.
Comment on lines
+417
to
+418
| debug! {"Sending HELLO"} | ||
| ; |
There was a problem hiding this comment.
Suggested change
| debug! {"Sending HELLO"} | |
| ; | |
| debug! {"Sending HELLO"}; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We observed a scenario where the client was stuck trying to connect. Most likely cause is that packets were
DROPed from the network instead of beingREJECTed. This adds an experimental explicit timeout to theTcpStream::connectcall.