Restricted accounts

[jochenklar]

This PR adds the following settings:

• PROJECT_CREATE_RESTRICTED prevents user from creating (or importing) new projects
• PROJECT_CREATE_GROUPS allows users from groups in this list to create projects when PROJECT_CREATE_RESTRICTED = True
• ACCOUNT_GROUPS is a list of groups which new users, who sign up using the regular allauth signup form, get added to.
• SOCIALACCOUNT_GROUPS is a dict of lists of groups which new users, who sign up using the regular allauth signup form, get added to, seperated by provider.

E.g.

PROJECT_CREATE_RESTRICTED = True
PROJECT_CREATE_GROUPS = [
    'allauth'
]

ACCOUNT_GROUPS = ['allauth']
SOCIALACCOUNT_GROUPS = {
    'github': ['github']
}

would move all users, who sign up using the form to the allauth group and all users, who login via GitHub to the github group. Only users from the login form can create projects in this case.

LDAP and Shibboleth setups can add users to groups using their respective API.

[coveralls]

coverage: 80.521% (-0.06%) from 80.581% when pulling 7d60faf on restricted_accounts into bb5f093 on master.

[MyPyDavid]

would this be interesting for a feature like this?

• https://www.honeybadger.io/blog/options-for-passwordless-authentication-in-django/

[jochenklar]

Öh, the part with allauth we already do ... I don't see the need for magic links in RDMO.

[jochenklar]

Ok, flattened the if/else blocks, but I kept some of the else conditions for readability.

[jochenklar]

@MyPyDavid @afuetterer for some reason I still don't understand, this change removed a substantial part of our tests from the CI. The tests run, but they are not included in just running pytest. This concerned import and export. I should have investigated when the coverage dropped after 2.0.

[MyPyDavid]

ok, oops 🙈 , strange but good to know

[afuetterer]

Which one was problematic?
test_.py or test_[!.txt].py?

What is the meaning of test_*[!.txt].py?

[jochenklar]

test_*[!.txt].py. I think @MyPyDavid wanted to exclude files like test_foo_bar.txt.py, but apparently it does not work that way. It did exclude, e.g. test_view_project_create_import.py.

[jochenklar]

I think I got it, all the missing tests got a t at the end:

test_validator_parent.py
test_viewset_import.py
test_export.py
test_validator_conflict.py
test_view_project.py
test_view_project_create_import.py
test_view_project_update_import.py
test_view_snapshot.py
test_viewset_project.py
test_viewset_project_snapshot.py
test_viewset_snapshot.py
test_viewset_questionset.py

I got the list with pytest --co with and without the pattern and some grepping.

The pattern means that the file must not end with .tx before the .py.